[Insight-developers] itkAnalyzeImageIO issue with offset

[Mathieu Coursolle]

Hi,

Good catch, sorry about that.

Do you know which warning flags need to be turned on to trigger that warning ?
For some reason, our build machines did not produce that warning.

Since the vox_offset is a float, but specifies a byte offset, would it be safe to truncate
it ? I mean, is there any chance it might not be a signed integer ? 

Thanks,
Mathieu

On 2009-12-23, at 2:25 PM, Bradley Lowekamp wrote:

> Hello Mathieu,
> 
> Your changes have produced the following warning  messages:
> 
> http://www.cdash.org/CDash/viewBuildError.php?type=1&buildid=499477
> 
> ::gzseek(file_p, m_Hdr.dime.vox_offset, SEEK_SET);
> 
> It appears that the vox_offset member is of type float, from itkAnalyzeDbh.h:
> 
>  /*68 + 4 */ float vox_offset;  /**< Byte offset in the .img file at which voxels start. If value is
>                                      negative specifies that the absolute value is applied for every
>                                      image in the file. */
> 
> It would be particularly odd to use the type of offset into a file.
> 
> Brad
> 
> On Dec 18, 2009, at 11:10 AM, Hans Johnson wrote:
> 
>> Mathieu,
>> 
>> I am nearly certain that your analysis is correct.  I am supportive of
>> including this bug fix.
>> 
>> Hans
>> 
>> -- 
>> Hans J. Johnson, Ph.D.
>> Assistant Professor
>> 200 Hawkins Drive
>> T205 BT, The University of Iowa
>> Iowa City, IA 52242
>> 
>> hans-johnson at uiowa.edu
>> PHONE: 319 353 8587
>> 
>> 
>> 
>>> From: Mathieu Coursolle <mathieu at rogue-research.com>
>>> Date: Fri, 18 Dec 2009 11:04:56 -0500
>>> To: ITK <insight-developers at itk.org>
>>> Subject: Re: [Insight-developers] itkAnalyzeImageIO issue with offset
>>> 
>>> I am sorry if you receive this email twice, but it seems to have fail on
>>> previous attempts.
>>> Mathieu
>>> 
>>> 
>>>>> Hi ITK Developers,
>>>>> 
>>>>> We use the itkAnalyzeImageIO in our application to read Analyze file format.
>>>>> Recently, one of our customers sent us a file that was not read properly.
>>>>> After
>>>>> investigation, I realized that the 'vox_offset' parameter of the Analyze
>>>>> header
>>>>> seems to be ignored in the itkAnalyzeImageIO.
>>>>> 
>>>>> Was there an historical reason for that, or it was just never implemented. I
>>>>> filled
>>>>> issue #10050 (http://public.kitware.com/Bug/view.php?id=10050)
>>>>> with a proposed patch. If nobody objects, I'll commit the fix this week.
>>>>> 
>>>>> Thanks,
>>>>> Mathieu
>>>> 
>>> 
>>> _______________________________________________
>>> Powered by www.kitware.com
>>> 
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>> 
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>> 
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>> 
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>> 
>> _______________________________________________
>> Powered by www.kitware.com
>> 
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>> 
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>> 
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>> 
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
> 
> ========================================================
> Bradley Lowekamp  
> Lockheed Martin Contractor for
> Office of High Performance Computing and Communications
> National Library of Medicine 
> blowekamp at mail.nih.gov
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20091223/7df48810/attachment.htm>