[Insight-developers] Teem : NrrdIO sync with ITK : NrrdIO - now proceeding...

[Gordon L. Kindlmann]

Hello,

Thanks very much for working on this.

On Dec 18, 2009, at 7:46 AM, Michel Audette wrote:

> Hi Gordon,
>
> I am the software engineer at Kitware doing the reconciliation  
> between ITK's NrrdIO directory and Teem's NrrdIO directory. Looking  
> at the revision history of the former on the ITK Dashboard, most of  
> the comments that followed your own 2005 commits are of the nature...
>
> Addressing warnings in Windows 64bits related to conversions from  
> size_t to int and to unsigned int.
> Addressing warnings in Windows 64bits related to conversions from  
> size_t to ints and unsigned ints.
>
> Unless you or other ITK developers object, my strategy will be to  
> retain the extra functionality that you have in Teem in the final  
> version, with a view to replacing the size_t's by unsigned ints, and  
> in general keep a superset of the two sets of changes.

Can you explain this in a little more detail?   What's an example of a  
size_t that would be changed to an unsigned int?

I'm guessing that these are warnings about printf'ing a size_t value  
with an unsigned int format sequence, right?  Its the printf format  
sequence that should be changed, not the type of variable itself.  How  
Nrrd is using size_t is not something that should be changed for this.

> You seem to have emphasize const pointers in Teem, which could be  
> applied to the ITK version, since these are now increasingly  
> emphasized in ITK style.

great.

> I welcome any comments from you and the community that relate to  
> this update.

I've augmented the table here:

http://www.itk.org/Wiki/Proposals:Updating_Nrrd_library_2009#Table

to better document where files in NrrdIO are coming from; whether  
they're copied (via NrrdIO/pre-GNUmakefile) from Teem itself, and if  
so where.  This should help back-propagate the changes.

Is there an *easy* way of linking from the files listed on that table,  
to a ViewVC-type record of the changes that it has seen in ITK?

Finally, to make changes in Teem you'll need to be added to the  
sourceforge Teem project; let me know your sourceforge login (or  
create one if you don't have one already) so that I can do this.

thanks,
Gordon

>
> Best wishes,
>
> Michel
>
>
> On Thu, Dec 17, 2009 at 11:14 AM, Luis Ibanez  
> <luis.ibanez at kitware.com> wrote:
> Hi Gordon,
>
> I hope you are doing well.
>
> We are going to start diving into the synchronization
> of the NrrdIO library in Teem and the one in ITK.
>
> Michel Audette (in CC) will be primarily doing this,
> so you probably will hear a lot from him in the
> following days/weeks    :-)
>
> In intermediate steps we will copy emails to the
> ITK Developers list, just to make sure that we leave
> enough traces of information for the next person who
> have to sync the libraries.
>
> We are starting from the guidelines that we put
> together in the ITK Wiki:
> http://www.itk.org/Wiki/Proposals:Updating_Nrrd_library_2009
>
>
> A) In a first phase,
> we will identify all changes made in ITK / NrrdIO that
> should be considered for insertion into the Teem / NrrdIO
> library.
>
> B) Then, in a second phase,
> we will sync the new version of Teem/NrrdIO into ITK.
>
> We started taking a look at (A), and found indications
> that you synchronized NrrdIO in ITK in November 2005.
> (is that correct ?)
>
> If so, we will use that date as our baseline for comparisons
> for (A).
>
> Also, we are wondering if the SVN history of NrrdIO
> was carried over when you extracted it from Teem.
> (that will be useful for phase (B)).
>
> and finally, we are wondering if there is a Dashboard
> where Nightly builds of Teem are submitted,  so that
> we can use it as a reference.
>
> If not,...
> then we would suggest to make experimental
> submissions of Teem to the Slicer3 dashboard.
>
> I'm copying Steve Pieper too, since these updates
> may be an issue for Slicer.
>
>
>     Thanks for any comments,
>
>
>          Luis
>
>
>
> -- 
> Michel Audette, Ph.D.
> R & D Engineer,
> Kitware Inc.,
> Chapel Hill, N.C.
>