[Insight-developers] Insight Journal paper "A Label Geometry Image Filter for Multiple Object Measurement" moved to Review

[Luis Ibanez]

Bill,

Thanks for fixing that !

    Luis


------------------------------
On Mon, Dec 14, 2009 at 10:39 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> Also, if there was no intensity image provided, there was a floating
> point divide by zero in the computation of the Weighted Centroid.
> Although the results (nan) were visible in the test output, only the
> Borland compiler was kind enough to report a numerical error.
>
> Bill
> On Sun, Dec 13, 2009 at 4:54 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> Guys,
>>
>> I have a solution for the VS6 compile problem. I'm trying it on my
>> Borland and VS7 systems.
>>
>> It does not resolve Luis' design questions, but it seems like a
>> portable solution for the existing code. If all of my builds are
>> successful, I'll check it in tomorrow.
>>
>> Bill
>>
>> On Wed, Dec 9, 2009 at 11:18 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>>> Dirk, Jim,
>>>
>>> Today's Dashboard is showing the usual quirks with
>>> the Sun and Visual studio 6.0 compilers.
>>>
>>> The issue with VS6.0 requires some discussion:
>>> http://www.cdash.org/CDash/viewBuildError.php?buildid=489238
>>>
>>> Lines: 496-501
>>> declare a templated method inside a templated class,
>>> but the type of the template is not part of the arguments
>>> in the method signature:
>>>
>>>
>>> template<class TLabelImage, class TIntensityImage>
>>> template<class TGenericImage>
>>> bool
>>> LabelGeometryImageFilter<TLabelImage, TIntensityImage>
>>> ::CalculateOrientedImage(vnl_symmetric_eigensystem<double> eig,
>>> LabelGeometry & labelGeometry, bool useLabelImage)
>>> {
>>>
>>>
>>>
>>> Our typical solution to this problem is to make the template
>>> argument type to be one of the arguments of the function or
>>> method.
>>>
>>>
>>> However, the overall design of this method is strange, since
>>> in addition to the template argument, it also includes a boolean
>>> that will switch the method from one behavior to another.
>>>
>>>
>>> Now... I am probably missing something here...
>>> but at first sight,
>>> having to rotate (by resampling) an image in order to
>>> compute the rotated bounding box, sounds like a very
>>> inefficient (and  unnecessary) way of arriving to such
>>> computation.
>>>
>>>
>>> Could you please elaborate on the rationale for
>>> performing this computation via this route ?
>>>
>>>
>>> We certainly would like to take care of this
>>> compilation error in VS6.0   today.
>>>
>>>
>>>
>>>    Thanks,
>>>
>>>
>>>        Luis
>>>
>>>
>>> --------------------------------------------------------------------------------
>>> On Tue, Dec 8, 2009 at 7:57 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>>>> Dirk, Jim,
>>>>
>>>>
>>>> In preparation for the ITK 3.18 release,
>>>>
>>>>
>>>> Your paper:
>>>>
>>>> "A Label Geometry Image Filter for Multiple Object Measurement"
>>>>     http://www.insight-journal.org/browse/publication/301
>>>>     http://hdl.handle.net/1926/1493
>>>>
>>>>
>>>> has been moved into the directory
>>>>
>>>>               Insight/Code/Review
>>>>
>>>>
>>>> A)  Many coding style changes were made to the
>>>>     source code in the Insight Journal.
>>>>
>>>> B)  Only the 2D test has been incorporated.
>>>>
>>>>     The image provided in the IJ paper for
>>>>     the 3D test is a bit too large for ITK standards.
>>>>
>>>>     Could you suggest a smaller image to use ?
>>>>
>>>>     Ideally one that is already in Testing/Data/Input   :-)
>>>>
>>>>
>>>> C) The Code Review is not yet complete,
>>>>    we are still going through the list of items
>>>>    in the Check List
>>>>
>>>>    http://www.itk.org/Wiki/ITK_Code_Review_Check_List
>>>>
>>>>
>>>> In the meantime, we anticipate the usual tweaking
>>>> with different platforms (Borland, Cygwin, Sun CC...).
>>>> We will take care of it in the following days.
>>>>
>>>>
>>>>     Thanks
>>>>
>>>>
>>>>         Luis
>>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>
>>
>