[Insight-developers] CVS commit Style check for the file "dsrc2c.c" hangs...

[Julien Jomier]

Hi Luis,

There is no way to relate a path in the CVS pre-commit script that's why 
we cannot use the ITKFiles.txt in the pre-commit script. That said we 
can disable the check on specific files directly in the pre-commit script.

I have disable the check for .c files so that should help, otherwise let 
me know.

Julien

Luis Ibanez wrote:
> Hi Julien,
> 
> Sure, I'll send it to you.
> 
> (it is my Mac Mini at home, so, I'll do it this evening).
> 
> I ran KWStyle on it manually, and it certainly takes
> a long time (which is not surprising because it is
> a *very large* file), and it also reports many style
> errors, (which is not surprising either because it is
> Fortran translated in to C), but... still finished in some
> finite amount of time.
> 
> At the end, the real issue is that this file should be
> excluded from Style checking (because it is Fortran
> translated in to C).
> 
> 
>     Thanks
> 
> 
>          Lusi
> 
> 
> ----------------------------
> On Thu, Dec 3, 2009 at 11:02 PM, Julien Jomier
> <julien.jomier at kitware.com> wrote:
>> Hi Luis,
>>
>> Could you send me the file so I can check why KWStyle fails? Did you try to
>> run it manually before checking it in? I haven't upgraded KWStyle for the
>> pre-commit check in a long time, so that might be the issue.
>>
>> Julien
>>
>> Luis Ibanez wrote:
>>> Hi Julien,
>>>
>>>
>>> I'm trying to commit to ITK some fixes in the file:
>>>
>>>       Insight/Code/Numerics/FEM/dsrc2c.c
>>>
>>> and the commit seems to get trapped in the process
>>> of checking the Style.
>>>
>>> Here is the message I get:
>>>
>>> cvs commit
>>> cvs commit: Examining .
>>> Committer: Luis Ibanez <luis.ibanez at kitware.com>
>>> Running style check
>>> Running style check
>>> Processing dsrc2c.c
>>>
>>>
>>> and then hangs in there... (with not further error message).
>>>
>>> It seems to have entered an infinite loop....
>>>
>>>
>>> The strange thing is that this file shouldn't be included
>>> in the Code Style check, because the ITKFiles.txt file
>>> in
>>>
>>>    Insight/Utilities/KWStyle/
>>>
>>> only has the following regular expressions:
>>>
>>> ITKFiles.txt.in:@ITK_SOURCE_DIR@/Code/Numerics/FEM/itk*.h
>>> ITKFiles.txt.in:@ITK_SOURCE_DIR@/Code/Numerics/FEM/itk*.txx
>>> ITKFiles.txt.in:@ITK_SOURCE_DIR@/Code/Numerics/FEM/itk*.cxx
>>>
>>>
>>>
>>>    Thanks for any hints,
>>>
>>>
>>>             Luis
>>>
>