[Insight-developers] Proposal: Changing NumericTraits of vector types to use macros

[Bradley Lowekamp]

Gaetan,

 As these changes were larger then expected am glad to hear that you had a read through. I believe that the min, max, and nonpositiveMin methods were not there before for the FixedArray, Vector, CovariantVector and Tensor NumericTraits. So I presumed it was just result of copying and pasting the macro.

Is there a use for these traits? 
Would it enable these pixel types to use a filter the currently couldn't?

The VariableLengthVector defined these methods with a Self& argument. 
Should these other types define these additional methods as well?
Are there filters that could use it?

As it is much harder to remove methods from itk then it is to add, I am cautious of adding new methods that will not be used. If there is a use, we should write a test to make sure it's right, and work the expected way.

Brad
On Dec 3, 2009, at 9:23 AM, Gaëtan Lehmann wrote:

> 
> Brad,
> 
> I've readded the methods max(), min() and NonpositiveMin() to the array traits.
> I think they were removed by mistake in
> 
>  http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Common/itkNumericTraitsFixedArrayPixel.h?root=Insight&r1=1.6&r2=1.7&sortby=date
> 
> , but maybe I'm wrong. Was it done on purpose?
> 
> Regards,
> 
> Gaëtan
> 
> 
> 

========================================================
Bradley Lowekamp  
Lockheed Martin Contractor for
Office of High Performance Computing and Communications
National Library of Medicine 
blowekamp at mail.nih.gov


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20091203/aa1ab4af/attachment.htm>