[Insight-developers] Wrapping with USE_REVIEW_STATISTICS=ON

[kent williams]

The patch below will get things compiling again and looks correct to me. If
it passes regression tests I¹m checking it in.

There is also a wrapping gap in that class.

Warning 
itk::Statistics::Histogram<double,itk::Statistics::DenseFrequencyContainer2>
has a class hierarchy that has wrapping gaps.
The class hierarchy wrapping is as follows:
Not wrapped: itk::Statistics::Sample<(itk::Array<(double)>)>
    Wrapped: itk::DataObject
    Wrapped: itk::Object
    Wrapped: itk::LightObject

[ 51%] Generating wrap_itkMaximumImageFilterTcl.cxx
[ 51%] Generating wrap_itkMinimumImageFilterTcl.cxx
[ 51%] Generating wrap_itkMinimumMaximumImageCalculatorTcl.cxx
[ 51%] Generating wrap_itkMinimumMaximumImageFilterTcl.cxx
[ 51%] Generating wrap_itkNoiseImageFilterTcl.cxx
[ 51%] Generating wrap_itkScalarImageToHistogramGeneratorTcl.cxx
Warning 
itk::Statistics::Histogram<double,itk::Statistics::DenseFrequencyContainer2>
has a class hierarchy that has wrapping gaps.
The class hierarchy wrapping is as follows:
Not wrapped: itk::Statistics::Sample<(itk::Array<(double)>)>
    Wrapped: itk::DataObject
    Wrapped: itk::Object
    Wrapped: itk::LightObject

_______________________THE PATCH__________________________________
cvs diff: Diffing .
Index: itkScalarImageToHistogramGenerator.txx
===================================================================
RCS file: 
/cvsroot/Insight/Insight/Code/Review/Statistics/itkScalarImageToHistogramGen
erator.txx,v
retrieving revision 1.3
diff -c -r1.3 itkScalarImageToHistogramGenerator.txx
*** itkScalarImageToHistogramGenerator.txx    8 Aug 2009 14:18:14 -0000
1.3
--- itkScalarImageToHistogramGenerator.txx    17 Aug 2009 15:54:57 -0000
***************
*** 75,84 ****
  ScalarImageToHistogramGenerator< TImage >
  ::SetHistogramMin( RealPixelType minimumValue )
  {
!   typedef typename GeneratorType::MeasurementVectorType
MeasurementVectorType;
    MeasurementVectorType minVector;
    minVector[0] = minimumValue;
!   m_HistogramGenerator->SetHistogramMin( minVector );
  }
  
  
--- 75,84 ----
  ScalarImageToHistogramGenerator< TImage >
  ::SetHistogramMin( RealPixelType minimumValue )
  {
!   typedef typename GeneratorType::HistogramMeasurementVectorType
MeasurementVectorType;
    MeasurementVectorType minVector;
    minVector[0] = minimumValue;
!   m_HistogramGenerator->SetHistogramBinMinimum( minVector );
  }
  
  
***************
*** 87,96 ****
  ScalarImageToHistogramGenerator< TImage >
  ::SetHistogramMax( RealPixelType maximumValue )
  {
!   typedef typename GeneratorType::MeasurementVectorType
MeasurementVectorType;
    MeasurementVectorType maxVector;
    maxVector[0] = maximumValue;
!   m_HistogramGenerator->SetHistogramMax( maxVector );
  }
  
  template < class TImage >
--- 87,96 ----
  ScalarImageToHistogramGenerator< TImage >
  ::SetHistogramMax( RealPixelType maximumValue )
  {
!   typedef typename GeneratorType::HistogramMeasurementVectorType
MeasurementVectorType;
    MeasurementVectorType maxVector;
    maxVector[0] = maximumValue;
!   m_HistogramGenerator->SetHistogramBinMaximum( maxVector );
  }
  
  template < class TImage >



On 8/15/09 12:18 PM, "Hans Johnson" <hans-johnson at uiowa.edu> wrote:

> Has anyone successfully used wrapping with the new statistics framework?
> 
> [ 64%] Building CXX object
> Wrapping/WrapITK/Modules/Calculators/CMakeFiles/CalculatorsTcl.dir/wrap_itkSca
> larImageToHistogramGeneratorTcl.o
> /IPLlinux/ipldev/scratch/hjohnson/src/BRAINS-COMPILE/Linux/FAST_64-lib/Insight
> /Code/Review/Statistics/itkScalarImageToHistogramGenerator.txx: In member
> function `void 
> itk::Statistics::ScalarImageToHistogramGenerator<TImageType>::SetHistogramMax(
> typename itk::NumericTraits<typename TImage::PixelType>::RealType) [with
> TImageType = itk::Image<short int, 2u>]':
> /IPLlinux/ipldev/scratch/hjohnson/src/BRAINS-COMPILE/Linux/FAST_64-lib/Insight
> -build/Wrapping/WrapITK/Modules/Calculators/wrap_itkScalarImageToHistogramGene
> ratorTcl.cxx:1284:   instantiated from here
> /IPLlinux/ipldev/scratch/hjohnson/src/BRAINS-COMPILE/Linux/FAST_64-lib/Insight
> /Code/Review/Statistics/itkScalarImageToHistogramGenerator.txx:93: error:
> 'class 
> itk::Statistics::SampleToHistogramFilter<itk::Statistics::ImageToListSampleAda
> ptor<itk::Image<short int, 2u> >, itk::Statistics::Histogram<double,
> itk::Statistics::DenseFrequencyContainer2> >' has no member named
> 'SetHistogramMax'
> /IPLlinux/ipldev/scratch/hjohnson/src/BRAINS-COMPILE/Linux/FAST_64-lib/Insight
> /Code/Review/Statistics/
> <CLIP>
> [hjohnson at compute22 Modules]$ vim
> /IPLlinux/ipldev/scratch/hjohnson/src/BRAINS-COMPILE/Linux/FAST_64-lib/Insight
> /Code/Review/Statistics/itkScalarImageToHistogramGenerator.txx
> 
> 
> Thanks,
> Hans
> 
> 
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090817/726fd005/attachment.htm>