[Insight-developers] New failing test added

[Bradley Lowekamp]

There it is  Code/Review/Statistics/CMakeLists.txt line 35:
DESTINATION ${ITK_INSTALL_INCLUDE_DIR_CM24}/Numerics/Statistics

This is the old include directory and should be changed to:
DESTINATION ${ITK_INSTALL_INCLUDE_DIR_CM24}/Review/Statistics


If I recall correctly,
Brad

On Aug 7, 2009, at 11:42 AM, Hans Johnson wrote:

> Luis,
>
> When I tried to migrate to the new statistics framework, I ran into  
> compilation problem in InsightApplications:
>
> [  2%] Built target itk2DAnisotropicDiffusionImageFilter
> [  5%] Building CXX object MRIBiasCorrection/CMakeFiles/ 
> BiasCorrector.dir/BiasCorrector.o
> In file included from /scratch/hjohnson/src/brains2/MacOSX/ 
> FAST_64_64/src/include/InsightToolkit/Algorithms/ 
> itkMRIBiasFieldCorrectionFilter.h:29,
>                  from /scratch/hjohnson/src/brains2/iplFreeware/ 
> unpackdir/InsightApplications/MRIBiasCorrection/BiasCorrector.cxx:24:
> /scratch/hjohnson/src/brains2/MacOSX/FAST_64_64/src/include/ 
> InsightToolkit/Numerics/itkOnePlusOneEvolutionaryOptimizer.h:21:43:  
> error: itkRandomVariateGeneratorBase.h: No such file or directory
> /scratch/hjohnson/src/brains2/iplFreeware/unpackdir/ 
> InsightApplications/MRIBiasCorrection/BiasCorrector.cxx:35:26:  
> error: itkHistogram.h: No such file or directory
> /scratch/hjohnson/src/brains2/iplFreeware/unpackdir/ 
> InsightApplications/MRIBiasCorrection/BiasCorrector.cxx: In function  
> ‘double compute_PercVal(ImagePointer&, double)’:
> /scratch/hjohnson/src/brains2/iplFreeware/unpackdir/ 
> InsightApplications/MRIBiasCorrection/BiasCorrector.cxx:148: error:  
> expected initializer before ‘<’ token
> ... CLIP ....
> make[3]: *** [MRIBiasCorrection/CMakeFiles/BiasCorrector.dir/ 
> BiasCorrector.o] Error 1
> make[2]: *** [MRIBiasCorrection/CMakeFiles/BiasCorrector.dir/all]  
> Error 2
> make[1]: *** [all] Error 2
> make: *** [/scratch/hjohnson/src/brains2/MacOSX/FAST_64_64/src/bin/ 
> BiasCorrector] Error 2
> [hjohnson at neuron brains2]$ cd iplFreeware/unpackdir/ 
> InsightApplications/
>
>
>
> Is there a “Statistics Framework Migration Guide” on the WIKI?
>
> Thanks,
> Hans
>
> -- 
> Hans J. Johnson, Ph.D.
> Assistant Professor
> 200 Hawkins Drive
> T205 BT, The University of Iowa
> Iowa City, IA 52242
>
> hans-johnson at uiowa.edu
> PHONE: 319 353 8587
>
>
>
> > From: Luis Ibanez <luis.ibanez at kitware.com>
> > Date: Fri, 07 Aug 2009 08:24:39 -0400
> > To: Hans Johnson <hans-johnson at uiowa.edu>
> > Cc: Bill Lorensen <bill.lorensen at gmail.com>, Bradley Lowekamp
> > <blowekamp at mail.nih.gov>
> > Subject: Re: New failing test added
> >
> > Hi Hans,
> >
> > Thanks for pointing this out.
> >
> > This is something the Brad has also mentioned recently.
> >
> > We should take a look and figure out a fix...
> >
> > However, I'll encourage you to migrate to use the new
> > Statistics framework.
> >
> >
> >     Luis
> >
> >
> > ------------------
> > Hans Johnson wrote:
> >> Bill and Luis,
> >>
> >> I’ve added a new test that is currently failing. It was written  
> to show
> >> a problem that we were having with many of our high-resolution  
> images:
> >>
> >> The itkSparseFreqeuncyContainer, and the  
> itkDenseFrequenceyContainer are
> >> using floating point values for their FrequencyType.  I am not  
> sure if
> >> the new statistics framework has the same issue.
> >>
> >> In many common images of size 512x512x384 have backgrounds of all  
> zeros
> >> with a count greater than the maximum that can be incremented to  
> using
> >> 32 bit floating point numbers.
> >>
> >> This is documented in http://public.kitware.com/Bug/view.php? 
> id=9383
> >>
> >> You can see the failing test code that has notes describing the  
> problem
> >> in detail:
> >> http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/Numerics/Statistic
> >> s/itkScalarImageToHistogramGeneratorTest.cxx? 
> root=Insight&r1=1.2&r2=1.3&sortb
> >> y=date
> >> <http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/Numerics/Statisti
> >> cs/itkScalarImageToHistogramGeneratorTest.cxx? 
> root=Insight&r1=1.2&r2=1.3&sort
> >> by=date>
> >>
> >>
> >> =======================================
> >>
> >> I’ve not been able to figure out an acceptable way to fix this bug
> >> without changing the current return types and preserve backwards
> >> compatibility.
> >>
> >> Your advice would be greatly appreciated.
> >>
> >> Thanks,
> >> Hans
> >>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090807/075aed2d/attachment.htm>