[Insight-developers] Problems with SymmetricSecondRankTensor and DiffusionTensors3D

[kent williams]

I don't think an omnibus bug report/patch is the greatest idea.

Item #1 is the sort of thing someone with write access to ITK could just
check in, with a simple regression test to exercise it.  It's a
non-controversial enhancement to ITK.

Items 2,3,4,& 5 sound like they could benefit from independent code review.
I don't know what 'templated constructor' means in this context.  I also
think that the bug 0008574 patch advocates breaking backwards compatibility,
which probably won't fly.

On 4/24/09 10:52 AM, "Luke Bloy" <luke.bloy at gmail.com> wrote:

> Hi itk-developers,
> 
> I have a patch that does a number of things.
> 
> 1) adds numeric traits for both itkDiffusionTensor3D and
> itkSymmetricSecondRankTensor
> 2) adds templated constructors to enable casting with different internal
> types
> 3) modifies the patch in http://www.itk.org/Bug/view.php?id=8574 to have
> the Rotate method be templated over the internal type of the Matrix
> argument. plus adds some convience methods to cast from different types
> of matrix classes.
> 
> 4) adds support for the log-euclidean metric for dti.
>    4a) added GetMatrixExp( ) to SymmetricSecondRankTensor which computes
> the matrix exponential and returns a SymmetricSecondRankTensor
>    4b) added GetMatrixLog()  to DiffusionTensor3D, which computes the
> matrix log and returns a SymmetricSecondRankTensor
> 
> 5) added tests for all these methods.
> 
> Because its a mix of bugs and feature requests, i wasn't sure how/if to
> put it in mantis.
> 
> Thanks,
> -Luke
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers



Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.