[Insight-developers] itkImageToHistogramFilter class and test issues

[Karthik Krishnan]

On Wed, Apr 15, 2009 at 9:39 AM, Karthik Krishnan <
karthik.krishnan at kitware.com> wrote:

> Dear Luis:
>
> As Brad already noticed, I just fixed a bug in the itk::Sample and
> itk::Histogram classes. These weren't implementing the GraftOutput methods.
> This means that the itk::ImageToHistogramFilter was never tested correctly
> (despite its code coverage) and the passing test.
>
> After I fixed these methods, the itkImageToHistogramFilterTest fails (as it
> rightly should). This brings me to the implementation of the test. The Min
> and Max limits for the histogram are both set at a value of 17, causing the
> test to exercise a trivial test. Any query returns an out of bounds value
> and all the index queries from the histogram are essentially out of bounds.
>
> Could you please tell us if this is the intent of the test ? Or shall I
> rework the test to produce a meaningful result ?


Fixed on this test..

Sending        itkImageToHistogramFilterTest.cxx
Transmitting file data .
Committed revision 4165.


>
>
> Commit log....
> Sending        itkHistogram.h
> Sending        itkHistogram.txx
> Sending        itkSample.h
> Committed revision 4148.
>
>
> I suspect we should go through several other filters to make sure that they
> are functionally correct.
>
> Thanks
> --
> karthik
>


--
karthik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090417/cd11b041/attachment.htm>