[Insight-developers] GetInverse is unusable -- patch attached

[Luis Ibanez]

Hi Tom,

Thanks for committing the patch.

Please not that it is not compiling in Visual Studio 6.0.

(See dash13.kitware:)
http://www.cdash.org/CDash/viewBuildError.php?buildid=309403
http://www.cdash.org/CDash/viewBuildError.php?buildid=309421


Any suggestions ?


    Thanks


       Luis


-----------------------
Tom Vercauteren wrote:
> Hi Luis,
> 
> I have checked in the changes, e.g.:
> http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Common/itkTransform.h?root=Insight&r1=1.65&r2=1.66&sortby=date
> 
> I chose to rename the new method as
>   GetInverseTransform(void)
> and not GetInverseTransform()
> 
> This avoids potential hiding problems.
> 
> Regards,
> Tom
> 
> P.S.: I'll try to keep an eye on the dashboard but since I don't
> receive emails for the continuous builds I might be less responsive
> than I could.
> 
> On Wed, Apr 8, 2009 at 17:41, Luis Ibanez <luis.ibanez at kitware.com> wrote:
> 
>>Please feel free to go ahead with the patch.
>>Let us know as soon as you committed, so that we
>>can track issues in any other platforms.
>>
>>
>>      Thanks
>>
>>
>>            Luis
>>
>>
>>------------------------------------------------------------------------------
>>On Wed, Apr 8, 2009 at 9:00 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>>
>>>Hi Tom,
>>>
>>>Does the patch includes new classes ?
>>>
>>>If so, the new classes will have to go through the Insight Journal.
>>>
>>>Let me look at the patch from the file that was attached to bug 7876.
>>>I'll get back to you soon.
>>>
>>>
>>>   Luis
>>>
>>>
>>>---------------------------------------------------------------------
>>>On Wed, Apr 8, 2009 at 8:53 AM, Tom Vercauteren <tom.vercauteren at m4x.org> wrote:
>>>
>>>>Hi Luis,
>>>>
>>>>As pointed out by Pavel, the current GetInverse function in
>>>>itk::Transform is very limited. He provided an initial backward
>>>>compatible patch which is in the bug tracker
>>>> http://www.kwwidgets.org/Bug/bug_view_advanced_page.php?bug_id=7876
>>>>and discussed on this wiki page:
>>>> http://www.itk.org/Wiki/Proposals:InverseTransform
>>>>
>>>>I'd like to "adopt this bug". As a matter of fact, I just spent some
>>>>time working on this issue and have a new patch that extends the one
>>>>from Pavel. All unit tests that were using either
>>>> GetInverse(Self *)
>>>>or
>>>> CloneInverseTo(Pointer &)
>>>>now also cover
>>>> GetInverse()
>>>>
>>>>This means that most (if not all) transforms that had one of those
>>>>inversion methods or were depending on an inversion method in their
>>>>superclass now have a working GetInverse() method.
>>>>
>>>>Since no new class need to be added and since two independent
>>>>developers have been working on this, I don't think it needs to go
>>>>through the IJ paper step.
>>>>
>>>>May I just go and commit the enhanced patch?
>>>>
>>>>Tom
>>>>
>>>>P.S.: The new patch is too large to be attached here. I have attached
>>>>it to bug 7876
>>>>http://www.itk.org/Bug/view.php?id=7876
>>>>
>>>>
>>>>On Tue, Apr 7, 2009 at 20:19, Paul Koshevoy <koshevoy at sci.utah.edu> wrote:
>>>>
>>>>>Paul Koshevoy wrote:
>>>>>
>>>>>>Hi Tom,
>>>>>>
>>>>>>It's been 2 years since I left the SCI Institute at the University of
>>>>>>Utah.  I have a full time job at Sorenson Media, and occasional consulting
>>>>>>for SCI Institute CRCNS group, maintaining the ir-tools, ir-tweak,
>>>>>>ir-mosaic, etc... that I've created for them years ago.  I can't bring
>>>>>>myself to spend the time on writing a technical report to justify these
>>>>>>simple changes, as well as coming up with test cases and sample datasets.
>>>>>> Patching ITK with each new release is so much easier -- it's just adding
>>>>>>5-10 to 5 ITK transforms.
>>>>>>
>>>>>
>>>>>I meant to say it's just 5-10 lines added to just a few ITK files --
>>>>>
>>>>>itkIdentityTransform.h
>>>>>itkMatrixOffsetTransformBase.h
>>>>>itkScaleTransform.h
>>>>>itkTransform.h
>>>>>itkTranslationTransform.h
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>What I am saying is that to contribute these changes to the ITK I have to
>>>>>>get over a significant (artificial) barrier.  I don't feel right spending my
>>>>>>own time on this, and I can't charge the time it would take me to do this to
>>>>>>SCI/CRCNS because that is not a priority for them.
>>>>>>
>>>>>>I have the latest patch, as well as the fully patched files here:
>>>>>>https://code.sci.utah.edu/svn/ImageReconstruction/trunk/code/itk-patch/
>>>>>>Their SSL cert expired last weekend, so you may need to add a security
>>>>>>exception to be able to view the page.
>>>>>>
>>>>>>  Pavel.
>>>>>>
>>>>>
>>>>>
>