[Insight-developers] So -- no concensus on smoothing re MultiResolutionPyramidImageFilter?

[Tom Vercauteren]

Hi Kent,

Even if there is no consensus about what the default should be, it
could be add a flag that lets the user decide (as Stephen suggested).

Maybe something like:
  m_SmoothIfUnitShrinkFactors

For backwards compatibility, the default for this flag would be:
  - true for MultiResolutionPyramidImageFilter
  - false for RecursiveMultiResolutionPyramidImageFilter

Now, I also would like to propose a NON-backward compatible change to
fix something that might be very confusing to the user.

Since RecursiveMultiResolutionPyramidImageFilter wil call
MultiResolutionPyramidImageFilter if the schedule is not downward
divisible, I suggest that RecursiveMultiResolutionPyramidImageFilter
sets
  internalNonRecursivePyramid->SetSmoothIfUnitShrinkFactors(this->m_SmoothIfUnitShrinkFactors)
when the schedule is not downward divisible.

With this small non-backward compatible change, it would at least make
things a bit clearer.

Otherwise we might need a three state flag for
RecursiveMultiResolutionPyramidImageFilter:
  - AlwaysSmoothIfUnitShrinkFactors
  - NeverSmoothIfUnitShrinkFactors
  - SmoothIfUnitShrinkFactorsAndScheduleDownardDivisible (this being
the default for true backwards compatibility)

Thoughts anyone?

Tom

On Wed, Apr 8, 2009 at 23:27, kent williams <norman-k-williams at uiowa.edu> wrote:
> It seems Hans assigned me yesterday to fix this 'bug':
>
> http://www.vtk.org/Bug/view.php?id=7002
>
> As is noted there, there still doesn't appear to be a consensus on how to
> handle this problem.  So I've taken ownership of a bug with no clear way to
> fix it.
>
> If the issue is truly tabled, does it need to hang around as an open bug?
>
>
>
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>