[Insight-developers] NonThreadedShrinkImageFilter updating?

[Bill Lorensen]

I think the current tests do a decent job of exercising this class.
Coverage looks good.

Go for it!

Bill

On Tue, Apr 7, 2009 at 3:07 PM, Bradley Lowekamp <blowekamp at mail.nih.gov> wrote:
> I have my optimizations to itkShrinkImageFilter I have been waiting to
> commit too.
> I am still milling over the changes, thinking if there are any additional
> tests which need to be added. Do you have any suggestions?
> Brad
> On Apr 7, 2009, at 1:21 PM, Bill Lorensen wrote:
>
> I'll check in a change shortly.
>
> On Tue, Apr 7, 2009 at 12:55 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
>
> We could replace its implementation with a call to the threaded
>
> version, setting the number of threads to 1 in the GenerateData
>
> method. This would maintain backward compatibility, but remove the
>
> code duplication. It could be subclassed from the threaded version and
>
> set the number of threads to 1 in the constructor. I guess a
>
> SetNumberOfThreads override would also be required.
>
> Bill
>
> On Tue, Apr 7, 2009 at 11:38 AM, Bradley Lowekamp
>
> <blowekamp at mail.nih.gov> wrote:
>
> I just noticed that there is "itkNonThreadedShrinkImageFilter". This doesn't
>
> have any of the recent corrections that that the regular ShrinkImageFilter
>
> has gone through. As one can always set the number of threads to 1 in a
>
> filter I am not sure I understand it's current purpose.
>
> Should this class still be maintained? or is it pseudo depreciated?
>
> Brad
>
> ========================================================
>
> Bradley Lowekamp
>
> Lockheed Martin Contractor for
>
> Office of High Performance Computing and Communications
>
> National Library of Medicine
>
> blowekamp at mail.nih.gov
>
>
> _______________________________________________
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
>
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ITK FAQ at:
>
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
>
> http://www.itk.org/mailman/listinfo/insight-developers
>
>
>
>
> ========================================================
>
> Bradley Lowekamp
>
> Lockheed Martin Contractor for
>
> Office of High Performance Computing and Communications
>
> National Library of Medicine
>
> blowekamp at mail.nih.gov
>
>