[Insight-developers] Image as an OrientedImage Progress

[Bill Lorensen]

Here is the problem with the remaining failing tests. This issue has
been raised before.
See http://public.kitware.com/Bug/view.php?id=5573

There are really two "dimensions" of an image.

1) ImageDimension is the number of dimensions in the image container,
1, 2, 3, ...
2) I'll call it SpatialDimension, the number of dimensions in the
coordinate system of the image. This dimension is the dimension used
for origin, spacing and the direction.

For example, in general, DICOM images have an image dimension of 2,
yet the image position patient and directions are of dimension 3.
Analyze images have the same issue. And I'm sure nrrd's also.

In the failing tests, single dicom images are selected and the direction
1 0 0
0 0 -1
0 -1 0

The current logic in ImageFileReader, simply truncates the direction to:
1 0
0 0
which is singular.

So... we need some further thought about this problem.

On Tue, Sep 16, 2008 at 9:25 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>
> Bill,
>
> mm, you beat me again...
> How do you manage to be awake so early ?
>
>
>   Luis
>
>
>
> ------------------------
> Bill Lorensen wrote:
>>
>> Folks,
>>
>> As you can see in this build,
>> http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=173260
>> there are only 11 tests failing with
>> ITK_IMAGE_BEHAVES_AS_ORIENTED_IMAGE turned on.
>>
>> The previous failures were fixed by:
>>
>> BUG: need to initialize internal matrices if
>> ITK_IMAGE_BEHAVES_AS_ORIENTED_IMAGE is ON.
>>
>> http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Common/itkImage.txx?root=Insight&sortby=date&view=log
>>
>> BUG: directions were not initialized.
>>
>> http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkExtractImageFilter.txx?root=Insight&sortby=date&view=log
>>
>> BUG: After vector.resize() in  SetNumberOfDimensions, origin should be
>> set to 0 and spacing to 1, the defaults.
>>
>> http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/IO/itkImageIOBase.cxx?root=Insight&sortby=date&view=log
>>
>> ENH: support for ITK_IMAGE_BEHAVES_AS_ORIENTED_IMAGE.
>>
>> http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/SpatialObject/itkImageSpatialObject.txx?root=Insight&view=log#rev1.57
>>
>> BUG: spacing[0] = 0.0.
>>
>> http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/IO/itkReadWriteSpatialObjectTest.cxx?root=Insight&view=log#rev1.25
>>
>> This is very encouraging. In fact 8 of the failing tests are due to
>> one ANalyze test program that is producing processing 2D Analyze files
>> that have {1 0} {0 0} direction cosines.
>>
>> The other 3 are due to strange DICOM files I think.
>>
>> I'll look at the DICOM failures, but someone from Iowa (Hans or Kent)
>> will need to look at the Analyze issue.
>>
>> I have added better diagnostics to itkImage that produce more
>> informative errors (other than "Singular matrix"). This should help
>> find current and future test failures.
>>
>> BTW, no regression test images were changed or injured in this exercise!
>>
>> Bill
>> _______________________________________________
>> Insight-developers mailing list
>> Insight-developers at itk.org
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>