[Insight-developers] Okay to remove protected helper function, ExceptionObject::UpdateWhat()?

[Bill Lorensen]

Since it is protected and not private, it is possible that someone's
subclass is using it. Some subclass written by an ITK customer.

Why can't we just leav it?

Bill

On Tue, May 27, 2008 at 1:24 PM, Brad King <brad.king at kitware.com> wrote:
> Niels Dekker wrote:
>> My proposed fixed version of itk::ExceptionObject
>> <www.itk.org/Bug/view.php?id=7094> no longer needs the protected helper
>> function UpdateWhat(), that was added by Brad King, a few years ago:
>> www.itk.org/cgi-bin/viewcvs.cgi/Code/Common/itkExceptionObject.h?root=Insight&view=log#rev1.31
>>
>>
>> ExceptionObject::UpdateWhat() is undocumented, but it looks like it's
>> only used within ExceptionObject itself. Theoretically it could also be
>> used by classes derived from ExceptionObject, but that seems highly
>> unlikely to me.  Can I savely remove it, when applying the proposed
>> patch?
>
> I have no problem with removing the method.
>
> -Brad
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> http://www.itk.org/mailman/listinfo/insight-developers
>