[Insight-developers] Problems with LightObject checkin

[Tom Vercauteren]

Thanks a lot Sean. The fix seems good to me.

I actually copied your code from itkTimeStamp but apparently missed an
include...

Thanks also for spotting the volatile keywords. I am not sure to
understand why we need it here but "man 3 OSAtomicIncrement64Barrier"
indeed prototypes the OSAtomicIncrement64Barrier with this keyword.

Tom


On Wed, May 14, 2008 at 5:33 PM, Sean McBride <sean at rogue-research.com> wrote:
> On 5/14/08 4:44 PM, Tom Vercauteren said:
>
>>For the Mac:
>>It's a bit weird, I just checked on a machine running Mac OS 10.5. It
>>compiles and runs fine. I have submitted an experimental build on
>>cdash:
>>http://www.cdash.org/CDash/buildSummary.php?buildid=76513
>>
>>If someone has an idea, pleas let me know.
>
> I can repro the compiler error.  The problem is all the crazy #if...
> there are so many variations.
>
> Basically, in the .h there is:
>
> #elif defined(__APPLE__) && (MAC_OS_X_VERSION_MIN_REQUIRED >= 1050)
>
> but MAC_OS_X_VERSION_MIN_REQUIRED is not defined so we get:
>
>  typedef _Atomic_word InternalReferenceCountType;
>
> yet in the .cxx we have:
>
> #include <AvailabilityMacros.h>
>
> which defines MAC_OS_X_VERSION_MIN_REQUIRED and so we fall into a
> different case.
>
> I've checked in a fix, please review:
>
> <http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Common/
> itkLightObject.h?root=Insight&r1=1.36&r2=1.37>
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com
> Mac Software Developer              Montréal, Québec, Canada
>
>