[Insight-developers] Re: itk's CMakeLists.txt and Mac compiler flags (BUG: 6267)

[Bill Lorensen]

Sean,

I realized (after looking at yesterday's and today's dashboard) that
although the new macro is working, the test for the flags was wrong.

I used:
itkCHECK_CXX_ACCEPTS_FLAGS("-foo" CXX_HAS_FOO_FLAG)

IF(${CXX_HAS_FOO_FLAG})
 SET(ITK_REQUIRED_CXX_FLAGS "${ITK_REQUIRED_CXX_FLAGS} -foo")
ENDIF(${CXX_HAS_FOO_FLAG})
rather than
IF(CXX_HAS_FOO_FLAG)
 SET(ITK_REQUIRED_CXX_FLAGS "${ITK_REQUIRED_CXX_FLAGS} -foo")
ENDIF(CXX_HAS_FOO_FLAG)

I've checked in the changes and things should be OK tomorrow.

Bill


On Wed, Feb 13, 2008 at 1:41 PM, Bill Lorensen <bill.lorensen at gmail.com>
wrote:

> Sean,
>
> Reopening is fine. I'm also learning how to effectively use Mantis.
>
> As for the bug, I was surprised how much effort it took to resolve. Partly
> because, CMake has macros that should do this properly. When I get some
> time, I'll post something to the CMake list.
> I noticed this problem a while back when I tried to check a flag for Sun
> C++. I took the easy way out:
>
> http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Numerics/FEM/CMakeLists.txt?root=Insight&r1=1.71&r2=1.72
> Then Sebastien had to fix it:
>
> http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Numerics/FEM/CMakeLists.txt?root=Insight&r1=1.73&r2=1.74
>
> Bill
>
>
> On Feb 13, 2008 1:31 PM, Sean McBride <sean at rogue-research.com> wrote:
>
> > On 2/13/08 1:27 PM, Bill Lorensen said:
> >
> > >If after your changes to CMakeLists.txt, everything looksOK, could you
> > close
> > >the bug? Also, I noticed that this bug references a similar bug in VTK.
> > You
> > >may want to post some of our experience to the VTK developer list.
> >
> > Thanks for your help with all this!  I am working on a patch for VTK.
> >
> > I've closed the bug.  (I only reopened it because it seems that is the
> > only way to add a comment to a closed bug.  Or have I missed something?)
> >
> > --
> > ____________________________________________________________
> > Sean McBride, B. Eng                 sean at rogue-research.com
> > Rogue Research                        www.rogue-research.com
> > Mac Software Developer              Montréal, Québec, Canada
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.itk.org/mailman/private/insight-developers/attachments/20080215/7c115bd4/attachment.htm