[Insight-developers] Testing philosophy question

[Blezek, Daniel J.]

Hi,

  I found a warning in itkConnectComponentsImageFilter when the output
type is signed.  There is a comparison on line 608 of the .txx file
between the backgroundvalue (Output type) an unsigned long int.  The
code is correct, but gcc warns of a comparison between signed and
unsigned.

  Now I realize that my label maps should be unsigned, which would fix
the warning.  Should the filter warn that the output type should be
unsigned? or should code be fixed to accommodate signed and unsigned
types?  I'm happy to do the fix and add a new test.

-dan

Daniel Blezek, PhD
Medical Imaging Informatics Innovation Center

P 127 or (77) 8 8886
T 507 538 8886
E blezek.daniel at mayo.edu

Mayo Clinic
200 First St. S.W.
Harwick SL-44
Rochester, MN 55905
mayoclinic.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20081223/0f3c4f33/attachment.htm>