[Insight-developers] ConvertPointToContinousIndex to ConvertPointToContinuousIndex

Tue Apr 15 15:21:34 EDT 2008

Karthik,

I agree that warnings should be spewed. I will add warnings to the
ArrowSpatialObject also.

The good news is, that we did introduce the Review directory. This
gives all of us developers a chance to check and change things before
we release an API.

Bill

On Tue, Apr 15, 2008 at 3:08 PM, Karthik Krishnan
<karthik.krishnan at kitware.com> wrote:
> We should at least spew out warnings when these methods are used, before calling
>  the right method.
>
>  I saw that the Get/SetLenght() methods in itk::ArrowSpatialObject do
>  not do that.
>
>  Perhaps it should. At least people will pay attention to warnings and clean up
>  their code, so if it is eventually deprecated in future, there will be very few
>  affected users.
>
>  --
>  karthik
>
>
>
>  On Tue, Apr 15, 2008 at 3:00 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>  > Stephen,
>  >
>  >  I agree with you. Both should be maintained. As I said, we screwed up,
>  >  not the user.
>  >
>  >  I'll make the change in cvs head and we can move it into the release soon.
>  >
>  >  Hans, I am not a fan of deprecation although we do seem to have some
>  >  policy in this area.
>  >
>  >  Bill
>  >
>  >
>  >
>  >  On Tue, Apr 15, 2008 at 2:54 PM, Hans Johnson <hans-johnson at uiowa.edu> wrote:
>  >  > All,
>  >  >
>  >  >  There must be some sort of deprecation process for these sorts of issues.
>  >  >  Backwards compatibility is great, but there needs to be some sort of
>  >  >  mechanism to eventually phase these errors.
>  >  >
>  >  >  I thought that items listed as deprecated only needed to be maintained for 2
>  >  >  two revisions after the change was made.
>  >  >
>  >  >  ======
>  >  >  Along similar lines, at some point we need to move beyond the requirement of
>  >  >  compilation under compilers that were readily available in 2000, but are now
>  >  >  unsupported.
>  >  >
>  >  >  Hans
>  >  >  --
>  >  >  Hans J. Johnson, Ph.D.
>  >  >  Hans-johnson at uiowa.edu
>  >  >
>  >  >  278 GH
>  >  >  The University of Iowa
>  >  >  Iowa City, IA 52241
>  >  >  (319) 353 8587
>  >  >
>  >  >
>  >  >  > From: Stephen Aylward <Stephen.Aylward at Kitware.com>
>  >  >  > Date: Tue, 15 Apr 2008 14:35:44 -0400
>  >  >  > To: Bill Lorensen <bill.lorensen at gmail.com>
>  >  >  > Cc: "Insight-developers (E-mail)" <insight-developers at itk.org>
>  >  >  > Subject: Re: [Insight-developers] ConvertPointToContinousIndex to
>  >  >  > ConvertPointToContinuousIndex
>  >  >
>  >  >
>  >  > >
>  >  >  > I think both spellings should be maintained.
>  >  >  >
>  >  >  > s
>  >  >  >
>  >  >  > On Tue, Apr 15, 2008 at 10:17 AM, Bill Lorensen <bill.lorensen at gmail.com>
>  >  >  > wrote:
>  >  >  >> Marius,
>  >  >  >>
>  >  >  >>  I made that change a couple of months ago. Since I am the author of
>  >  >  >>  the backward compatibility policy, I struggled with keeping the old
>  >  >  >>  spelling around. In the past, I have fixed spelling errors but left
>  >  >  >>  the old spelling as well. For example, in itkArrowSpatialObject, the
>  >  >  >>  method GetLenght() was retained when its name was corrected to
>  >  >  >>  GetLength().
>  >  >  >>
>  >  >  >>  Perhaps the old name should be retained as well. After all, we did
>  >  >  >>  release the software with the bad method name. It was the development
>  >  >  >>  team's fault, not your fault.
>  >  >  >>
>  >  >  >>  Bill
>  >  >  >>
>  >  >  >>
>  >  >  >>
>  >  >  >>  On Tue, Apr 15, 2008 at 9:58 AM, Marius Staring <marius at isi.uu.nl> wrote:
>  >  >  >>> Hi,
>  >  >  >>>
>  >  >  >>> The function
>  >  >  >>>
>  >  >  >>>     void ConvertPointToContinousIndex( const PointType & point,
>  >  >  >>> ContinuousIndexType & cindex ) const
>  >  >  >>>
>  >  >  >>> in itkImageFunction.h
>  >  >  >>>
>  >  >  >>> was renamed in itk 3.6 to ConvertPointToContinuousIndex, which is indeed
>  >  >  >>> proper English. However, this change broke my application. I could quickly
>  >  >  >>> fix it, but this seems to violate the backwards compatibility policy. Or
>  >  >  >>> not?
>  >  >  >>>
>  >  >  >>> Anyway, I just wanted to let you know.
>  >  >  >>>
>  >  >  >>> Regards,
>  >  >  >>>
>  >  >  >>> Marius Staring
>  >  >  >>>
>  >  >  >>>
>  >  >  >>> _______________________________________________
>  >  >  >>> Insight-developers mailing list
>  >  >  >>> Insight-developers at itk.org
>  >  >  >>> http://www.itk.org/mailman/listinfo/insight-developers
>  >  >  >>>
>  >  >  >>>
>  >  >  >>  _______________________________________________
>  >  >  >>  Insight-developers mailing list
>  >  >  >>  Insight-developers at itk.org
>  >  >  >>  http://www.itk.org/mailman/listinfo/insight-developers
>  >  >  >>
>  >  >  >
>  >  >  >
>  >  >  >
>  >  >  > --
>  >  >  > Stephen R. Aylward, Ph.D.
>  >  >  > Chief Medical Scientist
>  >  >  > Kitware, Inc. - Chapel Hill Office
>  >  >  > http://www.kitware.com
>  >  >  > (518) 371-3971 x300
>  >  >  > _______________________________________________
>  >  >  > Insight-developers mailing list
>  >  >  > Insight-developers at itk.org
>  >  >  > http://www.itk.org/mailman/listinfo/insight-developers
>  >  >
>  >  >
>  >  _______________________________________________
>  >  Insight-developers mailing list
>  >  Insight-developers at itk.org
>  >  http://www.itk.org/mailman/listinfo/insight-developers
>