[Insight-developers] Changes in ITKConfig.cmake

[Luis Ibanez]

Hi Gaetan,

Your recent changes:

http://public.kitware.com/cgi-bin/viewcvs.cgi/ITKConfig.cmake.in?root=Insight&r1=1.24&r2=1.25

broke the installation process of ITK:

See errors at:
http://public.kitware.com/CDash/viewBuildError.php?buildid=43566


Please compare the builds of zion.kitware  labeled:


Linux-g++-4.1-vs-Installed<http://public.kitware.com/CDash/buildSummary.php?buildid=43566>
between 2008-04-02 22:00:00 EDT (before your changes)

and  2008-04-03 22:00:00 EDT (after your changes)


We will review this with Brad on Monday and explore a way
of making sure that the following combinations work:


1) Build ITK and build a project against the build ITK
2) Install ITK and build a project against the installed ITK
3) Pack ITK, unpack it, and build a project against the unpacked ITK
4) Build an Insight Journal project versus the ITK in the IJ server

Please keep in mind that whenever we touch any of the variables
involved in "ITKConfig.cmake", we should test all the combinations
above, to make sure that they are still functional.

In my recent changes, I verified (1),(2), and (3), but missed to
verify (4).


   Thanks


          Luis


-------------------------------------------------------------------------------------------------
On Thu, Apr 3, 2008 at 11:28 AM, Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>
wrote:

>
> Le 3 avr. 08 à 17:13, Luis Ibanez a écrit :
>
> >
> > Hi Gaetan,
> >
> > Did you checked whether this affected the settings
> > when ITK is installed ?
> >
> > e.g. check that
> >
> >             "make install"
> >
> > still works after your changes ?
> >
> >
> Yes, and I have checked that ITK_INCLUDE_DIR was not used elsewhere in ITK
> and InsightApplications.
>
>
> > Also,
> > could you please elaborate on the details of why
> > ITK_INCLUDE_DIR was making the builds of the Insight
> > Journal fail.
> >
> >
> That's because of that code from the IJMacros.txt:
>
>      #most packages define a Package_INCLUDE_DIR variable, so we'll check
> for
>      #that first
>      IF(${Package}_INCLUDE_DIR)
>        INCLUDE(${${Package}_INCLUDE_DIR})
>        SET(Included TRUE)
>      ELSE(${Package}_INCLUDE_DIR)
>        #VTK and ITK prefer to define a Package_USE_FILE, so we need to
> look for
>        #that too
>        IF(${Package}_USE_FILE)
>          INCLUDE(${${Package}_USE_FILE})
>          SET(Included TRUE)
>        ENDIF(${Package}_USE_FILE)
>      ENDIF(${Package}_INCLUDE_DIR)
>
> cmake never enter in the second part because ITK_INCLUDE_DIR is defined,
> and so it doesn't include the ITK's use file.
>
> Gaëtan
>
>
>
>
> >
> >  Please let us know,
> >
> >
> >    Thanks
> >
> >
> >       Luis
> >
> >
> > ---------------------
> > Gaëtan Lehmann wrote:
> >
> > > Hi Luis,
> > > I've just commited a change in ITKConfig.cmake.in to fix the build of
> > >  the contributions to the Insight Journal.
> > > Defining ITK_INCLUDE_DIR was making them fail. I simply renamed it
> > >  ITK_MAIN_INCLUDE_DIR.
> > > You may want to review the changes though.
> > > Regards,
> > > Gaëtan
> > >
> >
> --
> Gaëtan Lehmann
> Biologie du Développement et de la Reproduction
> INRA de Jouy-en-Josas (France)
> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
> http://voxel.jouy.inra.fr  http://www.mandriva.org
> http://www.itk.org  http://www.clavier-dvorak.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20080405/905169d4/attachment.htm>