[Insight-developers] error in itkEigenAnalysis2DImageFilter

[Luis Ibanez]

Hi Tomash,

Thanks for pointing this out.

You are right, the line is unnecessary.

Its removal probably doesn't affect the performance a lot,
but, in any case, it is an unnecessary line.

It has now been removed:
http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkEigenAnalysis2DImageFilter.txx?root=Insight&sortby=date&r2=1.20&r1=1.19

Please let us know if you find any other problems
in the code.


    Thanks


      Luis


-------------------
Tomáš Kazmar wrote:
> Hi all,
> 
>   I think the first line of the following excerpt from ITK3.2.0
> itkEigenAnalysis2DImageFilter::GenerateData() is useless and it could
> slow down the computation (if it is not thrown away by compiler). If I am
> right it should be removed.
> 
>     outputIt3.Set( eigenVector );
> 
>     const VectorComponentType norm = eigenVector.GetNorm();
>     if( norm > 1e-30 ) 
>       {
>       outputIt3.Set( eigenVector / norm  );
>       }
>     else
>       {
>       outputIt3.Set( nullVector );
>       }
> 
> 
> Tomash
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> http://www.itk.org/mailman/listinfo/insight-developers
>