[Insight-developers] Re: Review Directory : Coding Style Problems

[Gaetan Lehmann]

Hi Luis,

Sorry for that, I just didn't thought I was doing something wrong.
I tried to fix some errors pointed by KWStyle, and I must say that's a  
painful task.
The worst in that, is the feeling that most of the fixes are useless, and  
only a minority of them have a real interest: the line length is the most  
frequent error, and most of the time, fixing that make the code more  
obfuscated.

The line length limit was useful some time ago, but is now quite useless.  
All the computers are able to display more than 80 characters, and all the  
compilers are able to read more than 80 characters. With my text editor,  
112 chars are displayed if I keep the navigation tree on the left of the  
window, and 147 without it.

For code clarity, and to avoid a boring and (most of the time) useless  
task to the developers, it would be nice if the line length limit can be  
removed, or at least increased by 20 or 30 characters.

Gaetan



On Mon, 22 Jan 2007 17:38:06 +0100, Luis Ibanez <luis.ibanez at kitware.com>  
wrote:

>
> Hi Gaetan,
>
> Your recent changes to the Code/Review directory
> are breaking the code style checks for several
> files.
>
> We are spending a large amount of time fixing
> coding style issues, and that time is wasted
> when other developers make changes without
> respecting the coding style.
>
>
> ---
>
>
> Before you commit changes in this directory
> you may want to run KWStyle as:
>
>
>    KWStyle -xml ITK.kws.xml  -v    filename
>
>
> in order to verify that the file "filename" is
> satisfying the required coding style.
>
>
> You can download KWStyle from :
>
> http://public.kitware.com/KWStyle/download.htm
>
>
> The ITK.kws.xml file is generated by CMake
> in the binary directory where you are building
> ITK.
>
> Note that you should enable
>
>            ITK_USE_KWSTYLE
>
> In your CMake configuration of ITK.
>
>
> Please let us know if you find any problem
> building or running KWStyle.
>
>
>
>    Thanks
>
>
>      Luis
>



-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr