[Insight-developers] Help to debug on LInux64 and Mac 10.5

[Sean McBride]

On 12/21/07 10:25 AM, Bill Lorensen said:

>I noticed that the "extra" stuff in 32 bits seems to be all zeroes. Not true
>in 64 bits.

I am still curious about what this stuff is...

>Anyway, I've made changes that restrict the hashing to the Point part of the
>object.
>
>I just checked in the code. Can you update and tell me if it works? I made
>changes in Code/Common, Code/Algorithms and Code/Review.

Tada!  Passes in both 32 and 64, key size now 12 bytes in both cases,
and the output is identical.

Although not crucial, this investigation uncovered a couple of 64-to-32
truncations, and I have attached a small patch for your review.  I think
it's quite safe, if you agree I/you can commit it.

Now how about the other 42 failing tests on our dashboard?  :)

Happy holidays!

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada
-------------- next part --------------
Index: Code/Algorithms/itkStructHashFunction.h
===================================================================
RCS file: /cvsroot/Insight/Insight/Code/Algorithms/itkStructHashFunction.h,v
retrieving revision 1.4
diff -r1.4 itkStructHashFunction.h
55c55
<   int len = sizeof( InputType );
---
>   size_t len = sizeof( InputType );
Index: Testing/Code/Review/itkAutomaticTopologyQuadEdgeMeshSourceTest.cxx
===================================================================
RCS file: /cvsroot/Insight/Insight/Testing/Code/Review/itkAutomaticTopologyQuadEdgeMeshSourceTest.cxx,v
retrieving revision 1.2
diff -r1.2 itkAutomaticTopologyQuadEdgeMeshSourceTest.cxx
83c83
<     for( IdentifierType i = 0; i < 8; i++ )
---
>     for( unsigned int i = 0; i < 8; i++ )
252c252
<   unsigned int i;
---
>   unsigned long i;
333c333
<   int numPoints = meshSource->GetOutput()->GetNumberOfPoints();
---
>   unsigned long numPoints = meshSource->GetOutput()->GetNumberOfPoints();
343c343
<   int numCells = meshSource->GetOutput()->GetNumberOfCells();
---
>   unsigned long numCells = meshSource->GetOutput()->GetNumberOfCells();