[Insight-developers] Re: Compile error
withITK_USE_ORIENTED_IMAGE_DIRECTION on
Luis Ibanez
luis.ibanez at kitware.com
Wed Dec 12 21:20:07 EST 2007
Hi Bill,
I apologize for taking too long to get to that issue.
Thanks for adding the temporary fix.
I guess we just need to agree in a new name for this method,
and then I will add it to the ImageBase class. I believe Jim
had some suggestions about a better name for the method.
Luis
-----------------------
Bill Lorensen wrote:
> Luis,
>
> To get around compile errors as more builds enable the optimized
> registration, I placed a dummy RotateArrayByDirectionCosines in the
> PhasedArray3D... code.
>
> Bill
>
> On Dec 7, 2007 11:42 AM, Bill Lorensen <bill.lorensen at gmail.com
> <mailto:bill.lorensen at gmail.com>> wrote:
>
> Luis,
>
> Since this API has never been released, we are free to change it. A
> positive result of the reiview process.
>
> Bill
> On Dec 7, 2007 11:20 AM, Stephen R. Aylward
> <Stephen.Aylward at kitware.com <mailto:Stephen.Aylward at kitware.com>>
> wrote:
>
> I also get the error that Bill is reporting.
>
> Your solution seems valid to me.
>
> Stephen
>
> =======================================
> Stephen R. Aylward, Ph.D.
> Chief Medical Scientist
> Kitware, Inc. - Chapel Hill Office
> http://www.kitware.com <http://www.kitware.com/>
> Phone: (518)371-3971 x300
>
>
> > -----Original Message-----
> > From:
> >
> insight-developers-bounces+stephen.aylward=kitware.com at itk.org
> <mailto:kitware.com at itk.org>
> >
> > [mailto:
> insight-developers-bounces+stephen.aylward=kitware.com
> <mailto:insight-developers-bounces+stephen.aylward=kitware.com>
> > @itk.org <http://itk.org/>] On Behalf Of Luis Ibanez
> > Sent: Friday, December 07, 2007 11:13 AM
> > To: Bill Lorensen
> > Cc: ITK; Matt Turek
> > Subject: [Insight-developers] Re: Compile error
> > withITK_USE_ORIENTED_IMAGE_DIRECTION on
> >
> >
> > Hi Bill,
> >
> > Interesting !
> >
> >
> > 1) I'm not sure why this is not showing up on my Linux build
> > where these two CMake variables are also ON: zion.kitware
> >
> >
> >
> > 2) The problem seems to arise from the fact that the method:
> >
> > RotateArrayByDirectionCosines
> >
> > is implemented at the level of Image and OrientedImage
> > while PhasedArray3DSpecialCoordinatesImage derives
> > directly from ImageBase.
> >
> >
> > It is the same problem for the methods:
> >
> > TransformPhysicalPointToIndex()
> > TransformIndexToPhysicalPoint()
> >
> >
> >
> > 3) Easy solution is to move the default implementation of this
> > method to ImageBase... but... the correct implementation
> > still must be added to the
> PhaseArray3DSpecialCoordinatesImage,
> > with the difficulty that the Direction depends on the point
> > in space. This means that the API of this method may have to
> > be modified to look like:
> >
> > RotateArrayByDirectionCosinesAtPoint( array, point );
> >
> >
> >
> >
> > Suggestions ?
> >
> >
> >
> > Luis
> >
> >
> >
> > ----------------------
> > Bill Lorensen wrote:
> > > Luis,
> > >
> > > If I have ITK_USE_ORIENTED_IMAGE_DIRECTION ON and the optimized
> > > registration on, I get the following compile error on Windows:
> > >
> > >
> > > ------ Build started: Project: itkBasicFiltersTests1,
> > Configuration:
> > > Release Win32 ------
> > >
> > > Compiling...
> > >
> > > itkResamplePhasedArray3DSpecialCoordinatesImageTest.cxx
> > >
> > >
> >
> c:\lorensen\Projects\Insight\Code\Review\itkOptBSplineInterpolateImage
> > > Function.txx(919)
> > > : error C2039: 'RotateArrayByDirectionCosines' : is not a
> member of
> > > 'itk::PhasedArray3DSpecialCoordinatesImage<TPixel>'
> > >
> > > with
> > >
> > > [
> > >
> > > TPixel=PixelType
> > >
> > > ]
> > >
> > >
> > c:\lorensen\Projects\Insight\Code\Common\itkImageHelper.h(143)
> > : while
> > > compiling class-template member function
> > >
> >
> 'itk::BSplineInterpolateImageFunction<TImageType,TCoordRep,TCoefficien
>
> > > tType>::CovariantVectorType
> > >
> >
> itk::BSplineInterpolateImageFunction<TImageType,TCoordRep,TCoefficient
> > > Type>::EvaluateDerivativeAtContinuousIndexInternal(const
> > >
> >
> itk::BSplineInterpolateImageFunction<TImageType,TCoordRep,TCoefficient
> > > Type>::ContinuousIndexType &,vnl_matrix<T> &,vnl_matrix<double>
> > > &,vnl_matrix<double> &) const'
> > >
> > > with
> > >
> > > [
> > >
> > >
> >
> TImageType=itk::ResampleImageFilter<InputImageType,ImageType,double>::
> > > InputImageType,
> > >
> > > TCoordRep=double,
> > >
> > > TCoefficientType=double,
> > >
> > > T=long
> > >
> > > ]
> > >
> > >
> >
> C:\lorensen\Projects\Insight\Code\Review\itkOptResampleImageFilter.h(1
> > > 24)
> > > : see reference to class template instantiation
> > >
> > 'itk::BSplineInterpolateImageFunction<TImageType,TCoordRep,TCo
> > efficientType>'
> > > being compiled
> > >
> > > with
> > >
> > > [
> > >
> > >
> >
> TImageType=itk::ResampleImageFilter<InputImageType,ImageType,double>::
> > > InputImageType,
> > >
> > > TCoordRep=double,
> > >
> > > TCoefficientType=double
> > >
> > > ]
> > >
> > >
> >
> \lorensen\Projects\Insight\Testing\Code\BasicFilters\itkResamplePhased
> > > Array3DSpecialCoordinatesImageTest.cxx (81)
> > > : see reference to class template instantiation
> > >
> > 'itk::ResampleImageFilter<TInputImage,TOutputImage,TInterpolat
> > orPrecisionType>'
> > > being compiled
> > >
> > > with
> > >
> > > [
> > >
> > > TInputImage=InputImageType,
> > >
> > > TOutputImage=ImageType,
> > >
> > > TInterpolatorPrecisionType=double
> > >
> > > ]
> > >
> > > Build log was saved at
> > >
> > "file://c:\lorensen\Projects\Insight-net\Testing\Code\BasicFil
> > ters\itkBasicFiltersTests1.dir\Release\BuildLog.htm"
> > >
> > > itkBasicFiltersTests1 - 1 error(s), 0 warning(s)
> > >
> > >
> > >
> > _______________________________________________
> > Insight-developers mailing list
> > Insight-developers at itk.org <mailto:Insight-developers at itk.org>
> > http://www.itk.org/mailman/listinfo/insight-developers
> <http://www.itk.org/mailman/listinfo/insight-developers>
>
>
>
More information about the Insight-developers
mailing list