[Insight-developers] Re: WrapITK : FlatStructuringElement

[Gaëtan Lehmann]

Le Thu, 28 Sep 2006 18:54:35 +0200, Luis Ibanez <luis.ibanez at kitware.com>  
a écrit:

>
> Hi Gaetan,
>
> Thanks for the clarification.
>
> The two files have been moved to the directory
>
>            Insight/Code/Review
>
> The compilation problems that we are seeing in
> Windows would have been caught if the files
> where put in Code/Review along with a test in
> Testing/Code/Review.
>
> Do you have a unit test for this class ?
>

Yes, there is  
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/kernelShape.cxx  
and its tests:

FOREACH(r 1 3 6 10 20 50)
   ADD_TEST(KernelBox2D-${r} kernelShape kernelShape-box-${r}.png ${r} 0)
   ADD_TEST(KernelBox2D-${r}-Compare ${IMAGE_COMPARE}  
kernelShape-box-${r}.png  
${CMAKE_SOURCE_DIR}/images/kernelShape-box-${r}.png)

   ADD_TEST(KernelBall2D-${r} kernelShape kernelShape-ball-${r}.png ${r} 1)
   ADD_TEST(KernelBall2D-${r}-Compare ${IMAGE_COMPARE}  
kernelShape-ball-${r}.png  
${CMAKE_SOURCE_DIR}/images/kernelShape-ball-${r}.png)
ENDFOREACH(r)

ADD_TEST(KernelFromImage2D kernelShape kernelShape-fromImage.png ${r}  
dummy 3 ${CMAKE_SOURCE_DIR}/images/StrelFromImage.png)
ADD_TEST(KernelFromImage2DCompare ${IMAGE_COMPARE}  
kernelShape-fromImage.png  ${CMAKE_SOURCE_DIR}/images/StrelFromImage.png)

and the images:

http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/StrelFromImage.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-ball-1.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-ball-3.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-ball-6.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-ball-10.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-ball-20.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-ball-50.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-box-1.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-box-3.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-box-6.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-box-10.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-box-20.png
http://voxel.jouy.inra.fr/darcs/contrib-itk/consolidatedMorphology/images/kernelShape-box-50.png

And WrapITK already perform some tests with that class.

>
> We should add it to Testing/Code/Review to
> make sure that the .h and .txx files get
> compiled in all the platforms.
>
>
> ---
>
> BTW just for the record: Visual Studio does
> not tolerate well when the variables that
> are controlling a for() loop are reused in
> subsequent loops. Even though the C++ standard
> specifies that the scope of the variable is
> limited to the body of the loop, the VC++
> compiler does not complies with it. There is
> however a flag that can force the compiler
> to do the right thing.
>

Thanks for the infos :-)

>
> Welcome to the beauty of multi-platform support   :-)
>
>
>
>
>
>    Luis
>
>
>
> -------------------------
> Gaetan Lehmann wrote:
>>  Hi Luis,
>>  The class is where it was in WrapITK before moving WrapITK to ITK.
>> http://voxel.jouy.inra.fr/darcsweb/darcsweb.cgi?r=WrapITK-unstable;a=tree
>>  It is already contributed to ITK - please see my mail   
>> "FlatStructuringElement review required ([Insight-developers] The  
>> Insight  Journal-New Submission)" sent 10 days ago, and feel free to  
>> add a review  :-)
>> http://insight-journal.org/InsightJournalManager/view_reviews.php?back=publications.php%3Fjournalid%3D6%26order%3Drating%26revision_display%3Dcombined&pubid=124  
>>   It should be moved to the Code/Review directory - I only thought to  
>> do  that once reviewed
>>  Regards,
>>  Gaetan
>>   On Thu, 28 Sep 2006 16:40:14 +0200, Luis Ibanez  
>> <luis.ibanez at kitware.com>  wrote:
>>
>>>
>>> Hi Gaëtan
>>>
>>> Why is that you committed the class:
>>>
>>>
>>>                 FlatStructuringElement
>>>
>>>
>>> in the directory
>>>
>>>
>>>              Insight/Wrapping/WrapITK
>>>
>>>                         ??
>>>
>>> Is this class intended to be contributed to ITK ?
>>>
>>>
>>> Why is that this class was not put in the Code/Review directory ?
>>>
>>>
>>> Please let us know,
>>>
>>>
>>>     Thanks
>>>
>>>
>>>        Luis
>>>
>>>
>>> ==========================
>>> Gaëtan Lehmann wrote:
>>>
>>>>  I have found another error with FlatStructuringElement, but really   
>>>> don't  know how to fix    
>>>> http://www.itk.org/Testing/Sites/dash12.kitware/Win32-vs70/20060927-0100-Nightly/BuildError.html   
>>>>   Thanks,
>>>>  Gaetan
>>>>
>>>>>
>>>>
>>>
>>
>
>



-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr