[Insight-developers] RE: netlib changes are breaking builds

[Lorensen, William E (GE, Research)]

I think it is OK to update the header tests once in a while. We can clean them up over the next few days.

Bill

-----Original Message-----
From: Luis Ibanez [mailto:luis.ibanez at kitware.com]
Sent: Tuesday, September 26, 2006 9:44 AM
To: Lorensen, William E (GE, Research)
Cc: ITK
Subject: Re: netlib changes are breaking builds



Hi Bill,

I see...

The #defines in the AlgorithmHeader are now redundant
with the #defines in itkFFTWCommon.h.

--

It seems that overall, it wasn't a good idea to run the
BuildHeaderTest.tcl script. I didn't realized that we had
to manually retouch the results.

Should I roll back the changes and only keep the modifications
of the Copyrights ?


   Luis



------------------------------------------
Lorensen, William E (GE, Research) wrote:
> Actually, I edited the Algorithms header test to fix the problem. Sometimes we need to hand-edit these generated files. For example, one of the windows compilers is getting an internal compiler error on COmmonHeaderTests. Sometimes a reordering of include's fixes the problem.
> 
> Bill
> 
> 
> -----Original Message-----
> From: Luis Ibanez [mailto:luis.ibanez at kitware.com]
> Sent: Tuesday, September 26, 2006 8:58 AM
> To: Lorensen, William E (GE, Research)
> Cc: ITK
> Subject: Re: netlib changes are breaking builds
> 
> 
> 
> Hi Bill,
> 
> We removed yesterday the last traces of itknetlib.
> That shouldn't be a problem anymore.
> 
> Today we have a red Dashboard due to a change I made yesterday.
> 
> I reran the BuildHeaderTest.tcl script in order to fix the
> copyright notices of the HeaderTest (that were appearing as
> copyrighted by the NLM).
> 
> This included the itkFFTWCommon.h file that recently was
> changed so that it was only included in builds that have
> USE_FFTWF or USE_FFTWD enabled.
> 
> Since the Header Tests blindly add all the headers, I just
> added back the #defines to itkFFTWCommon.h, so that, if it
> is included in the HeaderTest from a build that has USE_FFTWF
> and USE_FFTWD disable, it shouldn't cause any compilation
> problems.
> 
> 
> There may be other quirks to iron out today too....
> 
> 
> 
>      Luis
> 
> 
> ---------------------
> Bill Lorensen wrote:
> 
>>Luis,
>>
>>There are some builds failing after you netlib changes. For example:
>>
>>http://www.itk.org/Testing/Sites/crunch1.isi.nl/Linux64-g++-4.0.2/20060925-0100-Nightly/BuildError.html 
>>
>>http://www.itk.org/Testing/Sites/camelot.kitware/Linux-g++-2.95-WrapITK/20060925-0100-Nightly/BuildError.html 
>>
>>
>>
>>Bill
>>
>>
>>
> 
> 
> 
>