[Insight-developers] Re: Wrap ITK patch

[Gaëtan Lehmann]

Le Fri, 08 Sep 2006 21:53:35 +0200, Karthik Krishnan  
<Karthik.Krishnan at kitware.com> a écrit:

>
>
> Gaëtan Lehmann wrote:
>
>> Le Fri, 08 Sep 2006 19:44:43 +0200, Karthik Krishnan   
>> <Karthik.Krishnan at kitware.com> a écrit:
>>
>>> Gaetan:
>>> Thanks for the WrapITK stuff,
>>> Please review and apply the attached patch:
>>> With wrapping, we used to have the option that if CableSwig was  
>>> checked  out into  "Insight/Utilities/CableSwig" things would build  
>>> just fine.   ie CableSwig would be built and all the wrapping would  
>>> use the that  build of cableswig . There would be no need to have  
>>> CableSwig built  separately on your machine. This is done on some of  
>>> the dashboard  machines. (After all Brad wrote CableSwig as a part of  
>>> ITK)
>>
>>
>> I have applied the patch
>> Thank you :-)
>>
>> I think it would be much clean to have cmake code related to wrappers  
>> in  the Wrapping directory.
>> What do you think of detecting and building CableSwig even if the old  
>> and  the new wrapping systems are not found, and to move the cmake code  
>> related  to wrappers from Insight/CMakeLists.txt to  
>> Insight/Wrapping/CmakeLists.txt  ?
>
>
> I agree that it would clean up the top level CMakeLists.txt, but I would  
> vote against building CableSwig for someone who isn't doing wrapping..  
> (Unnecessary build)..

not really
If a user doesn't build the wrappers, he also doesn't put CableSwig in the  
Utilities directory, so it doesn't look like a major problem

>
> IMHO It would have been nice to have CableSwig as a subdir of Wrapping..  
> then you could do what you just said and build it only if the wrapping  
> systems are found ( only then would you subdir into it anyway... )
>
> Thanks
> -karthik
>
>>
>> Gaetan
>>



-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr