[Insight-developers] Review directory is now installed

[Gaëtan Lehmann]

Hi Luis,

Using Review is not the default, and already require to turn on an option.  
I don't think that's useful to add another option.

I have added a big warning when ITK_USE_REVIEW is used. It is displayed  
when running cmake, and when running make install (or equivalent). I hope  
there is no english mistake:

   "Warning: You have chosen to use the files in the Review directory. The  
Copyright of these files has not been cleared up, and the coding style and  
API of the classes in the Review directory may change drastically as it  
get code reviews from the developers. Please set ITK_USE_REVIEW to OFF if  
you don't want to use these files."

Is it enough ?

Thanks,

Gaetan

Le Wed, 11 Oct 2006 19:04:37 +0200, Luis Ibanez <luis.ibanez at kitware.com>  
a écrit:

>
> Hi Gaetan,
>
> Thanks for updating the CMakeLists.txt file.
>
> I wonder if we should consider having this installation to be
> optional.
>
> (e.g. have CMake ask the developer if the Review files should
>        be installed or not).
>
> The reasons is that the code in the Review directory is only in the
> process of being considered for inclusion in the toolkit.
>
> The Copyright of these files has not been cleared up, and the coding
> style and API of the classes in the Review directory may change
> drastically as it get code reviews from other developers.
>
>
> Classes in the Review directory are not guaranteed to remain in
> the toolkit either, so, user's in general should not rely on them,
> except for experimental purposes. In other words, these files are
> excluded from the backward compatibility policy of the toolkit.
>
> A Question to the user, or a Warning will probably be enough
> for making sure that the user is aware that the files in the
> Review directory may be very different in the next release,
> or may not even be there.
>
>
>
>    Thanks
>
>
>      Luis
>
>
>
> -------------------------
> Gaetan Lehmann wrote:
>>  Hi,
>>  The Reviews directory is not installed when ITK_USE_REVIEW is ON.
>> I think it should, and it's needed for the WrapITK's external projects,  
>> so  I have modified the CMakeLists.txt file to do that, but I'm not  
>> sure it  has not be done voluntarily like that.
>> If I shouldn't have changed that, please just revert my changes.
>>  Gaetan
>>
>
>



-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr