[Insight-developers] Backport ___isnan fix to ITK 2.0.1 release?

[Luis Ibanez]

Hi Zach,

It has been commited to the ITK 2.0 CVS tag.

So if you get the 2.0 release from CVS,
the isnan fix change will be there.

The change doesn't seem to be enought for
justifying to cut a patch release...


   Regards,


      Luis


---------------------
Zachary Pincus wrote:

> Excellent. Will these changes will propagate to the tarballs of 2.0  and 
> 2.0.1 on the ITK download page at some point?
> 
> Zach
> 
> 
> On Jul 14, 2005, at 6:48 AM, Brad King wrote:
> 
>> Zachary Pincus wrote:
>>
>>> I just tried (in the course of attempting to localize my TIFF bug)  
>>> to  compile the ITK 2.0.1 on a Mac I have access to that's running  
>>> OS X  10.3.9.
>>> This unfortunately failed because of the __isnan link problems  that  
>>> had been put to rest in the CVS tree last month. I  (and  perhaps  
>>> others) had thought that this problem was Tiger (10.4)  specific.  
>>> However, it in fact affects 10.3 versions too. Which  means that as 
>>> of  now, the latest ITK "bugfix" release fails to  build on all Macs 
>>> with  up-to-date operating systems (I can  confirm failure on 10.3.9 
>>> and  10.4.1), as far as I can tell!
>>> Would it be a good idea to "backport" the fix to the 2.0.1 release  
>>> so  that until the next point release, mac-using ITK-neophytes  won't 
>>> have  their first experience with the toolkit be a  mystifying linker 
>>> error?  Or alternately, is there a new 2.0.2  point release coming up 
>>> soon to  obviate the 2.0.1 release?
>>> Note that there've been three or four emails to the user list in  
>>> the  last month or two about this issue. If that many people have  
>>> had the  error and posted to the list, imagine how many have had  the 
>>> error and  given up?
>>> The fix is quite simple, as Brad who finally figured out the  issue  
>>> knows.
>>> In file:
>>> [INSIGHT_ROOT]/Utilities/vxl/core/vnl/vnl_math.cxx
>>> change line 62 from:
>>> # define isnan __isnan
>>> to
>>> # define isnan(x) __isnand((double)x)
>>>
>>
>> This change has been put on the ITK-2-0 branch.
>>
>> -Brad
>> _______________________________________________
>> Insight-developers mailing list
>> Insight-developers at itk.org
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
> 
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> http://www.itk.org/mailman/listinfo/insight-developers
> 
>