[Insight-developers] Dashboard status & CMake version

[Mathieu Malaterre]

Bill,

	The code Luis moved from VTK to Insight is extremely VTK oriented. All 
gdcm need is the uint64_t type. According to C99 this is provided in 
stdint.h. But it seems that on old system, I should use inttypes.h instead.

	I would suggest we give the following patch(*) a try before moving to 
cmake 2.0 (we could always later):

(*)
#ifdef CMAKE_HAVE_STDINT_H
    #include <stdint.h>
#else
#ifdef CMAKE_HAVE_INTTYPES_H
    // Old system only have this
    #include <inttypes.h>   // For uint8_t uint16_t and uint32_t
#endif
#endif
 
 

// Broken plateform do not respect C99 and do not provide those typedef
#if defined(_MSC_VER) || defined(__BORLANDC__)
typedef  signed char         int8_t;
typedef  signed short        int16_t;
typedef  signed int          int32_t;
typedef  signed __int64      int64_t;
typedef  unsigned char       uint8_t;
typedef  unsigned short      uint16_t;
typedef  unsigned int        uint32_t;
typedef  unsigned __int64    uint64_t;
#define UINT32_MAX    (4294967295U)
#endif


You need to update gdcm/CMakeLists.txt and gdcm/gdcmConfigure.in

I can send a proper patch if anyone is interested in giving it a try.
Mathieu


Bill Lorensen wrote:
> Luis,
> I thought we would only update Cmake when absolutely necessary. Maybe 
> now is the time.
> 
> I have several nightlies that still use cmake 1.8. These are all linux 
> or unix build I believe. I can update these to cmake 2.0. In the past, 
> cmake upgrades on my GE linux and unix systems have wreaked havoc with a 
> number of GE users, since they use my "production" cmake. The errors 
> they encounter are usually due to holes that have been plugged in a 
> cmake upgrade.
> 
> If you think it is absolutely necessary, then I'll try to update to 
> cmake2.0. Another problem is that I will be out of town for most of this 
> week.
> 
> Bill
> 
> At 11:58 AM 1/23/2005, Luis Ibanez wrote:
> 
>> Bill,
>>
>> Yeap, that seems to be the case.
>>
>> The complete story is that Mathieu is using a type "uint64" in
>> the encoding of the DICOM UIDs. This type is only available when
>> the compiler provides "long long" (which is a non-standard
>> extension), or actual 64bytes ints.
>>
>> In VTK a test is in place in order to let CMake find whether the
>> platform supports such types or not. I copied the tests from VTK
>> and set it up in ITK in order to conditionally compile that section
>> of code only when"long long" or true 64bytes ints are available.
>>
>>
>> However, the test requires some functionality available in
>> CMake post 1.8.
>>
>>
>>
>> Which raises up the question:
>>
>>
>>   What version of CMake are we requiring for ITK 1.10  ?
>>
>>
>>
>> I thought we were always requiring an ITK release to be
>> used with the latest release of CMake. (in this case 2.0.5).
>>
>>
>> Are we following that guideline for this release ?
>>
>>
>> (Maybe I'm missing a better way of dealing with the int64 type...)
>>
>>
>>     Luis
>>
>>
>>
>> ----------------------
>> Bill Lorensen wrote:
>>
>>> Luis,
>>> Looks like there should be a:
>>> INCLUDE (${CMAKE_ROOT}/Modules/CheckTypeSize.cmake)
>>> but I think this may cause us to require a cmake after 1.8. I'm not 
>>> sure.
>>> Bill
>>> At 09:01 AM 1/23/2005, Luis Ibanez wrote:
>>>
>>>> Bill,
>>>>
>>>> I'll look into the config problems on Terminus (Windows)
>>>> it seems that it has been running a CMake 1.9, that doesn't
>>>> support the recent check we added for int64.  I'll update
>>>> CMake in that machine.
>>>>
>>>>
>>>>
>>>>     Luis
>>>>
>>>>
>>>>
>>>> -----------------------
>>>> Bill Lorensen wrote:
>>>>
>>>>> Luis,
>>>>> I fixed gdcm problems on solaris.
>>>>> I fixed itkGDCMImageIO problem.
>>>>> Looks like config problems on Windows platforms. I'll have to leave 
>>>>> that one to you.
>>>>> Bill
>>>>>
>>>>> _______________________________________________
>>>>> Insight-developers mailing list
>>>>> Insight-developers at itk.org
>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Insight-developers mailing list
>>>> Insight-developers at itk.org
>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>
>>>
>>> _______________________________________________
>>> Insight-developers mailing list
>>> Insight-developers at itk.org
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>>
>>
>> _______________________________________________
>> Insight-developers mailing list
>> Insight-developers at itk.org
>> http://www.itk.org/mailman/listinfo/insight-developers
> 
> 
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> http://www.itk.org/mailman/listinfo/insight-developers
>