[Insight-developers] Unified CVS commit tags

[Andy Cedilnik]

Hi Bill,

The problem with FIX is that it is not clear if it is compile time fix
or run time fix.

The NEW and ENH is pretty much the same thing. NEW does not actually add
any more information.

			Andy

On Tue, 2004-10-05 at 16:25, Lorensen, William E (Research) wrote:
> I agree with Jim that FIX is better than BUG. NEW is also good. I sometimes
> use PORT for portability issues, but that is not that big a deal.
> 
> 
> -----Original Message-----
> From: Miller, James V (Research) [mailto:millerjv at crd.ge.com]
> Sent: Monday, October 04, 2004 11:10 AM
> To: 'Luis Ibanez'
> Cc: Insight Developers List
> Subject: RE: [Insight-developers] Unified CVS commit tags
> 
> 
> If BUG is what we already agreed upon, then most of my "fixes" have the 
> wrong comment line.  I almost always use "FIX:"
> 
> Should there be a "NEW: " tag to identify when something new is added 
> to the repository.  If usually just do something like "First checkin"
> 
> Jim
> 
> -----Original Message-----
> From: Luis Ibanez [mailto:luis.ibanez at kitware.com]
> Sent: Monday, October 04, 2004 10:46 AM
> To: Miller, James V (Research)
> Cc: Insight Developers List
> Subject: Re: [Insight-developers] Unified CVS commit tags
> 
> 
> 
> Hi Jim,
> 
> I personnaly agree with you in that "FIX" sounds
> more positive than "BUG"...
> 
> However, in the ITK Developers document, "BUG" is
> the entry that we already agreed on.
> 
>      Insight/Documentation/
>               InsightDevelopersStart.doc
>               InsightDevelopersStart.pdf
> 
> 
> In fact,
> the only suggested tag that is new for ITK is "COMP".
> 
> "COMP" reflects situations like the lack of "typename"
> which is not exactly a bug, but where, a modification
> of the code will make possible for it to compile in
> specific platforms. The same situation happens with the
> use of the StaticConstMacro that makes possible to
> compile for Borland and VC 6.0.
> 
> 
>     Luis
> 
> 
> ----------------------------------
> Miller, James V (Research) wrote:
> 
> > I prefer FIX: rather than BUG:
> > 
> > I don't like commiting bugs.  But I do like commiting fixes.
> > 
> > COMP feels a little weird to me, but I can probably adapt.
> > 
> > 
> > 
> > -----Original Message-----
> > From: Luis Ibanez [mailto:luis.ibanez at kitware.com]
> > Sent: Monday, October 04, 2004 1:31 AM
> > To: Insight Developers List
> > Subject: [Insight-developers] Unified CVS commit tags
> > 
> > 
> > 
> > We are considering unifying CVS commit tags among several projects
> > (ITK, VTK, CMake, and ParaView) and we came up with the following list:
> > 
> > 
> >   BUG:  a change made to fix a runtime issue (crash or incorrect results)
> > 
> >   COMP: a fix for a compilation issue, error or warning
> > 
> >   ENH: new functionality added to the project
> > 
> >   PERF: performance improvement
> > 
> >   STYLE: a change that doesn't impact the logic or execution of the code
> > 
> > 
> > This list is not too far from what we have been using up to this point.
> > 
> > Does anybody have any objection with adapting the cvs
> > commit convention in ITK ?
> > 
> > 
> >     Thanks
> > 
> > 
> >        Luis
> > 
> > 
> > 
> > 
> > _______________________________________________
> > Insight-developers mailing list
> > Insight-developers at itk.org
> > http://www.itk.org/mailman/listinfo/insight-developers
> > _______________________________________________
> > Insight-developers mailing list
> > Insight-developers at itk.org
> > http://www.itk.org/mailman/listinfo/insight-developers
> > 
> > 
> 
> 
> 
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> http://www.itk.org/mailman/listinfo/insight-developers
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> http://www.itk.org/mailman/listinfo/insight-developers
-- 
				Andy Cedilnik
				Kitware Inc.