[Insight-developers] correction

[Luis Ibanez]

Hi Samson,

Thanks for posting the corrections.

This issue was entered as Bug # 519.

The files and classes were renamed according
to your indications.

The content of the algorithm was not updated
yet from your files. Since this is a separate
issue.

Once we verify that the renaming passed
fine in the dashboard we will update the
content of the algorithm from the  files
in your web site.


Regards,


   Luis



BTW
your attachement was expanded as
text in your image, so we will use
your web link.


----------------------
Samson Timoner wrote:

> Content-Type: multipart/mixed;
> 	boundary="++----------20040113203926-074758809----------++"
> 
> This is a multi-part message in MIME format.
> --++----------20040113203926-074758809----------++
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
> 
> 
> When I submitted itkKLCompareHistogramImageToImageMetric, its name was
> changed to itkKullbackLieblerCompareHistogramImageToImageMetric. Alas,
> "Liebler" is a mis-spelling of "Leibler". I noticed this last week,
> and we should probably fix it before the next release. All the changes
> are in files that are attached. I submitted an experimental build
> from horus0.ai.mit.edu with the new files.
> 
> The following files should be removed from CVS:
> Code/Algorithms/itkKullbackLieblerCompareHistogramImageToImageMetric.h
> Code/Algorithms/itkKullbackLieblerCompareHistogramImageToImageMetric.txx
> Testing/Code/Algorithms/itkKullbackLieblerCompareHistogramImageToImageMetricTes
> t.cxx
> 
> The following files should be added to CVS:
> Code/Algorithms/itkKullbackLeiblerCompareHistogramImageToImageMetric.h
> Code/Algorithms/itkKullbackLeiblerCompareHistogramImageToImageMetric.txx
> Testing/Code/Algorithms/itkKullbackLeiblerCompareHistogramImageToImageMetricTes
> t.cxx
> 
> The following files should be changed, and are attached:
> Testing/Code/Algorithms/CMakeLists.txt
> Testing/Code/Algorithms/itkAlgorithmsHeaderTest.cxx
> Testing/Code/Algorithms/itkAlgorithmsTests2.cxx
> Testing/Code/Algorithms/itkCompareHistogramImageToImageMetricTest.cxx
> 
> Note that I also made the following changes:
>  1) I added some comments to itkKullbackLeiblerCompareHistogramImageToImageMetr
> ic.
>  2) While my implementation of the algorithm was OK, it in fact did not
>     correspond exactly to the paper I referenced. I therefore changed
>     the code to make it do so. This changed 2 lines of code in  
>     itkKullbackLeiblerCompareHistogramImageToImageMetric.txx
>  3) I changed itkKullbackLeiblerCompareHistogramImageToImageMetricTest.cxx
>     so that it would have a minimum at the appropriate location using
>     the changed algorithm.
> 
>  I'm sorry to have caused problems,
> 
> -- Samson
> 
> P.S. If  you do not like attachments, I put all the files in:
>     http://www.ai.mit.edu/people/samson/upload/itk/
> 
> --++----------20040113203926-074758809----------++
> Content-Type: application/x-gunzip; name="submit.tar.gz"
> Content-Transfer-Encoding: base64
> 
> H4sICGiVBEAAA3N1Ym1pdC50YXIA7F19c9s20s/f+hS4tHMjp471YjtOnbQzsl5sTSTbI8lxO70b