[Insight-developers] += operator for itk::Offset

[Mark Foskey]

OK, I am checking in my changes.

I also have some other questions about Offset, Index, and Size.

First of all, does the set of methods provided by each follow in a 
natural way from their intended uses?  I see that you can increment an 
Offset by a Size, but you can't increment a Size by an Offset, yet I 
can imagine wanting to do both.  You can componentwise multiply two 
Sizes, but not two Offsets.  The question comes to mind of whether we 
really should have two different classes.  It certainly makes sense 
conceptually to represent a size as the offset from the origin to the 
diagonally opposite corner.

The relationship beween Offsets and Indexes is a little clearer, 
essentially that between vectors and points in affine geometry.

Also, I'm a little unclear on assigning to these kinds of items.  In 
the main comments for Index, there is the following:

  * The following syntax for assigning an index is allowed/suggested:
  *
  *    Index<3> index = {{5, 2, 7}};
  *
  * The double braces {{ and }} are needed to prevent a compiler warning
  * about a partly bracketed initializer.

However, in the comment for m_Index, we have the following:

    * The following syntax for assigning an index is allowed/suggested:
    *    Index<3> index = {5, 2, 7}; */

There is a similar pair of comments in itkSize.h, only in the opposite 
locations.  Is the one with nested sets of braces correct?

Luis Ibanez wrote:
> 
> Mark,
> 
> The repository have been tagged and branched
> for the release 1.2
> 
> Please go ahead and check in your changes.
> 
> 
>   Luis
> 
> 
> Disclaimer:
> 
>   note that I didn't say anything
>   about breaking the dashboard     :-)
> 
> ---------------------------
> 
> Mark Foskey wrote:
> 
>> OK.  Will do.
>>
>> What's the status on release 1.2?  Is it OK to break the dashboard 
>> now? :-)
>>
> 
> 
> _______________________________________________
> Insight-developers mailing list
> Insight-developers@public.kitware.com
> http://public.kitware.com/mailman/listinfo/insight-developers


-- 
Mark Foskey    (919) 843-5436  Computer-Aided Diagnosis and Display Lab
mark_foskey@unc.edu            Department of Radiology, CB 7515, UNC
http://www.cs.unc.edu/~foskey  Chapel Hill, NC  27599-7515