[Insight-developers] MedialNodeCorrespondencesTest, Intel C++ fixed

Miller, James V (Research) millerjv at crd . ge . com
Thu, 14 Aug 2003 13:04:50 -0400


This message is in MIME format. Since your mail reader does not understand
this format, some or all of this message may not be legible.

------_=_NextPart_001_01C36286.2BFC89D4
Content-Type: text/plain;
	charset="iso-8859-1"

Bill just fixed the MedialNodeCorrespondenceTest that was failing on the
Intel C++ compiler.  
 
BloxCoreAtomImage was passing the pixel eigenvectors to the
EllipsoidI*E*SpatialFunction.  The eigenvectors in the image were stored as
vnl_matrix_fixed and the Ellipsiod*SpatialFunction was accepting just a
vnl_matrix.  
 
It looks like the vnl_matrix_fixed and vnl_matrix classes are no longer
related via inheritence.  Instead, there are some converter routines (
mat_fixed.as_ref() returns a vnl_matrix).  
 
The Intel compiler builds were crashing on the deallocation of a vnl_matrix.
Bill changed the code in Ellipsoid*SpatialFunction to take a reference to a
vnl_matrix_fixed instead of taking a vnl_matrix by value.  This clears up
the problem on the Intel compiler.  I am guessing the other systems are
relying on some other type conversion operators that may be flawed on the
Intel compiler.
 
Two things to look out for:
 
1. vnl_matrix and vnl_matrix_fixed mismatches.
2. function that take matrix types by value as opposed to by reference. 
 
Jill
 

Jim Miller 
_____________________________________
Visualization & Computer Vision
GE Research
Bldg. KW, Room C218B
P.O. Box 8, Schenectady NY 12301

millerjv at research . ge . com <mailto:millerjv at research . ge . com> 

james . miller at research . ge . com
(518) 387-4005, Dial Comm: 8*833-4005, 
Cell: (518) 505-7065, Fax: (518) 387-6981 

 

------_=_NextPart_001_01C36286.2BFC89D4
Content-Type: text/html;
	charset="iso-8859-1"

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">


<META content="MSHTML 6.00.2800.1141" name=GENERATOR></HEAD>
<BODY>
<DIV><SPAN class=701494516-14082003><FONT size=2>Bill just fixed the 
MedialNodeCorrespondenceTest that was failing on the Intel C++ compiler.&nbsp; 
</FONT></SPAN></DIV>
<DIV><SPAN class=701494516-14082003><FONT size=2></FONT></SPAN>&nbsp;</DIV>
<DIV><SPAN class=701494516-14082003><FONT size=2>BloxCoreAtomImage was passing 
the pixel eigenvectors to the EllipsoidI*E*SpatialFunction.&nbsp; The 
eigenvectors in the image&nbsp;were stored as vnl_matrix_fixed and the 
Ellipsiod*SpatialFunction was&nbsp;accepting&nbsp;just 
a&nbsp;vnl_matrix.&nbsp;&nbsp;</FONT></SPAN></DIV>
<DIV><SPAN class=701494516-14082003></SPAN>&nbsp;</DIV>
<DIV><SPAN class=701494516-14082003><FONT size=2>It looks like the 
vnl_matrix_fixed and vnl_matrix classes are no longer related via 
inheritence.&nbsp; Instead, there are&nbsp;some converter routines ( 
mat_fixed.as_ref() returns a vnl_matrix).&nbsp;&nbsp;</FONT></SPAN></DIV>
<DIV><SPAN class=701494516-14082003></SPAN>&nbsp;</DIV>
<DIV><SPAN class=701494516-14082003><FONT size=2>The&nbsp;Intel compiler builds 
were crashing on the deallocation of a vnl_matrix.&nbsp; Bill changed the code 
in Ellipsoid*SpatialFunction to take a&nbsp;reference to a vnl_matrix_fixed 
instead of taking a vnl_matrix by value.&nbsp; This clears up the problem on the 
Intel compiler.&nbsp; I am guessing the other&nbsp;systems are relying on some 
other type conversion operators that may be flawed on the Intel 
compiler.</FONT></SPAN></DIV>
<DIV><SPAN class=701494516-14082003></SPAN>&nbsp;</DIV>
<DIV><SPAN class=701494516-14082003><FONT size=2>Two things to look out 
for:</FONT></SPAN></DIV>
<DIV><SPAN class=701494516-14082003></SPAN>&nbsp;</DIV>
<DIV><SPAN class=701494516-14082003><FONT size=2>1. vnl_matrix and 
vnl_matrix_fixed mismatches.</FONT></SPAN></DIV>
<DIV><SPAN class=701494516-14082003><FONT size=2>2.&nbsp;function that take 
matrix types by value as opposed to by reference.</FONT>&nbsp;</SPAN></DIV>
<DIV><SPAN class=701494516-14082003><FONT size=2></FONT></SPAN>&nbsp;</DIV>
<DIV><SPAN class=701494516-14082003><FONT size=2>Jill</FONT></SPAN></DIV>
<DIV><FONT size=2></FONT>&nbsp;</DIV>
<DIV>
<P style="MARGIN: 0in 0in 0pt"><B><SPAN 
style="COLOR: navy; FONT-FAMILY: 'Comic Sans MS'">Jim Miller</SPAN></B> 
<BR><B><I><SPAN 
style="FONT-SIZE: 10pt; COLOR: red; FONT-FAMILY: Arial">_____________________________________</SPAN></I></B><BR><EM><SPAN 
style="FONT-SIZE: 7.5pt; COLOR: black; FONT-FAMILY: Arial">Visualization &amp; 
Computer Vision</SPAN></EM><I><SPAN 
style="FONT-SIZE: 7.5pt; COLOR: black; FONT-FAMILY: Arial"><BR><EM>GE 
Research</EM><BR><EM>Bldg. KW, Room C218B</EM><BR><EM>P.O. Box 8, Schenectady NY 
12301</EM><BR><BR></SPAN></I><EM><U><SPAN 
style="FONT-SIZE: 7.5pt; COLOR: blue"><A 
href="mailto:millerjv at research . ge . com">millerjv at research . ge . com</A></SPAN></U></EM></P>
<P style="MARGIN: 0in 0in 0pt"><EM><U><SPAN 
style="FONT-SIZE: 7.5pt; COLOR: blue">james . miller at research . ge . com</SPAN></U></EM><BR><I><SPAN 
style="FONT-SIZE: 7.5pt; COLOR: black; FONT-FAMILY: Arial">(518) 387-4005, Dial 
Comm: 8*833-4005, </SPAN></I><BR><I><SPAN 
style="FONT-SIZE: 7.5pt; COLOR: black; FONT-FAMILY: Arial">Cell: (518) 505-7065, 
Fax: (518) 387-6981</SPAN></I> </P></DIV>
<DIV>&nbsp;</DIV></BODY></HTML>

------_=_NextPart_001_01C36286.2BFC89D4--