[Insight-developers] STEP 1: Code coverage push

Robert Tamburo rjtst21+ at pitt . edu
Wed, 6 Aug 2003 23:33:11 -0400


I am looking at fixing (RED):
./耶ode/耑asicFilters/虹tkBloxBoundaryPointImageToBloxBoundaryProfileImageFi
lter.txx
./耶ode/耑asicFilters/虹tkBloxBoundaryProfileImageToBloxCoreAtomImageFilter.
txx
./耶ode/耶ommon/虹tkBloxBoundaryProfileItem.txx

Also, we (Pitt/CMU) would like to remove ./耶ode/背O/虹tkVOLImageIO.cxx from
ITK (I'm not exactly sure how to do this). We are no longer contributing
Volumetrics RT3D Ultrasound data. Instead we have a no-cost extension to
contribute the new RT3D Ultrasound data from Phillips.

Just to clarify 0.00% is ok if it's GREEN????

-Rob

----- Original Message ----- 
From: "Luis Ibanez" <luis . ibanez at kitware . com>
To: "C. Aaron Cois" <cacst11 at pitt . edu>
Cc: "Insight Developers List" <insight-developers at public . kitware . com>
Sent: Wednesday, August 06, 2003 6:36 PM
Subject: Re: [Insight-developers] STEP 1: Code coverage push


>
> Hi Aaron,
>
> Sorry for the explosive surprise,
>
> (Beware that this is just "Step 1" of the
> release process  :-/ )
>
> ---
>
> Thanks for looking into the coverage list.
>
> Please note that the critical files are the
> ones marked in RED in the following report
>
http://www . itk . org/Testing/Sites/esopus . crd/SunOS-5 . 7-c++/20030806-0500-Nightly/CoverageByStatus . html
>
>
> The file itkBinaryMedialNodeMetric.h is ok (green)
> but the  itkBinaryMedialNodeMetric.txx is quite red with 0%
> coverage = 80 lines of executable code untested.
>
http://www . itk . org/Testing/Sites/esopus . crd/SunOS-5 . 7-c++/Coverage/__Code_Algorithms_itkBinaryMedialNodeMetric_txx . html
>
> Note that for templated classes, the "####" also
> means "NEVER BEING COMPILED". Just for the record, we have
> found surprises like the fact that the Set()/Get() method
> in the Reverse Iterator have never been compiled,... and
> of course... they were broken.
>
> The file
> 虹tkMedialNodePairCorrespondenceProcess.h is ok (yellow)
>
> but
> -itkMedialNodePairCorrespondenceProcess.txx is RED with
> 0% coverage and 220 of noncovered executable code.
>
>
> itkMedialNodeTripletCorrespondenceProcess.txx has 0%
> and 162 lines of uncovered code.
>
> Note that it is not enough to instantiate the classes.
> The test must exercise every single method of the class,
> since otherwise the method don't even get compiled.
>
>
> itkCorrespondenceDataStructure.h and .txx are yellow and green.
> itkCorrespondingList.h and .txx are ok (green)
> itkCorrespondingMedialNodeClique.h and .txx are ok (green)
> itkNodeList.h and .txx are ok (green)
> itkSecondaryNodeList.h and .txx are ok (green)
>
>
>
> Please increase the coverage for the classes that are
> listed in red.
>
>
>
> Thanks a lot for helping in this process.
>
>
>
>    Luis
>
>
>
>
> ------------------------
> C. Aaron Cois wrote:
>  > Hi Luis,
>  >
>  >    Sorry this is a few days late, but i just got back into town half an
>  > hour ago (no internet access for 3 days, and your life explodes ;)  )
>  >
>  > Anyway, i wanted to confirm that the following classes are all tested
in
>  > the file itkMedialNodeCorrespondenceTest.cxx:
>  >
>  > ./耶ode/耍lgorithms/虹tkBinaryMedialNodeMetric.h
>  > ./耶ode/耍lgorithms/虹tkBinaryMedialNodeMetric.txx
>  > ./耶ode/耍lgorithms/虹tkMedialNodePairCorrespondenceProcess.h
>  > ./耶ode/耍lgorithms/虹tkMedialNodePairCorrespondenceProcess.txx
>  > ./耶ode/耍lgorithms/虹tkMedialNodeTripletCorrespondenceProcess.h
>  > ./耶ode/耍lgorithms/虹tkMedialNodeTripletCorrespondenceProcess.txx
>  > ./耶ode/耶ommon/虹tkCorrespondenceDataStructure.h
>  > ./耶ode/耶ommon/虹tkCorrespondenceDataStructure.txx
>  > ./耶ode/耶ommon/虹tkCorrespondingList.h
>  > ./耶ode/耶ommon/虹tkCorrespondingList.txx
>  > ./耶ode/耶ommon/虹tkCorrespondingMedialNodeClique.h
>  > ./耶ode/耶ommon/虹tkCorrespondingMedialNodeClique.txx
>  > ./耶ode/耶ommon/虹tkNodeList.txx
>  > ./耶ode/耶ommon/虹tkSecondaryNodeList.h
>  > ./耶ode/耶ommon/虹tkSecondaryNodeList.t
>  >
>  > They are all dependent on each other, and thus are tested together in
>  > the same test.
>  >
>  >    -Aaron Cois
>  >
>  > Luis Ibanez wrote:
>  >
>  >>
>  >> The files/classes in the list below will be removed
>  >> from the Insight CVS repository on
>  >>
>  >>            Friday August 8  9:00 EST
>  >>
>  >> Reason for removal:
>  >>
>  >>              Code with 0% coverage
>  >>
>  >> Philosopical principle:
>  >>
>  >>      "If it is not tested, it is broken"
>  >>
>  >> If you have any professional or emotional attachements
>  >> to any of the files in this list and would like to
>  >> prevent its removal from the repository, please add
>  >> a test for this code in the Insight/Testing directory.
>  >>
>  >> New testing must compile. CVS write access will be
>  >> removed for anyone commiting non-compiling tests.
>  >> The reason being that a non-compiling test prevents
>  >> at least 100 other tests from running.
>  >>
>  >> No files should be added to Insigth/Code under the
>  >> pretext of supporting testing. Code freezing is in
>  >> effect on the Insight/Code directory.
>  >>
>  >> Abtract classes must be tested by instantiating one
>  >> of their concrete derived classes and exercising on
>  >> them the functionalities provided by the abtract class.
>  >>
>  >> -------------- THE LIST -----------------------------
>  >>
>  >> ./耶ode/耍lgorithms/虹tkImageShapeModelEstimatorBase.h
>  >> ./耶ode/耍lgorithms/虹tkBinaryMedialNodeMetric.h
>  >> ./耶ode/耍lgorithms/虹tkBinaryMedialNodeMetric.txx
>  >> ./耶ode/耍lgorithms/虹tkMedialNodePairCorrespondenceProcess.h
>  >> ./耶ode/耍lgorithms/虹tkMedialNodePairCorrespondenceProcess.txx
>  >> ./耶ode/耍lgorithms/虹tkMedialNodeTripletCorrespondenceProcess.h
>  >> ./耶ode/耍lgorithms/虹tkMedialNodeTripletCorrespondenceProcess.txx
>  >>
>
./耶ode/耍lgorithms/虹tkNarrowBandThresholdSegmentationLevelSetImageFilter.h
>
>  >>
>  >>
>
./耶ode/耍lgorithms/虹tkNarrowBandThresholdSegmentationLevelSetImageFilter.t
xx
>
>  >>
>  >> ./耶ode/耑asicFilters/虹tkImageToMeshFilter.h
>  >> ./耶ode/耑asicFilters/虹tkGrayscaleFunctionDilateImageFilter.txx
>  >> ./耶ode/耑asicFilters/虹tkGrayscaleFunctionErodeImageFilter.txx
>  >> ./耶ode/耑asicFilters/虹tkExtractOrthogonalSwath2DImageFilter.txx
>  >> ./耶ode/耶ommon/虹tkBloxBoundaryProfileItem.h
>  >> ./耶ode/耶ommon/虹tkBloxBoundaryProfileItem.txx
>  >> ./耶ode/耶ommon/虹tkBloxBoundaryProfilePixel.h
>  >> ./耶ode/耶ommon/虹tkBloxBoundaryProfilePixel.txx
>  >> ./耶ode/耶ommon/虹tkConceptChecking.h
>  >> ./耶ode/耶ommon/虹tkConditionalConstIterator.h
>  >> ./耶ode/耶ommon/虹tkDecisionRuleBase.h
>  >> ./耶ode/耶ommon/虹tkDynamicLoader.cxx
>  >> ./耶ode/耶ommon/虹tkEventObject.cxx
>  >> ./耶ode/耶ommon/虹tkMetaDataObjectBase.h
>  >> ./耶ode/耶ommon/虹tkInPlaceImageFilter.h
>  >> ./耶ode/耶ommon/虹tkImageRegionReverseIterator.h
>  >> ./耶ode/耶ommon/虹tkInteriorExteriorSpatialFunction.h
>  >> ./耶ode/耶ommon/虹tkSmartPointerForwardReference.h
>  >> ./耶ode/耶ommon/虹tkSpatialFunction.h
>  >> ./耶ode/耶ommon/虹tkThinPlateR2LogRSplineKernelTransform.txx
>  >> ./耶ode/耶ommon/虹tkVolumeSplineKernelTransform.txx
>  >> ./耶ode/耶ommon/虹tkFiniteDifferenceSparseImageFunction.txx
>  >> ./耶ode/耶ommon/虹tkCorrespondenceDataStructure.h
>  >> ./耶ode/耶ommon/虹tkCorrespondenceDataStructure.txx
>  >> ./耶ode/耶ommon/虹tkCorrespondingList.h
>  >> ./耶ode/耶ommon/虹tkCorrespondingList.txx
>  >> ./耶ode/耶ommon/虹tkCorrespondingMedialNodeClique.h
>  >> ./耶ode/耶ommon/虹tkCorrespondingMedialNodeClique.txx
>  >> ./耶ode/耶ommon/虹tkNodeList.txx
>  >> ./耶ode/耶ommon/虹tkSecondaryNodeList.h
>  >> ./耶ode/耶ommon/虹tkSecondaryNodeList.txx
>  >> ./耶ode/背O/虹tkVOLImageIOFactory.cxx
>  >> ./耶ode/背O/虹tkVOLImageIOFactory.h
>  >> ./耶ode/背O/虹tkIOCommon.cxx
>  >> ./耶ode/背O/虹tkIPLCommonImageIO.h
>  >> ./耶ode/背O/虹tkRegularExpressionSeriesFileNames.cxx
>  >> ./耶ode/背O/虹tkRegularExpressionSeriesFileNames.h
>  >> ./耶ode/胤umerics/虹tkSingleValuedNonLinearVnlOptimizer.h
>  >> ./苣tilities/虺wsys/苧egularExpression.cxx
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMElement2DC0QuadraticTriangular.cxx
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMElement2DC0QuadraticTriangular.h
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMElement2DMembrane.h
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMElement2DMembrane.txx
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMElement3DMembrane.h
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMElement3DMembrane.txx
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMException.cxx
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMException.h
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMGenerateMesh.cxx
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMImageMetricLoad.h
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMImageMetricLoad.txx
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMImageMetricLoadImplementation.h
>  >>
./耶ode/胤umerics/胚EM/虹tkFEMLoadImplementationGenericLandmarkLoad.cxx
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMLoadImplementationGenericLandmarkLoad.h
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMSolverCrankNicolson.cxx
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMSolverCrankNicolson.h
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMElement2DStrain.h
>  >> ./耶ode/胤umerics/胚EM/虹tkFEMElement2DStrain.txx
>  >> ./耶ode/胤umerics/范tatistics/虹tkDecisionRuleBase.h
>  >> ./耶ode/耍lgorithms/虹tkBioGeneNetwork.h
>  >> ./耶ode/耍lgorithms/虹tkImageMomentsCalculator.h
>  >> ./耶ode/耍lgorithms/虹tkMeanSquaresPointSetToImageMetric.h
>  >> ./耶ode/耍lgorithms/虹tkMeanSquaresPointSetToImageMetric.txx
>  >> ./耶ode/耍lgorithms/虹tkMultiResolutionImagePyramid.txx
>  >> ./耶ode/耍lgorithms/虹tkRayCastInterpolateImageFunction.txx
>  >> ./耶ode/耍lgorithms/虹tkRegistrationMethod.h
>  >> ./耶ode/耍lgorithms/虹tkRegistrationMethod.txx
>  >> ./耶ode/耍lgorithms/虹tkVoronoiSegmentationRGBImageFilter.h
>  >> ./耶ode/耍lgorithms/虹tkVoronoiSegmentationRGBImageFilter.txx
>  >> ./耶ode/耍lgorithms/虹tkRayCastInterpolateImageFunction.h
>  >> ./耶ode/耍lgorithms/虹tkUnsharpMaskLevelSetImageFilter.h
>  >>
>
./耶ode/耍lgorithms/虹tkMeanReciprocalSquareDifferencePointSetToImageMetric.
h
>
>  >>
>  >>
>
./耶ode/耍lgorithms/虹tkMeanReciprocalSquareDifferencePointSetToImageMetric.
txx
>
>  >>
>  >> ./耶ode/耍lgorithms/虹tkAnisotropicFourthOrderLevelSetImageFilter.h
>  >> ./耶ode/耍lgorithms/虹tkAnisotropicFourthOrderLevelSetImageFilter.txx
>  >> ./耶ode/耍lgorithms/虹tkIsotropicFourthOrderLevelSetImageFilter.h
>  >> ./耶ode/耍lgorithms/虹tkIsotropicFourthOrderLevelSetImageFilter.txx
>  >> ./耶ode/耍lgorithms/虹tkUnsharpMaskLevelSetImageFilter.txx
>  >>
>
./耶ode/耍lgorithms/虹tkCorrelationCoefficientHistogramImageToImageMetric.h
>  >>
>  >>
>
./耶ode/耍lgorithms/虹tkCorrelationCoefficientHistogramImageToImageMetric.tx
x
>
>  >>
>  >> ./耶ode/耍lgorithms/虹tkFEMFiniteDifferenceFunctionLoad.h
>  >> ./耶ode/耍lgorithms/虹tkFEMFiniteDifferenceFunctionLoad.txx
>  >> ./耶ode/耍lgorithms/虹tkHistogramImageToImageMetric.h
>  >> ./耶ode/耍lgorithms/虹tkHistogramImageToImageMetric.txx
>  >> ./耶ode/耍lgorithms/虹tkMIRegistrationFunction.h
>  >> ./耶ode/耍lgorithms/虹tkMIRegistrationFunction.txx
>  >> ./耶ode/耍lgorithms/虹tkMeanSquareRegistrationFunction.h
>  >> ./耶ode/耍lgorithms/虹tkMeanSquareRegistrationFunction.txx
>  >> ./耶ode/耍lgorithms/虹tkMeanSquaresHistogramImageToImageMetric.h
>  >> ./耶ode/耍lgorithms/虹tkMeanSquaresHistogramImageToImageMetric.txx
>  >> ./耶ode/耍lgorithms/虹tkNCCRegistrationFunction.h
>  >> ./耶ode/耍lgorithms/虹tkMutualInformationHistogramImageToImageMetric.h
>  >>
./耶ode/耍lgorithms/虹tkMutualInformationHistogramImageToImageMetric.txx
>  >> ./耶ode/耍lgorithms/虹tkNCCRegistrationFunction.txx
>  >>
>
./耶ode/耍lgorithms/虹tkNormalizedMutualInformationHistogramImageToImageMetr
ic.h
>
>  >>
>  >>
>
./耶ode/耍lgorithms/虹tkNormalizedMutualInformationHistogramImageToImageMetr
ic.txx
>
>  >>
>  >> ./耶ode/耑asicFilters/虹tkNonThreadedShrinkImageFilter.h
>  >> ./耶ode/耑asicFilters/虹tkNonThreadedShrinkImageFilter.txx
>  >> ./耶ode/耑asicFilters/虹tkParametricSpaceToImageSpaceMeshFilter.h
>  >> ./耶ode/耑asicFilters/虹tkParametricSpaceToImageSpaceMeshFilter.txx
>  >> ./耶ode/耑asicFilters/虹tkChainCodeToFourierSeriesPathFilter.h
>  >> ./耶ode/耑asicFilters/虹tkChainCodeToFourierSeriesPathFilter.txx
>  >> ./耶ode/耑asicFilters/虹tkGetAverageSliceImageFilter.h
>  >> ./耶ode/耑asicFilters/虹tkGetAverageSliceImageFilter.txx
>  >> ./耶ode/耑asicFilters/虹tkLazyEdgeDetectionImageFilter3D.h
>  >> ./耶ode/耑asicFilters/虹tkLazyEdgeDetectionImageFilter3D.txx
>  >> ./耶ode/耑asicFilters/虹tkMidsagittalPlaneExtractionImageFilter.h
>  >> ./耶ode/耑asicFilters/虹tkMidsagittalPlaneExtractionImageFilter.txx
>  >> ./耶ode/耑asicFilters/虹tkParallelSparseFieldLevelSetImageFilter.h
>  >> ./耶ode/耑asicFilters/虹tkParallelSparseFieldLevelSetImageFilter.txx
>  >> ./耶ode/耶ommon/虹tkBloxBoundaryPointPixel.h
>  >> ./耶ode/耶ommon/虹tkBloxItem.h
>  >> ./耶ode/耶ommon/虹tkConditionalIterator.h
>  >> ./耶ode/耶ommon/虹tkConditionalIterator.txx
>  >> ./耶ode/耶ommon/虹tkDefaultDynamicMeshTraits.h
>  >> ./耶ode/耶ommon/虹tkDefaultImageTraits.h
>  >> ./耶ode/耶ommon/虹tkDefaultStaticMeshTraits.h
>  >> ./耶ode/耶ommon/虹tkFiniteDifferenceFunction.txx
>  >> ./耶ode/耶ommon/虹tkFloodFilledFunctionConditionalIterator.h
>  >> ./耶ode/耶ommon/虹tkFloodFilledFunctionConditionalIterator.txx
>  >> ./耶ode/耶ommon/虹tkFloodFilledImageFunctionConditionalIterator.txx
>  >> ./耶ode/耶ommon/虹tkFloodFilledSpatialFunctionConditionalIterator.txx
>  >> ./耶ode/耶ommon/虹tkHexahedronCellTopology.h
>  >> ./耶ode/耶ommon/虹tkImageContainerInterface.h
>  >> ./耶ode/耶ommon/虹tkImageIteratorWithIndex.h
>  >> ./耶ode/耶ommon/虹tkImageIteratorWithIndex.txx
>  >> ./耶ode/耶ommon/虹tkImageRandomIteratorWithIndex.h
>  >> ./耶ode/耶ommon/虹tkImageReverseIterator.h
>  >> ./耶ode/耶ommon/虹tkImageReverseIterator.txx
>  >> ./耶ode/耶ommon/虹tkIndexedContainerInterface.h
>  >> ./耶ode/耶ommon/虹tkIntTypes.h
>  >> ./耶ode/耶ommon/虹tkMeshRegion.cxx
>  >> ./耶ode/耶ommon/虹tkMeshRegion.h
>  >> ./耶ode/耶ommon/虹tkNeighborhoodAlgorithm.h
>  >> ./耶ode/耶ommon/虹tkNumericTraits.cxx
>  >> ./耶ode/耶ommon/虹tkPixelAccessor.h
>  >> ./耶ode/耶ommon/虹tkPixelTraits.h
>  >> ./耶ode/耶ommon/虹tkQuadraticTriangleCellTopology.h
>  >> ./耶ode/耶ommon/虹tkQuadrilateralCellTopology.h
>  >> ./耶ode/耶ommon/虹tkScalarVector.h
>  >> ./耶ode/耶ommon/虹tkSimpleFastMutexLock.h
>  >> ./耶ode/耶ommon/虹tkTetrahedronCellTopology.h
>  >> ./耶ode/耶ommon/虹tkTimeProbe.h
>  >> ./耶ode/耶ommon/虹tkTimeProbesCollectorBase.h
>  >>
>  >>
>  >> _______________________________________________
>  >> Insight-developers mailing list
>  >> Insight-developers at itk . org
>  >> http://www . itk . org/mailman/listinfo/insight-developers
>  >
>  >
>  >
>  >
>  >
>  >
>
>
>
>
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk . org
> http://www . itk . org/mailman/listinfo/insight-developers
>