[Insight-developers] STEP 1: REMOVE UNTESTED CODE BY FRIDAY AUGUST 8, 9:00 EST

[Joshua Cates]

Hi Luis,

I agree with the wisdom of purging untested code.  Just want to make sure
that the dashboard is not the only judge and jury.

A few notable classes probably deserve clemency:

./Code/Common/itk_hashtable.cxx
./Code/Common/itkImageIteratorWithIndex.h, .txx
./Code/Common/itkRandomIteratorWithIndex.h, .txx
./Code/Common/itkReverseIterator.h, .txx
./Code/Common/itkNumericTraits.cxx
./Code/Common/itkVector.cxx

and itkNeighborhoodAlgorithm.h, of course. I believe all of these are in 
use in tested code. 

I've noticed that there are many classes like itkNeighborhoodAlgorithm
where one of .h/.txx is listed as untested but the corresponding .txx/.h
has coverage.

Josh.
______________________________
 Josh Cates			
 School of Computer Science	
 University of Utah
 Email: cates at sci . utah . edu
 Phone: (801) 587-7697
 URL:   http://www . sci . utah . edu/~cates


On Tue, 5 Aug 2003, Luis Ibanez wrote:

> 
> Hi Josh,
> 
> The final goal is not to remove the classes in the list but
> to make sure they are covered.
> 
> If we can justify the absence of explicit testing for specific
> files, they can of course be exempted from the list of files
> to be removed.
> 
> Note that the coverage is reported by files but we should
> actually consider it by classes (.h+.txx).
> 
> For example, the NeigborhoodAlgorithm.txx appears as 100% covered
> http://www . itk . org/Testing/Sites/esopus . crd/SunOS-5 . 7-c++/Coverage/__Code_Common_itkNeighborhoodAlgorithm_txx . html
> while its header appears as UNTESTED.
> 
> 
> So, please just post a list of the uncovered files that you
> consider should be exempted from being removed.
> 
> 
> 
> Thanks
> 
> 
>     Luis
> 
> 
> ----------------------
> Joshua Cates wrote:
> > Hi Luis,
> > 
> > Be careful with this.  Things are sometimes more complicated than the
> > dashboard would suggest.  There are cases where files do not show up in
> > coverage, but are actually quite extensively used.  If you remove
> > itkNeighborhoodAlgorithm.h, for example, you will break almost all of the
> > basic filtering algorithms like anisotropic diffusion, morphology, etc.  
> > A grep for "#include itkNeighborhoodAlgorithm.h" in BasicFilters returns a
> > list of more than 20 files, most of which are themselves heavily used and 
> > tested.
> > 
> > Josh.
> > 
> > ______________________________
> >  Josh Cates			
> >  School of Computer Science	
> >  University of Utah
> >  Email: cates at sci . utah . edu
> >  Phone: (801) 587-7697
> >  URL:   http://www . sci . utah . edu/~cates
> > 
> 
>