[Insight-developers] itkHistogramImageToImageMetric : missing tests

[Luis Ibanez]

Hi Raghavendra,

Thanks for adding the tests.

Abstract classes should be tested by instantiating
one of their concrete subclasses and exercising on
them the functionalities provided by the base class
(the abstract class).

Please let us know if you encounter any difficulty
in doing so.


   Thanks,


     Luis


-----------------------------------
Raghavendra Chandrashekara wrote:
> Hi Luis,
> 
> I've added the tests for the histogram metric classes. These are the 
> classes I've added the tests for:
> 
> itkCorrelationCoefficientHistogramImageToImageMetric
> itkMeanSquaresHistogramImageToImageMetric
> itkMutualInformationHistogramImageToImageMetric
> itkNormalizedMutualInformationHistogramImageToImageMetric
> 
> Since itkHistogramImageToImageMetric is an abstract class should I 
> remove the test that you added? Also should I change the CMakeLists.txt 
> file to add the new tests? Are there any other files that I need to 
> change to make the new tests run?
> 
> Thanks,
> 
> Raghavendra
> 
> Luis Ibanez wrote:
> 
>> Hi Raghavendra,
>>
>> The classes
>>
>>    itkHistogramImageToImage
>>    itkMeanSquaresHistogramImageToImage
>>
>>
>> in Insight/Code/Algorithms
>> http://www . itk . org/cgi-bin/viewcvs . cgi/Code/Algorithms/itkHistogramImageToImageMetric . h?sortby=date&cvsroot=Insight 
>>
>> http://www . itk . org/cgi-bin/viewcvs . cgi/Code/Algorithms/itkMeanSquaresHistogramImageToImageMetric . h?sortby=date&cvsroot=Insight 
>>
>>
>>
>> were missing tests.
>>
>> We just added dummy tests under
>>
>> Test/Code/Algorirthms/
>>   itkHistogramImageToImageTest.cxx
>>   itkMeanSquaresHistogramImageToImageTest.cxx
>>
>>
>> The tests are empty and are set to *FAIL*,
>> so it will show up in the dashboad.
>>
>> Could you please add a reasonable testing code
>> to these new files, in order to cover these classes.
>>
>>
>> Thanks,
>>
>>
>>    Luis
>>
>>
>>
>> _______________________________________________
>> Insight-developers mailing list
>> Insight-developers at itk . org
>> http://www . itk . org/mailman/listinfo/insight-developers
> 
> 
> 
> 
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk . org
> http://www . itk . org/mailman/listinfo/insight-developers
>