[Insight-developers] Re: itkConstSmartNeighborhoodIterator

[Joshua Cates]

I agree there are potential problems.  I'll take a look at it.  I've never
been very happy with how the boundary condition object is handled in
this class.

Josh.

______________________________
 Josh Cates			
 School of Computer Science	
 University of Utah
 Email: cates@cs.utah.edu
 Phone: (801) 587-7697
 URL:   www.cs.utk.edu/~cates


On Thu, 10 Jan 2002, Miller, James V (CRD) wrote:

> Josh,
> 
> Bill said that your fix to the ConstSmartNeighborhoodIterator was to put a dynamic_cast<> 
> in the GetBoundaryCondition() method.  
> 
> I am concerned that the dynamic_cast<> is going to fail whenever someone has called
> OverrideBoundaryCondition() and passed in a different boundary condition type.
> OverrideBoundaryCondition() takes any BoundaryCondition type and stores it in the ivar
> that GetBoundaryCondition() eventually returns.
> 
> My guess is that the GetBoundaryCondition() method should return the superclass BoundaryCondition
> type as opposed to the template type.
> 
> Also, I think I would try to remove the need for keeping an m_BoundaryCondition and an
> m_InternalBoundaryCondition.
> 
> Jim
> 
> 
> -----Original Message-----
> From: Joshua Cates [mailto:cates@cs.utah.edu]
> Sent: Wednesday, January 09, 2002 6:43 PM
> To: Lorensen, William E (CRD)
> Cc: insight-developers@public.kitware.com
> Subject: [Insight-developers] Re: itkConstSmartNeighborhoodIterator
> 
> 
> Should be fixed now.
> 
> Josh.
> 
> On Wed, 9 Jan 2002, Lorensen, William E (CRD) wrote:
> 
> > Josh,
> > The wrapping code is complaining about the GetBoundaryCondition method. Could you look into this?
> > 
> > Bill
> > 
> 
> _______________________________________________
> Insight-developers mailing list
> Insight-developers@public.kitware.com
> http://public.kitware.com/mailman/listinfo/insight-developers
>