[Insight-developers] Adding indices and sizes
Miller, James V (CRD)
millerjv@crd.ge.com
Tue, 2 Oct 2001 13:32:24 -0400
This message is in MIME format. Since your mail reader does not understand
this format, some or all of this message may not be legible.
------_=_NextPart_000_01C14B68.32C221F0
Content-Type: multipart/alternative;
boundary="----_=_NextPart_001_01C14B68.32C221F0"
------_=_NextPart_001_01C14B68.32C221F0
Content-Type: text/plain;
charset="iso-8859-1"
We just fixed a number of cases where we were adding an element of an Index and an element of a Size.
Since Index is signed and Size is unsigned, adding individual elements like
index[i] + size[i]
produces an unsigned result. This is usually not what we want and we are really looking for
index[i] + static_cast<long>(size[i])
This was tripping the pipeline mechanism whenever a negative index was encountered in the regions.
Filters were not being executed because it thought the new requested regions were within the old
buffered regions.
I made a pass through the system and modified files where the following grep call triggered
grep -i index * | grep -i size | grep -i "+"
I did not scan the Examples or Unsupported.
Jim Miller
_____________________________________
Visualization & Computer Vision
GE Corporate Research & Development
Bldg. KW, Room C218B
P.O. Box 8, Schenectady NY 12301
millerjv@crd.ge.com < mailto:millerjv@crd.ge.com <mailto:millerjv@crd.ge.com> >
(518) 387-4005, Dial Comm: 8*833-4005,
Cell: (518) 505-7065, Fax: (518) 387-6981
------_=_NextPart_001_01C14B68.32C221F0
Content-Type: text/html;
charset="iso-8859-1"
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META content="MSHTML 5.50.4807.2300" name=GENERATOR></HEAD>
<BODY>
<DIV><SPAN class=343291817-02102001><FONT size=2>We just fixed a number of cases
where we were adding an element of an Index and an element of a Size. Since
Index is signed and Size is unsigned, adding individual elements
like</FONT></SPAN></DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2>index[i] +
size[i]</FONT></SPAN></DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2>produces an unsigned
result. This is usually not what we want and we are really looking
for</FONT></SPAN></DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2>index[i] +
static_cast<long>(size[i])</FONT></SPAN></DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2>This was tripping the pipeline
mechanism whenever a negative index was encountered in the regions. Filters were
not being executed because it thought the new requested regions were within the
old buffered regions.</FONT></SPAN></DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2>I made a pass through the
system and modified files where the following grep call
triggered</FONT></SPAN></DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2>grep -i index * | grep -i size
| grep -i "+"</FONT></SPAN></DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=343291817-02102001><FONT size=2>I did not scan the Examples or
Unsupported.</FONT></SPAN></DIV><BR>
<P><B><FONT face="Comic Sans MS" color=#000080>Jim Miller</FONT></B>
<BR><B><I><FONT face=Arial color=#ff0000
size=2>_____________________________________</FONT></I></B><I></I><BR><I></I><I><FONT
face=Arial color=#000000 size=1>Visualization & Computer Vision<BR>GE
Corporate Research & Development<BR>Bldg. KW, Room C218B<BR>P.O. Box 8,
Schenectady NY 12301<BR><BR></FONT><U><FONT face=Arial color=#0000ff
size=1>millerjv@crd.ge.com <<A
href="mailto:millerjv@crd.ge.com">mailto:millerjv@crd.ge.com</A>></FONT></U></I><BR><I><FONT
face=Arial color=#000000 size=1>(518) 387-4005, Dial Comm: 8*833-4005,
</FONT></I><BR><I><FONT face=Arial color=#000000 size=1>Cell: (518) 505-7065,
Fax: (518) 387-6981</FONT></I> </P><BR>
<DIV> </DIV></BODY></HTML>
------_=_NextPart_001_01C14B68.32C221F0--
------_=_NextPart_000_01C14B68.32C221F0
Content-Type: application/octet-stream;
name="Miller, James V (CRD).vcf"
Content-Disposition: attachment;
filename="Miller, James V (CRD).vcf"
BEGIN:VCARD
VERSION:2.1
N:Miller;James
FN:Miller, James V (CRD)
ORG:CRD;ESL
TITLE:Computer Scientist
TEL;WORK;VOICE:*833-4005
TEL;WORK;VOICE:1 518 387-4005
ADR;WORK:;KW-C218B;P.O. Box 8;Schenectady;New York;12301;USA
LABEL;WORK;ENCODING=QUOTED-PRINTABLE:KW-C218B=0D=0AP.O. Box 8=0D=0ASchenectady, New York 12301=0D=0AUSA
EMAIL;PREF;INTERNET:millerjv@crd.ge.com
REV:20010420T140329Z
END:VCARD
------_=_NextPart_000_01C14B68.32C221F0--