[Insight-developers] Re: CMakeList.txt changes

[Paul Hughett]

Bill Hoffman wrote to Paul Hughett:

> Now that this is fixed, can you please undo all of the changes you
> make to CMakeList.txt.

Bill,

After thinking it over a bit, I'm not convinced that all the changes
should be undone.  Consider them by categories:

1.  Explicit references to the platform-specific libraries dl and pthread:
Definitely should not be there and have already been removed.

2.  Referencing the itk include directories in INCLUDE_DIRECTORIES:  This
is portable, makes explicit the dependencies between directories that we
decided in SLC, and provides an automatic means for detecting violations.
I'd argue that these are useful and should stay in.

3.  Referencing the itk library files in LINK_LIBRARIES:  Same as number 2.

4.  Referencing the directories for the library files in LINK_DIRECTORIES:
Same rationale as number 2, but redundant if number 3 is left in.  Define
only at the top level.

How say you?


Paul Hughett