[Insight-developers] broken code

[Joshua Cates]

Hello,

Recent changes in base classes (checked in since Thursday, I think) have
broken some of my code exercised by:
Insight/Testing/Code/Common/itkFilterImageAnisotropicDiffusionTest.cxx
Insight/Testing/Code/Common/itkFilterImageSingleOperator.cxx
and Insight/Testing/Code/Common/itkNeighborhoodOperatorTest.cxx.

Something appears to be wrong with the ImageIterators. In compiling 
(linux, gcc) itkFilterImageAnisotropicDiffusionTest, for example, I get
these errors and warnings:

/Insight/Code/Common/itkImageIteratorWithIndex.txx:
In method
`itk::ImageIteratorWithIndex<itk::Image<itk::Scalar<float>,4,itk::ValarrayImageContainer<long
unsigned int,itk::Scalar<float> > > >::ImageIteratorWithIndex(const
itk::Image<itk::Scalar<float>,4,itk::ValarrayImageContainer<long unsigned
int,itk::Scalar<float> > > *, const itk::ImageRegion<4> &)':
/Insight/Code/Common/itkImageRegionSimpleIterator.h:115:
instantiated from
`itk::ImageRegionSimpleIterator<itk::Image<itk::Scalar<float>,4,itk::ValarrayImageContainer<long
unsigned int,itk::Scalar<float> > > >::ImageRegionSimpleIterator(const
itk::Image<itk::Scalar<float>,4,itk::ValarrayImageContainer<long unsigned
int,itk::Scalar<float> > > *, const itk::ImageRegion<4> &)'
/Insight/Code/Common/itkFilterImageAnisotropicDiffusion.txx:58: 
instantiated from
`itk::FilterImageAnisotropicDiffusion<itk::Scalar<float>,4>::CopyInputToOutput()'
/Insight/Code/Common/itkFilterImageAnisotropicDiffusion.txx:152:
instantiated from
`itk::FilterImageAnisotropicDiffusion<itk::Scalar<float>,4>::GenerateData()'
/Insight/Code/Common/itkProcessObject.h:329:
instantiated from here
/Insight/Code/Common/itkImageIteratorWithIndex.txx:72:
passing `const
itk::Image<itk::Scalar<float>,4,itk::ValarrayImageContainer<long unsigned
int,itk::Scalar<float> > > *' as argument 1 of
`itk::SmartPointer<itk::Image<itk::Scalar<float>,4,itk::ValarrayImageContainer<long
unsigned int,itk::Scalar<float> > > >::operator 
=(itk::Image<itk::Scalar<float>,4,itk::ValarrayImageContainer<long 
unsigned int,itk::Scalar<float> > > *)' discards qualifiers

/Insight/Code/Common/itkImageIteratorWithIndex.h: In
method `class itk::Scalar<float> &
itk::ImageIteratorWithIndex<itk::Image<itk::Scalar<float>,4,itk::ValarrayImageContainer<long
unsigned int,itk::Scalar<float> > > >::operator *() const':
/Insight/Code/Common/itkFilterImageAnisotropicDiffusion.txx:64:
instantiated from
`itk::FilterImageAnisotropicDiffusion<itk::Scalar<float>,4>::CopyInputToOutput()'
/Insight/Code/Common/itkFilterImageAnisotropicDiffusion.txx:152:
instantiated from
`itk::FilterImageAnisotropicDiffusion<itk::Scalar<float>,4>::GenerateData()'
/Insight/Code/Common/itkProcessObject.h:329:
instantiated from here
/Insight/Code/Common/itkImageIteratorWithIndex.h:243:
initialization of non-const reference type `class itk::Scalar<float> &'
/Insight/Code/Common/itkImageIteratorWithIndex.h:243:
from rvalue of type `itk::Scalar<float>'

/Insight/Code/Common/itkImageIteratorWithIndex.h:243:
warning: returning reference to temporary

Will someone please fix these as soon as possible? If my code requires
changes to support recent base class modifications please let me know.

Thanks,

Josh.



+--+--+--+--+--+--+--+--+--+--+--+--
 Josh Cates			
 Department of Computer Science	
 University of Utah
 Email: cates at cs.utah.edu
 Phone: (801) 587-7697
 URL:   www.cs.utk.edu/~cates
--+--+--+--+--+--+--+--+--+--+--+---