[Girder-users] Issue with Adding and Removing Users to/from Groups

[Zach Mullen]

Hi Tristan,

This is expected, but is also a bug -- this endpoint currently saves the
document, so simultaneous calls to the same group document could clobber
one another. The solution to this would be to use atomic update calls in
the backend implementation to update the access list. I've opened a ticket
for this: https://github.com/girder/girder/issues/1817

Thanks for reporting this.



Zach Mullen
Kitware, Inc.
919-869-8858

On Tue, Feb 28, 2017 at 12:51 PM, Tristan Wright <tristan.wright at kitware.com
> wrote:

> Followup: I *am *able to reproduce with the curl commands with the
> attached script. The script uses env variables GIRDER_TOKEN, USER1, USER2
> (user Id's), and GROUP_ID.
>
> On Tue, Feb 28, 2017 at 9:32 AM, Tristan Wright <
> tristan.wright at kitware.com> wrote:
>
>> Hi all,
>> I believe I'm running into a concurrency issue with adding multiple users
>> to a group with the "force=true" option on.
>>
>> Video of network log: https://drive.google.com/
>> open?id=0BxhQv23DV8jmS3BxRHlTUFBscU0
>> Video summary:
>>
>>    - Page loads, fetches group user list, there is 1 user.
>>    - Make two requests adding two users Sarah and Hannah
>>    - group/access response is a list of two users, the original user and
>>    Hannah
>>
>> I expect there to be 3 users in the group/access response. Refreshing the
>> page has no effect, it looks like something is colliding and not being
>> changed properly?
>>
>> The call is made with chained promises. Perhaps 1/5 times the changes are
>> correctly made to the access list. I've tried to replicate the problem with
>> curl calls unsuccessfully, the final call has the right amount of users. I
>> see the same behavior when trying to remove multiple users from a group.
>>
>> Is this a girder bug or am I making the invitation requests improperly?
>>
>> --
>> - Tristan Wright
>>
>> *R&D Engineer*
>> *Kitware Inc.*
>>
>
>
>
> --
> - Tristan Wright
>
> *R&D Engineer*
> *Kitware Inc.*
>
> _______________________________________________
> Girder-users mailing list
> Girder-users at public.kitware.com
> http://public.kitware.com/mailman/listinfo/girder-users
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/girder-users/attachments/20170228/b240d90d/attachment.html>