[Geojs-users] problems loading wms layers with geojs current master

[Jonathan Beezley]

It's currently 0.6-rc-1.  I had a few concerns about the state of the
library before leaving for vacation, so I didn't want to tag an "official"
release yet.  Any changes we make before the actual 0.6 will almost
certainly be API compatible.

> I'm confused here.  The latest master of GeoJs can be installed with
Minerva using "sudo girder-install plugin".

The latest master contains that commit as well.  The commit I posted though
doesn't have the massive refactor PR in it, so it won't break the existing
code.

On Mon, Jan 4, 2016 at 3:01 PM, Michael Grauer <michael.grauer at kitware.com>
wrote:

> Thanks, good to know.
>
> I can submit a PR for Minerva using the SHA of the 0.6 release of GeoJs,
> now that I know what the change was in GeoJs and what I'll have to in
> Minerva to fix it.
>
> I was trying to track down the source of the error while QA-ing Chris'
> minerva-ansible-vagrant branch, is the background.
>
> > Although, it wouldn't be a bad idea to fix the issues with the latest
> master.  We will want to do so soon anyway.
>
> I'm confused here.  The latest master of GeoJs can be installed with
> Minerva using "sudo girder-install plugin".
>
>
> On Mon, Jan 4, 2016 at 2:53 PM, Jonathan Beezley <
> jonathan.beezley at kitware.com> wrote:
>
>> You probably want this commit then:
>> https://github.com/OpenGeoscience/geojs/commit/5444c02ac9554cf133b2c56d4b30df9ccbf66653
>>
>> Although, it wouldn't be a bad idea to fix the issues with the latest
>> master.  We will want to do so soon anyway.
>>
>> On Mon, Jan 4, 2016 at 2:50 PM, Michael Grauer <
>> michael.grauer at kitware.com> wrote:
>>
>>> That line does set the Geojs SHA that Minerva uses, but with that SHA
>>> you linked to (and what I had used before), installing minerva via "sudo
>>> girder-install plugin" fails on the bower step.  Using Geojs master
>>> succeeds.
>>>
>>> On Mon, Jan 4, 2016 at 2:47 PM, Jonathan Beezley <
>>> jonathan.beezley at kitware.com> wrote:
>>>
>>>> Does this line in the package.json not fix the SHA that minerva checks
>>>> out?
>>>>
>>>> <http://goog_1216635884>
>>>> https://github.com/Kitware/minerva/blob/master/package.json#L9
>>>>
>>>> On Mon, Jan 4, 2016 at 2:43 PM, Jonathan Beezley <
>>>> jonathan.beezley at kitware.com> wrote:
>>>>
>>>>> Yes, that was one backward incompatible change that we made bumping to
>>>>> 0.6.  David fixed the WMS example with this commit:
>>>>>
>>>>>
>>>>> https://github.com/OpenGeoscience/geojs/commit/69c8b9b2e9372902d508f63d76978978a67fedd2
>>>>>
>>>>> I suspect you will probably need the same changes.
>>>>>
>>>>> On Mon, Jan 4, 2016 at 2:37 PM, Aashish Chaudhary <
>>>>> aashish.chaudhary at kitware.com> wrote:
>>>>>
>>>>>> Mike,
>>>>>>
>>>>>> There is a list geojs-users at public.kitware.com -:) for the next
>>>>>> time.
>>>>>>
>>>>>> - aashish
>>>>>>
>>>>>> On Mon, Jan 4, 2016 at 2:37 PM, Michael Grauer <
>>>>>> michael.grauer at kitware.com> wrote:
>>>>>>
>>>>>>> Hi Geojs-ers,
>>>>>>>
>>>>>>> On a current master of Geojs, when I try to load a wms layer, when I
>>>>>>> try to call
>>>>>>>
>>>>>>> layer.gcs(projection);
>>>>>>>
>>>>>>> I'm getting Uncaught TypeError: b.gcs is not a function.
>>>>>>>
>>>>>>> This used to work until quite recently (in terms of geojs), but I
>>>>>>> can't build an older version of geojs inside my Girder+Minerva stack using
>>>>>>> "girder-install plugin", only current geojs master.
>>>>>>>
>>>>>>> I see this in the geojs examples for wms, is that what I should
>>>>>>> change to?
>>>>>>>
>>>>>>> var bb = wms.gcsTileBounds({x: x, y: y, level: zoom}, projection);
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Mike
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>>
>>>>>>
>>>>>> *| Aashish Chaudhary | Technical Leader         | Kitware Inc.
>>>>>>     *
>>>>>> *| http://www.kitware.com/company/team/chaudhary.html
>>>>>> <http://www.kitware.com/company/team/chaudhary.html>*
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/geojs-users/attachments/20160104/4e91fbe7/attachment.html>