[Geojs-developers] [girder] Add a grunt option for disabling uglify mangling (#881)

Jonathan Beezley jonathan.beezley at kitware.com
Wed Jul 1 10:00:27 EDT 2015


If we are producing both anyway, it doesn't make sense to not minify
geo.min.js.  That is just confusing.  We could provide a development option
that causes the examples to use the non-minified version though.

On Wed, Jul 1, 2015 at 9:54 AM, Aashish Chaudhary <
aashish.chaudhary at kitware.com> wrote:

> Sure, but what happens is that examples (or tests), one of these two, uses
> geo.min.js and then we are debugging its an extra step to change then to
> use geo.js. I am wondering if we we provide debug-js option, then we won't
> mangle geo.min.js as well? Just a thought.
>
> - aashish
>
> On Wed, Jul 1, 2015 at 9:51 AM, Jonathan Beezley <
> jonathan.beezley at kitware.com> wrote:
>
>> We already generate both minified and non-minified.
>>
>> On Wed, Jul 1, 2015 at 9:50 AM, Aashish Chaudhary <
>> aashish.chaudhary at kitware.com> wrote:
>>
>>> Jon,
>>>
>>> Should we add this option to geojs as well?
>>>
>>> - aashish
>>>
>>> ---------- Forwarded message ----------
>>> From: Zach Mullen <notifications at github.com>
>>> Date: Wed, Jul 1, 2015 at 9:48 AM
>>> Subject: [girder] Add a grunt option for disabling uglify mangling (#881)
>>> To: girder/girder <girder at noreply.github.com>
>>>
>>>
>>> ------------------------------
>>> You can view, comment on, or merge this pull request online at:
>>>
>>>   https://github.com/girder/girder/pull/881
>>> Commit Summary
>>>
>>>    - Add a grunt option for disabling uglify mangling
>>>
>>> File Changes
>>>
>>>    - *M* Gruntfile.js
>>>    <https://github.com/girder/girder/pull/881/files#diff-0> (27)
>>>    - *M* docs/development.rst
>>>    <https://github.com/girder/girder/pull/881/files#diff-1> (5)
>>>
>>> Patch Links:
>>>
>>>    - https://github.com/girder/girder/pull/881.patch
>>>    - https://github.com/girder/girder/pull/881.diff
>>>
>>>>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/girder/girder/pull/881>.
>>>
>>>
>>>
>>> --
>>>
>>>
>>>
>>> *| Aashish Chaudhary | Technical Leader         | Kitware Inc.
>>>   *
>>> *| http://www.kitware.com/company/team/chaudhary.html
>>> <http://www.kitware.com/company/team/chaudhary.html>*
>>>
>>
>>
>
>
> --
>
>
>
> *| Aashish Chaudhary | Technical Leader         | Kitware Inc.            *
> *| http://www.kitware.com/company/team/chaudhary.html
> <http://www.kitware.com/company/team/chaudhary.html>*
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/geojs-developers/attachments/20150701/69d44c51/attachment-0001.html>


More information about the Geojs-developers mailing list