[Ctk-developers] Issue with plugin framework (was: Re: ctk bug report & questions)

[Jean-Christophe Fillion-Robin]

Hi Zoltan,

You are welcome.

[[ So that other can benefit from the conversation, I re-added the
list in cc. Would be great if you could join the mailing list and
include it in future reply :)  ]]

Since you already have a patch, may be you could create a pull request
where you would just describe the issue. That would be a great first
step.

Later one, someone else may then be able to move forward if your patch
and get it integrated.

Thanks
Jc

On Thu, Sep 10, 2015 at 10:17 AM,  <Zoltan.Bardosi at student.i-med.ac.at> wrote:
> Dear Jean-Christophe,
>
> thank you for the answer. I will create a small example to trigger the
> problem and put it up to the issue tracker, but it has a relatively low
> priority in my todo list right now ;)
> I'm quite sure that this can be easily patched, as I already did in my local
> version, so patching it in the official version would be convenient, but it
> is not that urgent. :)
>
> Best regards,
> Zoltan Bardosi
>
>
>
> Quoting "Jean-Christophe Fillion-Robin" <jchris.fillionr at kitware.com>:
>
>> Hi Zoltan,
>>
>> NOTE: I added the developer list in cc
>>
>> Thanks for reaching out and welcome to the CTK community !
>>
>> To report issue, we are using the Github issue tracker (this is the
>> link "Report a problem" on the http://commontk.org page)
>>
>> See https://github.com/commontk/CTK/issues/new
>>
>> I also re-organized the "Getting started" page to be more clear. That
>> should help answering your questions.
>>
>>   http://commontk.org/index.php/Getting_Started
>>
>> To move forward, I would suggest you create an issue providing a
>> simple example allowing to reproduce the problem.
>>
>>
>> Looking at the changes associated with the CTK/Plugins folder, I
>> couldn't spot an obvious change that would break things.
>> See https://github.com/commontk/CTK/commits/master/Plugins
>>
>>
>> That said, I am sure other folks on the list should be able to help you
>> out.
>>
>> Let us know if you have any other questions,
>>
>> Thanks
>> Jc
>>
>> On Wed, Sep 9, 2015 at 3:18 AM,  <Zoltan.Bardosi at student.i-med.ac.at>
>> wrote:
>>>
>>> Dear Mr. Fillion-Robin,
>>>
>>> I write to you, because you seem to be the most active developer on CTK
>>> for
>>> the last few months (according to the ctk-developers mailing list
>>> archive)
>>> but this list is closed and I could not find any public lists that are
>>> used
>>> for bug-reporting.
>>> So I wonder what is the official way of doing this? Do I have to register
>>> with github?
>>>
>>> Anyways: We're using CTK as a plugin manager in our university project
>>> and
>>> we use the framework properties to pass some initial values to our
>>> plugins
>>> (using
>>> the launcher's setFrameworkProperties function).
>>>
>>> It has worked in the past but for some time now it seems to be broken, as
>>> all keys set this way are lost at the time the plugins query those
>>> properties..
>>>
>>> Fixing it seems to be one-liner like:
>>>
>>> bool ctkPluginFrameworkLauncher::start(const QString& symbolicName,
>>> ......
>>>   if (context == 0 && d->fwFactory == 0) {
>>> +    d->fwProps = ctkPluginFrameworkProperties::getProperties();
>>>     d->fwFactory.reset(new ctkPluginFrameworkFactory(d->fwProps));
>>> ....
>>>
>>> (well, actually there are other places like the install function where it
>>> would also need
>>> fixing..)
>>>
>>> Is this an intentional change in the library behaviour or could it be
>>> fixed
>>> in the current version of the library? It it is intentional, is there an
>>> equivalent mechanic to pass parameters to the start() function of the
>>> plugins?
>>>
>>> Best regards,
>>> Zoltan Bardosi
>>>
>>> PS: I've also tried to register to the ctk-developers list, but I'm not
>>> sure
>>> if I would be authorized just like that.. :)
>>>
>>
>>
>>
>> --
>> +1 919 869 8849
>>
>>
>
>



-- 
+1 919 869 8849