From pieper at isomics.com Fri Jan 3 20:12:40 2014 From: pieper at isomics.com (Steve Pieper) Date: Fri, 3 Jan 2014 15:12:40 -0500 Subject: [Ctk-developers] [slicer-devel] CTK CMake warning In-Reply-To: References: Message-ID: Hi Hans - How about if we switch the doublequotes to singlequotes, that's probably cleaner than the backslashes and would be compatible with the rest of the code in that file. (BTW, how does one replicate the warning?). -Steve On Thu, Jan 2, 2014 at 11:56 AM, Johnson, Hans J wrote: > Could someone close to the CTK development process please address this > cmake warning?: > > At line 226 of the CTK/CMake/ctkMacroCompilePythonScript.cmake needs to > have the ?Sorry? quotes escaped with \?Sorry\" > > CMake Warning (dev) at > CMake/SlicerMacroPythonWrapModuleVTKLibrary.cmake:97 (include): > Syntax Warning in cmake code at > > CTK/CMake/ctkMacroCompilePythonScript.cmake:226:24 > > Thanks, > Hans > > > > ________________________________ > Notice: This UI Health Care e-mail (including attachments) is covered by > the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is > confidential and may be legally privileged. If you are not the intended > recipient, you are hereby notified that any retention, dissemination, > distribution, or copying of this communication is strictly prohibited. > Please reply to the sender that you have received the message in error, > then delete it. Thank you. > ________________________________ > _______________________________________________ > slicer-devel mailing list > slicer-devel at bwh.harvard.edu > http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel > To unsubscribe: send email to > slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the > subject > > http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ > > > The information in this e-mail is intended only for the person to whom it > is > addressed. If you believe this e-mail was sent to you in error and the > e-mail > contains patient information, please contact the Partners Compliance > HelpLine at > http://www.partners.org/complianceline . If the e-mail was sent to you in > error > but does not contain patient information, please contact the sender and > properly > dispose of the e-mail. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From pieper at isomics.com Fri Jan 3 20:22:03 2014 From: pieper at isomics.com (Steve Pieper) Date: Fri, 3 Jan 2014 15:22:03 -0500 Subject: [Ctk-developers] [slicer-devel] CTK CMake warning In-Reply-To: References:

Message-ID: Can you try this branch and see if that fixes the warning? https://github.com/pieper/CTK/tree/fix-quote Thanks, Steve On Fri, Jan 3, 2014 at 3:14 PM, Johnson, Hans J wrote: > I think this warning is produced by newer versions of cmake. It seems > that "cmake version 2.8.12.1" started complaining. > > I'm OK with using single quotes if that works. > > Hans > > > From: Steve Pieper > Date: Friday, January 3, 2014 2:12 PM > To: Hans Johnson , "ctk-developers at commontk.org" < > ctk-developers at commontk.org> > Cc: Slicer Development > Subject: Re: [slicer-devel] CTK CMake warning > > Hi Hans - > > How about if we switch the doublequotes to singlequotes, that's probably > cleaner than the backslashes and would be compatible with the rest of the > code in that file. > > (BTW, how does one replicate the warning?). > > -Steve > > > On Thu, Jan 2, 2014 at 11:56 AM, Johnson, Hans J wrote: > >> Could someone close to the CTK development process please address this >> cmake warning?: >> >> At line 226 of the CTK/CMake/ctkMacroCompilePythonScript.cmake needs to >> have the ?Sorry? quotes escaped with \?Sorry\" >> >> CMake Warning (dev) at >> CMake/SlicerMacroPythonWrapModuleVTKLibrary.cmake:97 (include): >> Syntax Warning in cmake code at >> >> CTK/CMake/ctkMacroCompilePythonScript.cmake:226:24 >> >> Thanks, >> Hans >> >> >> >> ________________________________ >> Notice: This UI Health Care e-mail (including attachments) is covered by >> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is >> confidential and may be legally privileged. If you are not the intended >> recipient, you are hereby notified that any retention, dissemination, >> distribution, or copying of this communication is strictly prohibited. >> Please reply to the sender that you have received the message in error, >> then delete it. Thank you. >> ________________________________ >> _______________________________________________ >> slicer-devel mailing list >> slicer-devel at bwh.harvard.edu >> http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel >> To unsubscribe: send email to >> slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the >> subject >> >> http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ >> >> >> The information in this e-mail is intended only for the person to whom it >> is >> addressed. If you believe this e-mail was sent to you in error and the >> e-mail >> contains patient information, please contact the Partners Compliance >> HelpLine at >> http://www.partners.org/complianceline . If the e-mail was sent to you >> in error >> but does not contain patient information, please contact the sender and >> properly >> dispose of the e-mail. >> >> > > > ------------------------------ > Notice: This UI Health Care e-mail (including attachments) is covered by > the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is > confidential and may be legally privileged. If you are not the intended > recipient, you are hereby notified that any retention, dissemination, > distribution, or copying of this communication is strictly prohibited. > Please reply to the sender that you have received the message in error, > then delete it. Thank you. > ------------------------------ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From pieper at isomics.com Fri Jan 3 21:02:57 2014 From: pieper at isomics.com (Steve Pieper) Date: Fri, 3 Jan 2014 16:02:57 -0500 Subject: [Ctk-developers] [slicer-devel] CTK CMake warning In-Reply-To: References:

Message-ID: Okay great - I merged it in CTK and updated the hash used in slicer. -Steve On Fri, Jan 3, 2014 at 3:25 PM, Johnson, Hans J wrote: > Yep? That fixes it! > > Hans > > > From: Steve Pieper > Date: Friday, January 3, 2014 2:22 PM > To: Hans Johnson > Cc: "ctk-developers at commontk.org" , Slicer > Development > > Subject: Re: [slicer-devel] CTK CMake warning > > Can you try this branch and see if that fixes the warning? > > https://github.com/pieper/CTK/tree/fix-quote > > Thanks, > Steve > > On Fri, Jan 3, 2014 at 3:14 PM, Johnson, Hans J wrote: > >> I think this warning is produced by newer versions of cmake. It seems >> that "cmake version 2.8.12.1" started complaining. >> >> I'm OK with using single quotes if that works. >> >> Hans >> >> >> From: Steve Pieper >> Date: Friday, January 3, 2014 2:12 PM >> To: Hans Johnson , "ctk-developers at commontk.org" >> >> Cc: Slicer Development >> Subject: Re: [slicer-devel] CTK CMake warning >> >> Hi Hans - >> >> How about if we switch the doublequotes to singlequotes, that's >> probably cleaner than the backslashes and would be compatible with the rest >> of the code in that file. >> >> (BTW, how does one replicate the warning?). >> >> -Steve >> >> >> On Thu, Jan 2, 2014 at 11:56 AM, Johnson, Hans J wrote: >> >>> Could someone close to the CTK development process please address this >>> cmake warning?: >>> >>> At line 226 of the CTK/CMake/ctkMacroCompilePythonScript.cmake needs to >>> have the ?Sorry? quotes escaped with \?Sorry\" >>> >>> CMake Warning (dev) at >>> CMake/SlicerMacroPythonWrapModuleVTKLibrary.cmake:97 (include): >>> Syntax Warning in cmake code at >>> >>> CTK/CMake/ctkMacroCompilePythonScript.cmake:226:24 >>> >>> Thanks, >>> Hans >>> >>> >>> >>> ________________________________ >>> Notice: This UI Health Care e-mail (including attachments) is covered by >>> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is >>> confidential and may be legally privileged. If you are not the intended >>> recipient, you are hereby notified that any retention, dissemination, >>> distribution, or copying of this communication is strictly prohibited. >>> Please reply to the sender that you have received the message in error, >>> then delete it. Thank you. >>> ________________________________ >>> _______________________________________________ >>> slicer-devel mailing list >>> slicer-devel at bwh.harvard.edu >>> http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel >>> To unsubscribe: send email to >>> slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the >>> subject >>> >>> http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ >>> >>> >>> The information in this e-mail is intended only for the person to whom >>> it is >>> addressed. If you believe this e-mail was sent to you in error and the >>> e-mail >>> contains patient information, please contact the Partners Compliance >>> HelpLine at >>> http://www.partners.org/complianceline . If the e-mail was sent to you >>> in error >>> but does not contain patient information, please contact the sender and >>> properly >>> dispose of the e-mail. >>> >>> >> >> >> ------------------------------ >> Notice: This UI Health Care e-mail (including attachments) is covered by >> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is >> confidential and may be legally privileged. If you are not the intended >> recipient, you are hereby notified that any retention, dissemination, >> distribution, or copying of this communication is strictly prohibited. >> Please reply to the sender that you have received the message in error, >> then delete it. Thank you. >> ------------------------------ >> > > > > ------------------------------ > Notice: This UI Health Care e-mail (including attachments) is covered by > the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is > confidential and may be legally privileged. If you are not the intended > recipient, you are hereby notified that any retention, dissemination, > distribution, or copying of this communication is strictly prohibited. > Please reply to the sender that you have received the message in error, > then delete it. Thank you. > ------------------------------ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Fri Jan 3 22:20:15 2014 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 3 Jan 2014 17:20:15 -0500 Subject: [Ctk-developers] [slicer-devel] CTK CMake warning In-Reply-To: References:

Message-ID: Thanks Steve. -- Sent from my mobile device On Jan 3, 2014 4:03 PM, "Steve Pieper" wrote: > Okay great - I merged it in CTK and updated the hash used in slicer. > > -Steve > > > On Fri, Jan 3, 2014 at 3:25 PM, Johnson, Hans J wrote: > >> Yep? That fixes it! >> >> Hans >> >> >> From: Steve Pieper >> Date: Friday, January 3, 2014 2:22 PM >> To: Hans Johnson >> Cc: "ctk-developers at commontk.org" , Slicer >> Development >> >> Subject: Re: [slicer-devel] CTK CMake warning >> >> Can you try this branch and see if that fixes the warning? >> >> https://github.com/pieper/CTK/tree/fix-quote >> >> Thanks, >> Steve >> >> On Fri, Jan 3, 2014 at 3:14 PM, Johnson, Hans J wrote: >> >>> I think this warning is produced by newer versions of cmake. It seems >>> that "cmake version 2.8.12.1" started complaining. >>> >>> I'm OK with using single quotes if that works. >>> >>> Hans >>> >>> >>> From: Steve Pieper >>> Date: Friday, January 3, 2014 2:12 PM >>> To: Hans Johnson , "ctk-developers at commontk.org" >>> >>> Cc: Slicer Development >>> Subject: Re: [slicer-devel] CTK CMake warning >>> >>> Hi Hans - >>> >>> How about if we switch the doublequotes to singlequotes, that's >>> probably cleaner than the backslashes and would be compatible with the rest >>> of the code in that file. >>> >>> (BTW, how does one replicate the warning?). >>> >>> -Steve >>> >>> >>> On Thu, Jan 2, 2014 at 11:56 AM, Johnson, Hans J >> > wrote: >>> >>>> Could someone close to the CTK development process please address this >>>> cmake warning?: >>>> >>>> At line 226 of the CTK/CMake/ctkMacroCompilePythonScript.cmake needs to >>>> have the ?Sorry? quotes escaped with \?Sorry\" >>>> >>>> CMake Warning (dev) at >>>> CMake/SlicerMacroPythonWrapModuleVTKLibrary.cmake:97 (include): >>>> Syntax Warning in cmake code at >>>> >>>> CTK/CMake/ctkMacroCompilePythonScript.cmake:226:24 >>>> >>>> Thanks, >>>> Hans >>>> >>>> >>>> >>>> ________________________________ >>>> Notice: This UI Health Care e-mail (including attachments) is covered >>>> by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is >>>> confidential and may be legally privileged. If you are not the intended >>>> recipient, you are hereby notified that any retention, dissemination, >>>> distribution, or copying of this communication is strictly prohibited. >>>> Please reply to the sender that you have received the message in error, >>>> then delete it. Thank you. >>>> ________________________________ >>>> _______________________________________________ >>>> slicer-devel mailing list >>>> slicer-devel at bwh.harvard.edu >>>> http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel >>>> To unsubscribe: send email to >>>> slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the >>>> subject >>>> >>>> http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ >>>> >>>> >>>> The information in this e-mail is intended only for the person to whom >>>> it is >>>> addressed. If you believe this e-mail was sent to you in error and the >>>> e-mail >>>> contains patient information, please contact the Partners Compliance >>>> HelpLine at >>>> http://www.partners.org/complianceline . If the e-mail was sent to you >>>> in error >>>> but does not contain patient information, please contact the sender and >>>> properly >>>> dispose of the e-mail. >>>> >>>> >>> >>> >>> ------------------------------ >>> Notice: This UI Health Care e-mail (including attachments) is covered by >>> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is >>> confidential and may be legally privileged. If you are not the intended >>> recipient, you are hereby notified that any retention, dissemination, >>> distribution, or copying of this communication is strictly prohibited. >>> Please reply to the sender that you have received the message in error, >>> then delete it. Thank you. >>> ------------------------------ >>> >> >> >> >> ------------------------------ >> Notice: This UI Health Care e-mail (including attachments) is covered by >> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is >> confidential and may be legally privileged. If you are not the intended >> recipient, you are hereby notified that any retention, dissemination, >> distribution, or copying of this communication is strictly prohibited. >> Please reply to the sender that you have received the message in error, >> then delete it. Thank you. >> ------------------------------ >> > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From m.clarkson at ucl.ac.uk Wed Jan 8 21:54:02 2014 From: m.clarkson at ucl.ac.uk (Clarkson, Matt) Date: Wed, 8 Jan 2014 21:54:02 +0000 Subject: [Ctk-developers] Command Line Modules: Constraints and defaults In-Reply-To: <52CD9333.9060304@ucl.ac.uk> References: <52CD9333.9060304@ucl.ac.uk> Message-ID: <4620a020a4aa44a587cd1445f6f0e123@DB3PR01MB316.eurprd01.prod.exchangelabs.com> Hi there, John reported the error below to me. Looks to me like the .xsl file in CTK could be at fault. 1. The integer spin box has a Qt default of [0,99]. 2. The .xsl file applies a default of -999999999 to 999999999 but only if the constraints element does not exist. So, if it does exist, this bit is missed. 3. Then the default of 300 is clamped to 99. 4. Then the specific constraint of 1-9999 is applied So, either steps 3 or 4 need the ordering reversed, or step 2 needs to apply this range regardless of whether the constrains element is present. Can anyone advise? My XSD/XSLT/XML knowledge is limited. Thanks Matt ________________________________________ From: John Hipwell Sent: 08 January 2014 18:04 It looks to me as though the CLI module parsing clips default values at 2 digits. For instance the following: iterations mi Maximum number of iterations per level. Maximum number of iterations per level 300 1 9999 1 results in a default value of '99' appearing in the corresponding text box of the GUI. Has anyone noticed this? Removing the constraints results in the correct value of '300' being displayed. Curious.... John From s.mang at Dkfz-Heidelberg.de Thu Jan 9 12:22:53 2014 From: s.mang at Dkfz-Heidelberg.de (Mang, Sarah) Date: Thu, 9 Jan 2014 13:22:53 +0100 Subject: [Ctk-developers] Command Line Modules: Constraints and defaults In-Reply-To: References: <52CD9333.9060304@ucl.ac.uk> <4620a020a4aa44a587cd1445f6f0e123@DB3PR01MB316.eurprd01.prod.exchangelabs.com> Message-ID: Hi there, I may have found a related bug. If a parameter value is set by default to 2e-9 it will be set to 0 by CTK (maybe the GUI). So a similar problem may exist for floating point values. It would be great if you could have a look once you check the QT defaults. Cheers, Sarah -----Urspr?ngliche Nachricht----- Von: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] Im Auftrag von Clarkson, Matt Gesendet: Mittwoch, 8. Januar 2014 22:54 An: ctk-developers at commontk.org Betreff: [Ctk-developers] Command Line Modules: Constraints and defaults Hi there, John reported the error below to me. Looks to me like the .xsl file in CTK could be at fault. 1. The integer spin box has a Qt default of [0,99]. 2. The .xsl file applies a default of -999999999 to 999999999 but only if the constraints element does not exist. So, if it does exist, this bit is missed. 3. Then the default of 300 is clamped to 99. 4. Then the specific constraint of 1-9999 is applied So, either steps 3 or 4 need the ordering reversed, or step 2 needs to apply this range regardless of whether the constrains element is present. Can anyone advise? My XSD/XSLT/XML knowledge is limited. Thanks Matt ________________________________________ From: John Hipwell Sent: 08 January 2014 18:04 It looks to me as though the CLI module parsing clips default values at 2 digits. For instance the following: iterations mi Maximum number of iterations per level. Maximum number of iterations per level 300 1 9999 1 results in a default value of '99' appearing in the corresponding text box of the GUI. Has anyone noticed this? Removing the constraints results in the correct value of '300' being displayed. Curious.... John _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers From a.fetzer at Dkfz-Heidelberg.de Thu Jan 9 13:54:55 2014 From: a.fetzer at Dkfz-Heidelberg.de (Fetzer, Andreas) Date: Thu, 9 Jan 2014 14:54:55 +0100 Subject: [Ctk-developers] [slicer-devel] new dicom interface In-Reply-To: References:

<04C6BCB5F77FFF449DAE728C597984555EDDE8@MP-DUP-MBX-02.AD.QUEENSU.CA>

Message-ID: <57EE86D11538B44096C712532DBB6C5A0109E9235C08@DKFZEX01.ad.dkfz-heidelberg.de> Hi, Just a short notice regarding the layout discussion: I recently added another layout option called "dynamicTableLayout". If this is set the layout automatically switches to vertical if the widget size is too small and of course the other way around the switch to horizontal if the widget size is big enough. Andreas From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Andras Lasso Sent: Montag, 11. November 2013 17:11 To: pieper at bwh.harvard.edu; Csaba Pinter Cc: slicer-devel at bwh.harvard.edu; Andriy Fedorov; ctk-developers at commontk.org Subject: Re: [Ctk-developers] [slicer-devel] new dicom interface The vertical layout is good, because we need some width to show all the columns. The problems are that rows very high, thre are unnecessary buttons above/below the widget, and the loadable widget is also below the patient/study/series widget (the loadable widget could be on the right side of the patient/study/series widget instead). Andras From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Steve Pieper Sent: November 11, 2013 11:09 AM To: Csaba Pinter Cc: slicer-devel at bwh.harvard.edu; Andriy Fedorov; ctk-developers at commontk.org Subject: Re: [Ctk-developers] [slicer-devel] new dicom interface Yes, the feature is still there under the hood but Andreas removed the button to make the interface cleaner. We can add back a preference if we want to allow configuration of this. For now you can experiment on the fly with the line below. I preferred the horizontal layout since it shows more of the columns. But now that we have the building blocks I think we can make whatever interface we want. -Steve >>> slicer.modules.DICOMWidget.detailsPopup.tables.tableOrientation = 1 On Mon, Nov 11, 2013 at 10:55 AM, Csaba Pinter > wrote: Thank you very much for all the work of developing and integrating the new browser! I remember Andreas showing me a layout switcher feature in the new browser in the spring, which allowed the user to switch from horizontal to vertical view, in which the patient/study/series level are not underneath each other but organized side-by-side. Maybe using the vertical layout would solve the small screen problem. Or at least showing the control if it's still available. csaba From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Steve Pieper Sent: November 10, 2013 09:59 To: Andriy Fedorov; ctk-developers at commontk.org Cc: slicer-devel at bwh.harvard.edu Subject: Re: [Ctk-developers] [slicer-devel] new dicom interface Thanks for the feedback! I'm forwarding the thread to the ctk developer list since some ideas relate to the ctk components and some to the slicer integration. I agree with most of the suggestions and I think they will be pretty straightforward to implement (pull requests welcome!). This is sort of a first-pass with the new layout so we can iterate on some of these issues. I didn't want to delay implementing the new table display since it was identified as a critical issue for SlicerRT. -Steve On Sat, Nov 9, 2013 at 1:08 PM, Andriy Fedorov > wrote: I agree configuration is complex and should be in advanced. I was thinking about list of sources. See attached the way it's done in syngo.via, would be great to have a similar concept in Slicer, as a replacement of the directory button. I also agree with you completely that the way DICOM database button functions right now (file dialog popup) is very confusing. On Sat, Nov 9, 2013 at 12:55 PM, Andras Lasso > wrote: > The main problem with the directory selector is that the users think that it is for importing. I've helped several users with this problem, they all thought that the DICOM import was broken because they used this database directory selector instead of the Import button. Even after finding the Import directory they are still confused what this database directory selection is for and they are not sure if they have to set it to the directory where they store their DICOM files. We just should not show this database directory selector on the main GUI. Showing just a listbox (or checkboxes) with a list of database names (either local filesystem or remote systems) would be also fine. > > In general, _setup_ of DICOM hosts/connections, databases are too complex operations for most users (IP addresses, port numbers, AE titles, database directories, ...). However, once they are set up, the query/retrieve, push, etc. operations are easy to use. So, to reduce frustration of users and administrators, the GUI for setup should be clearly separated. GUI for users should be simplified and the GUI for all DICOM configuration settings should be editable in the Slicer Application settings. This applies to the Query/Retrieve GUI. The user should only see a list of data sources and search options; and editing server name, aeitle, address, port, cget flag, add/remove server, etc. should be only displayed in the Application settings. > > Andras > > -----Original Message----- > From: Andriy Fedorov [mailto:fedorov at bwh.harvard.edu] > Sent: November 9, 2013 12:23 PM > To: Andras Lasso > Cc: pieper at bwh.harvard.edu; slicer-devel at bwh.harvard.edu > Subject: Re: [slicer-devel] [Ctk-developers] new dicom interface > > On Sat, Nov 9, 2013 at 10:06 AM, Andras Lasso > wrote: >> * On a laptop screen only 3-4 patients, studies, and series are >> visible - we should see at least about 10 of each. Change the layout >> (e.g., move the loadables list into a second column; hide the plugin >> list by default and use a >> button - similar to the one in the >> Application settings/Modules - to show it), decrease the row height of >> the patients/studies/series tables (it looks to have about 1.5-2x line >> spacing and/or larger font) >> > > I had a similar concern. Does it make sense to have Patient/Study/Series panels collapslible? It is currently possible to move the separator all the way down to use all space for one panel, but it requires a lot of mouse interaction. > > I like the idea of ">>" for plugins list. > >> * Move "Local database" selector and Make DICOM browser persistent >> to an advanced options section (in a popup window or hidden by >> default) to save space and reduce clutter >> > > Here I would suggest not to hide it, but have a drop-down (ideally -- > checkable) list of databases. In the future, it would be great to integrate the remote sources that can be queried into this single drop-down list to provide a unified experience (this is how syngo.via does it). But even without remote sources, the use case is often there may be different databases for different projects, and right now Slicer is not very friendly in supporting more than one database. > > > >> >> >> Other changes to consider: >> >> * We could remove the "Close" button (having the "X" in the window >> corner and adding an "Esc" button shortcut should be enough) >> >> * View header: make it a right-click accessible option on the >> loadables list (note that currently if no loadable is selected it's >> still enabled and shows the latest selected loadable's info) or a >> small icon next to the series search bar >> >> * Remove: make it a right-click accessible option (now it's so far >> from all the patient/study/series selector that it's not very >> intuitive that it refers to them) or a small trashcan icon next to >> each search bar >> >> >> >> Andras >> >> >> >> From: ctk-developers-bounces at commontk.org >> [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Steve Pieper >> Sent: November 7, 2013 2:49 PM >> To: slicer-devel at bwh.harvard.edu; ctk-developers at commontk.org >> Subject: [Ctk-developers] new dicom interface >> >> >> >> Hello from the CTK hackfest in London! [1] >> >> >> >> For a while now several of groups have been working on improving the >> dicom browser in CTK (the one used in the Slicer DICOM module) to make >> it more consistent with clinical systems and to make it easier to >> customize. Work really got going at the last hackfest at Queens in >> Kingston [2] where a design was worked out that would help with a >> number of longstanding issues faced in SlicerRT [for example, 3] and >> some issues intrinsic to the way the old DICOM tree view was implemented [4]. >> >> >> >> After a lot of work at the CTK level by Adreas Fetzer and Marco Nolden >> of DKFZ and Csaba Pinter and Andras Lasso of Queens we now have a new >> interface to address these issues. Plus Alireza Mehrtash of BWH has >> added a DICOM header browser option to address a longstanding missing >> feature of slicer4 [5]. These have now been integrated into the >> slicer trunk [6] and the new interface is documented on the nightly section of the wiki [7]. >> >> >> >> Of course this big of a change may take a little time to settle out, >> so please let us know if you see build or run time issues. >> Suggestions are welcome too. >> >> >> >> Cheers from jolly old England, >> >> Steve >> >> >> >> >> >> [1] http://www.commontk.org/index.php/CTK-Hackfest-Nov-2013 >> >> >> >> [2] >> http://www.commontk.org/index.php/CTK-Hackfest-May-2013#DICOM_Database >> _and_Networking >> >> >> >> [3] http://na-mic.org/Bug/view.php?id=2828 >> >> >> >> [4] http://na-mic.org/Bug/view.php?id=3106 >> >> >> >> [5] http://na-mic.org/Bug/view.php?id=1838 >> >> >> >> [6] >> http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=226 >> 89 >> >> [7] >> http://www.slicer.org/slicerWiki/index.php/Documentation/4.3/Modules/D >> ICOM >> >> >> _______________________________________________ >> slicer-devel mailing list >> slicer-devel at bwh.harvard.edu >> http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel >> To unsubscribe: send email to >> slicer-devel-request at massmail.spl.harvard.edu >> with unsubscribe as the subject >> http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Devel >> opers/FAQ >> >> >> The information in this e-mail is intended only for the person to whom >> it is addressed. If you believe this e-mail was sent to you in error >> and the e-mail contains patient information, please contact the >> Partners Compliance HelpLine at http://www.partners.org/complianceline >> . If the e-mail was sent to you in error but does not contain patient >> information, please contact the sender and properly dispose of the >> e-mail. >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From javier.mazaira at alma3d.com Wed Jan 29 08:06:50 2014 From: javier.mazaira at alma3d.com (Javier Mazaira) Date: Wed, 29 Jan 2014 09:06:50 +0100 Subject: [Ctk-developers] Problems ctkErrorLogWidget and ctkErrorLogModel Message-ID: Hi, I need some help using ctkErrorLogWidget, I just want to create a function to add and remove entries from this widget, but it's being really hard. This is what I've got: *ctkErrorLogWidget* logWindow = new ctkErrorLogWidget();* *ctkErrorLogModel model;* // here I've created some test entries *model.addEntry( QDateTime(), QString("threadid"), level, QString("origin"), QString("text"));* *model.addEntry( QDateTime(), QString("threadida"), level, QString("origina"), QString("texta"));* *model.addEntry( QDateTime(), QString("threadidb"), level, QString("originb"), QString("textb"));* *model.addEntry( QDateTime(), QString("threadidc"), level, QString("originc"), QString("textc"));* *// here I set model as errorlogmodel of my logWindow* *logWindow->setErrorLogModel( &model );* *QObject::connect(logAction,SIGNAL(triggered()),logWindow,SLOT(show()));* so after signal "triggered" is launched, logwindow is showed in the screen but I don't see any entry. I thought that I just need to add a ctkErrorLogModel in my ctkErrorLogWidget to have a way to add entries on this widget, but it doesn't works, I hope someone can helps me. Thanks for all, Javier -------------- next part -------------- An HTML attachment was scrubbed... URL: From julien.finet at kitware.com Wed Jan 29 13:31:25 2014 From: julien.finet at kitware.com (Julien Finet) Date: Wed, 29 Jan 2014 08:31:25 -0500 Subject: [Ctk-developers] Problems ctkErrorLogWidget and ctkErrorLogModel In-Reply-To: References: Message-ID: Hi Javier, What is the value of level ? If level is ctkErrorLogLevel::None, then they won't be visible. Also, make sure that all the entries are visible (ctkErrorLogWidget::setAllEntriesVisible()). Hth, Julien. On Wed, Jan 29, 2014 at 3:06 AM, Javier Mazaira wrote: > Hi, > > I need some help using ctkErrorLogWidget, I just want to create a function > to add and remove entries from this widget, but it's being really hard. > This is what I've got: > > > *ctkErrorLogWidget* logWindow = new ctkErrorLogWidget();* > *ctkErrorLogModel model;* > > // here I've created some test entries > > *model.addEntry( QDateTime(), QString("threadid"), level, > QString("origin"), QString("text"));* > *model.addEntry( QDateTime(), QString("threadida"), level, > QString("origina"), QString("texta"));* > *model.addEntry( QDateTime(), QString("threadidb"), level, > QString("originb"), QString("textb"));* > *model.addEntry( QDateTime(), QString("threadidc"), level, > QString("originc"), QString("textc"));* > > *// here I set model as errorlogmodel of my logWindow* > *logWindow->setErrorLogModel( &model );* > > > *QObject::connect(logAction,SIGNAL(triggered()),logWindow,SLOT(show()));* > > so after signal "triggered" is launched, logwindow is showed in the screen > but I don't see any entry. I thought that I just need to add > a ctkErrorLogModel in my ctkErrorLogWidget to have a way to add entries on > this widget, but it doesn't works, I hope someone can helps me. > > Thanks for all, > Javier > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From javier.mazaira at alma3d.com Wed Jan 29 14:08:48 2014 From: javier.mazaira at alma3d.com (Javier Mazaira) Date: Wed, 29 Jan 2014 15:08:48 +0100 Subject: [Ctk-developers] Problems ctkErrorLogWidget and ctkErrorLogModel In-Reply-To: References: Message-ID: Hi Julien, Thank you so much for your help, as you told me, the reason was level's value and now it's working. Javier On Wed, Jan 29, 2014 at 2:31 PM, Julien Finet wrote: > Hi Javier, > > What is the value of level ? > If level is ctkErrorLogLevel::None, then they won't be visible. > Also, make sure that all the entries are visible > (ctkErrorLogWidget::setAllEntriesVisible()). > > Hth, > Julien. > > > On Wed, Jan 29, 2014 at 3:06 AM, Javier Mazaira > wrote: > >> Hi, >> >> I need some help using ctkErrorLogWidget, I just want to create a >> function to add and remove entries from this widget, but it's being really >> hard. This is what I've got: >> >> >> *ctkErrorLogWidget* logWindow = new ctkErrorLogWidget();* >> *ctkErrorLogModel model;* >> >> // here I've created some test entries >> >> *model.addEntry( QDateTime(), QString("threadid"), level, >> QString("origin"), QString("text"));* >> *model.addEntry( QDateTime(), QString("threadida"), level, >> QString("origina"), QString("texta"));* >> *model.addEntry( QDateTime(), QString("threadidb"), level, >> QString("originb"), QString("textb"));* >> *model.addEntry( QDateTime(), QString("threadidc"), level, >> QString("originc"), QString("textc"));* >> >> *// here I set model as errorlogmodel of my logWindow* >> *logWindow->setErrorLogModel( &model );* >> >> >> *QObject::connect(logAction,SIGNAL(triggered()),logWindow,SLOT(show()));* >> >> so after signal "triggered" is launched, logwindow is showed in the >> screen but I don't see any entry. I thought that I just need to add >> a ctkErrorLogModel in my ctkErrorLogWidget to have a way to add entries on >> this widget, but it doesn't works, I hope someone can helps me. >> >> Thanks for all, >> Javier >> >> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: