[Ctk-developers] Info level logging macro in VTK

Mon Dec 15 01:43:05 UTC 2014

Hi Folks,

To get the full picture, within CTK, we have the following classes:

* ctkErrorLogModel [1]:  Centralize messages captured by message handlers.

* ctkErrorLogWidget [2]: Present the messages from the model into a view

Message handlers:

* ctkErrorLogStatusMessageHandler [3]: Capture and log messages displayed
in the status bar

* ctkErrorLogStreamMessageHandler [4]: Capture and log messages "printed"
on std::cout and std::cerr

* ctkErrorLogQtMessageHandler [5]: Capture and log messages "printed" using
qWarning/qDebug/...

* ctkErrorLogFDMessageHandler [6]: Capture and log messages "printed" on
stdout and stderr file descriptor

* ctkITKErrorLogMessageHandler [7]: Capture and log messages "printed"
using ITK macros

* ctkVTKErrorLogMessageHandler [8]: Capture and log messages "printed"
using VTK macros

Thanks
Jc

[1]
https://github.com/commontk/CTK/blob/master/Libs/Widgets/ctkErrorLogModel.h

[2]
https://github.com/commontk/CTK/blob/master/Libs/Widgets/ctkErrorLogWidget.h

[3]
https://github.com/commontk/CTK/blob/master/Libs/Widgets/ctkErrorLogStatusMessageHandler.h

[4]
https://github.com/commontk/CTK/blob/master/Libs/Core/ctkErrorLogStreamMessageHandler.h

[5]
https://github.com/commontk/CTK/blob/master/Libs/Core/ctkErrorLogQtMessageHandler.h

[6]
https://github.com/commontk/CTK/blob/master/Libs/Core/ctkErrorLogFDMessageHandler.h

[7]
https://github.com/commontk/CTK/blob/master/Libs/ImageProcessing/ITK/Core/ctkITKErrorLogMessageHandler.h

[8]
https://github.com/commontk/CTK/blob/master/Libs/Visualization/VTK/Core/ctkVTKErrorLogMessageHandler.h

On Sat, Dec 13, 2014 at 5:41 PM, Steve Pieper <pieper at isomics.com> wrote:
>
> Hi Andras -
>
> I'm on record from previous discussions on the vtk developer list that I'd
> like to make vtk smaller (e.g. move vtkChemistry, GeoVis and similar things
> into their own add-on libraries [1]).  But on this one I actually agree
> with your argument that VTK really should have a provision for this rather
> than leaving it to each application to develop a custom solution.  Berk
> seems to have dug in his heels though, so maybe just add the feature to
> CTK?  Or leaving it in Slicer is okay by me too.
>
> -Steve
>
> [1]
> http://vtk.1045678.n5.nabble.com/Driving-away-your-existing-developers-td5728448.html
>
>
> On Sat, Dec 13, 2014 at 5:09 PM, Andras Lasso <lasso at queensu.ca> wrote:
>>
>>   The only reason for using macro is to be able to get the line number
>> and file name. The rest is handled by output window and logger classes.
>>
>> Andras
>>  ------------------------------
>> From: Bill Lorensen <bill.lorensen at gmail.com>
>> Sent: ‎2014-‎12-‎13 16:58
>> To: Andras Lasso <lasso at queensu.ca>
>> Cc: ctk-developers at commontk.org
>> Subject: Re: [Ctk-developers] Info level logging macro in VTK
>>
>>   Personally, I do not like macros. For this functionality I would
>> prefer a logging class like we have in ITK.
>>
>> Bill
>>
>>
>> On Sat, Dec 13, 2014 at 4:32 PM, Andras Lasso <lasso at queensu.ca> wrote:
>> > Hi all,
>> >
>> >
>> >
>> > We are having a discussion with VTK developers about the necessity for a
>> > vtkInfoMacro (or vtkGenericOutputMacro) in addition to vtkErrorMacro,
>> > vtkWarningMacro, and vtkDebugMacro in VTK [1] . The new macro would
>> offer a
>> > standard way of logging non-error messages from VTK-derived application
>> > classes, tests, and examples. For example, you would not need to
>> specify a
>> > separate application-specific LOG_INFO macro in your application for
>> logging
>> > non-error messages while using the VTK standard vtkErrorMacro and
>> > vtkWarningMacro for errors.
>> >
>> >
>> >
>> > The next step would be asking for moving the log message formatting
>> from the
>> > VTK logging macros to the vtkOutputWindow class. That would allow
>> getting
>> > rid of the ugly multi-line VTK error messages, because in a custom
>> > vtkOutputWindow class the application could format the fields (message,
>> line
>> > number, etc.) in any way or it could send the info to the application
>> logger
>> > (there would be no need to parse the VTK error messages anymore to
>> extract
>> > the fields).
>> >
>> >
>> >
>> > It would help the discussion on the VTK list a lot if we know the
>> opinion,
>> > needs of more application developers:
>> >
>> > * Do you find the current VTK error/warning/debug logging convenient for
>> > your application?
>> >
>> > * Would you use INFO level logging in VTK-based classes in your
>> application?
>> >
>> > * Would you like to have customizable formatting of VTK error/warning
>> > messages? (e.g., have compact, single-line messages; or be able to have
>> the
>> > message, line number, file name, etc. separately so that you can send
>> it to
>> > your application’s logger)
>> >
>> >
>> >
>> > Thanks in advance.
>> >
>> > Andras
>> >
>> >
>> >
>> > [1]
>> >
>> http://public.kitware.com/pipermail/vtk-developers/2014-December/031102.html
>> >
>> >
>> > _______________________________________________
>> > Ctk-developers mailing list
>> > Ctk-developers at public.kitware.com
>> > http://public.kitware.com/mailman/listinfo/ctk-developers
>> >
>>
>>
>>
>> --
>> Unpaid intern in BillsBasement at noware dot com
>>
>> _______________________________________________
>> Ctk-developers mailing list
>> Ctk-developers at public.kitware.com
>> http://public.kitware.com/mailman/listinfo/ctk-developers
>>
>>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at public.kitware.com
> http://public.kitware.com/mailman/listinfo/ctk-developers
>
>

-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20141214/ae4a2aad/attachment.htm>