From e.coto at sheffield.ac.uk Tue Oct 1 11:33:03 2013 From: e.coto at sheffield.ac.uk (Ernesto Coto) Date: Tue, 1 Oct 2013 12:33:03 +0100 Subject: [Ctk-developers] participation to the CTK hackfest @ London Message-ID: Hi all, I am Ernesto Coto and I joined CISTIB (Center for Computational Imaging & Simulation Technologies in Biomedicine) at The University of Sheffield ( http://www.shef.ac.uk/) a few months ago. I have been working on medical image segmentation and visualization for several years at the Computer Graphics Center (http://ccg.ciens.ucv.ve/) of the Central University of Venezuela (http://www.ucv.ve/). At CISTIB I am part of the Software Development Team and the main CISTIB developer for the VPH-Share project (http://vph-share.eu/). As CISTIB has been supporting CTK for some time, I would like to continue this support by participating in the next CTK hackfest @ London. Please let me know if I Am still on time to participate. Regards, *Ernesto Coto* Scientific Software Developer Center for Computational Imaging & Simulation Technologies in Biomedicine (CISTIB) INSIGNEO Institute for In silico Medicine The University of Sheffield Room B85 - Portobello Centre Pitt St. Sheffield S1 4ET United Kingdom T: +44 (0) 114 222 0166 E: e.coto at sheffield.ac.uk -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Tue Oct 1 13:22:39 2013 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Tue, 1 Oct 2013 09:22:39 -0400 Subject: [Ctk-developers] participation to the CTK hackfest @ London In-Reply-To: References: Message-ID: Hi Ernesto, Considering the maximum number of participants has not been reached [1], you could definitively attend :) Is there any aspect of CTK you would like to work on during the hackfest ? How are you currently using (or will be using) CTK in your project ? Thanks Jc [1] http://www.commontk.org/index.php/CTK-Hackfest-Nov-2013 On Tue, Oct 1, 2013 at 7:33 AM, Ernesto Coto wrote: > Hi all, > > I am Ernesto Coto and I joined CISTIB (Center for Computational Imaging & > Simulation Technologies in Biomedicine) at The University of Sheffield ( > http://www.shef.ac.uk/) a few months ago. > > I have been working on medical image segmentation and visualization for > several years at the Computer Graphics Center (http://ccg.ciens.ucv.ve/) > of the Central University of Venezuela (http://www.ucv.ve/). > > At CISTIB I am part of the Software Development Team and the main CISTIB > developer for the VPH-Share project (http://vph-share.eu/). > > As CISTIB has been supporting CTK for some time, I would like to continue > this support by participating in the next CTK hackfest @ London. Please let > me know if I Am still on time to participate. > > Regards, > > *Ernesto Coto* > Scientific Software Developer > Center for Computational Imaging & Simulation Technologies in Biomedicine > (CISTIB) > INSIGNEO Institute for In silico Medicine > The University of Sheffield > Room B85 - Portobello Centre > Pitt St. Sheffield S1 4ET > United Kingdom > T: +44 (0) 114 222 0166 > E: e.coto at sheffield.ac.uk > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From m.clarkson at ucl.ac.uk Tue Oct 1 18:57:21 2013 From: m.clarkson at ucl.ac.uk (Clarkson, Matt) Date: Tue, 1 Oct 2013 18:57:21 +0000 Subject: [Ctk-developers] participation to the CTK hackfest @ London In-Reply-To: References: Message-ID: Hi Ernesto, I second what JC said. Sure you can come, and we would love to hear more about how your project (s) are or intend to use CTK. The most important thing for the hackfest is to turn up with an idea of what to work on, so you can get started on day 1. Thanks Matt > > Hi all, > > I am Ernesto Coto and I joined CISTIB (Center for Computational Imaging & > Simulation Technologies in Biomedicine) at The University of Sheffield ( > http://www.shef.ac.uk/) a few months ago. > > I have been working on medical image segmentation and visualization for > several years at the Computer Graphics Center (http://ccg.ciens.ucv.ve/) of > the Central University of Venezuela (http://www.ucv.ve/). > > At CISTIB I am part of the Software Development Team and the main CISTIB > developer for the VPH-Share project (http://vph-share.eu/). > > As CISTIB has been supporting CTK for some time, I would like to continue > this support by participating in the next CTK hackfest @ London. Please let > me know if I Am still on time to participate. > > Regards, > > *Ernesto Coto* > Scientific Software Developer > Center for Computational Imaging & Simulation Technologies in Biomedicine > (CISTIB) > INSIGNEO Institute for In silico Medicine > The University of Sheffield > Room B85 - Portobello Centre > Pitt St. Sheffield S1 4ET > United Kingdom > T: +44 (0) 114 222 0166 > E: e.coto at sheffield.ac.uk > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: > > ------------------------------ > > Message: 2 > Date: Tue, 1 Oct 2013 09:22:39 -0400 > From: Jean-Christophe Fillion-Robin > Subject: Re: [Ctk-developers] participation to the CTK hackfest @ > London > To: Ernesto Coto > Cc: "ctk-developers at commontk.org" > Message-ID: > > Content-Type: text/plain; charset="iso-8859-1" > > Hi Ernesto, > > Considering the maximum number of participants has not been reached [1], > you could definitively attend :) > > Is there any aspect of CTK you would like to work on during the hackfest ? > How are you currently using (or will be using) CTK in your project ? > > Thanks > Jc > > [1] http://www.commontk.org/index.php/CTK-Hackfest-Nov-2013 > > > On Tue, Oct 1, 2013 at 7:33 AM, Ernesto Coto wrote: > >> Hi all, >> >> I am Ernesto Coto and I joined CISTIB (Center for Computational Imaging & >> Simulation Technologies in Biomedicine) at The University of Sheffield ( >> http://www.shef.ac.uk/) a few months ago. >> >> I have been working on medical image segmentation and visualization for >> several years at the Computer Graphics Center (http://ccg.ciens.ucv.ve/) >> of the Central University of Venezuela (http://www.ucv.ve/). >> >> At CISTIB I am part of the Software Development Team and the main CISTIB >> developer for the VPH-Share project (http://vph-share.eu/). >> >> As CISTIB has been supporting CTK for some time, I would like to continue >> this support by participating in the next CTK hackfest @ London. Please let >> me know if I Am still on time to participate. >> >> Regards, >> >> *Ernesto Coto* >> Scientific Software Developer >> Center for Computational Imaging & Simulation Technologies in Biomedicine >> (CISTIB) >> INSIGNEO Institute for In silico Medicine >> The University of Sheffield >> Room B85 - Portobello Centre >> Pitt St. Sheffield S1 4ET >> United Kingdom >> T: +44 (0) 114 222 0166 >> E: e.coto at sheffield.ac.uk >> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> >> > > > -- > +1 919 869 8849 > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: > > ------------------------------ > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > > End of Ctk-developers Digest, Vol 50, Issue 1 > ********************************************* > From e.coto at sheffield.ac.uk Wed Oct 2 09:00:15 2013 From: e.coto at sheffield.ac.uk (Ernesto Coto) Date: Wed, 2 Oct 2013 10:00:15 +0100 Subject: [Ctk-developers] participation to the CTK hackfest @ London In-Reply-To: References: Message-ID: Dear Jean, The relationship between CISTIB's GIMIAS and CTK resides on the command-line interfaces, so I would like to focus on that. However, I'm currently exploring other options, if I find something more interesting I will let you know in a couple of weeks, before the hackfest. Cheers, *Ernesto Coto* Scientific Software Developer Center for Computational Imaging & Simulation Technologies in Biomedicine (CISTIB) INSIGNEO Institute for In silico Medicine The University of Sheffield Room B85 - Portobello Centre Pitt St. Sheffield S1 4ET United Kingdom T: +44 (0) 114 222 0166 E: e.coto at sheffield.ac.uk On 1 October 2013 14:22, Jean-Christophe Fillion-Robin < jchris.fillionr at kitware.com> wrote: > Hi Ernesto, > > Considering the maximum number of participants has not been reached [1], > you could definitively attend :) > > Is there any aspect of CTK you would like to work on during the hackfest ? > How are you currently using (or will be using) CTK in your project ? > > Thanks > Jc > > [1] http://www.commontk.org/index.php/CTK-Hackfest-Nov-2013 > > > On Tue, Oct 1, 2013 at 7:33 AM, Ernesto Coto wrote: > >> Hi all, >> >> I am Ernesto Coto and I joined CISTIB (Center for Computational Imaging & >> Simulation Technologies in Biomedicine) at The University of Sheffield ( >> http://www.shef.ac.uk/) a few months ago. >> >> I have been working on medical image segmentation and visualization for >> several years at the Computer Graphics Center (http://ccg.ciens.ucv.ve/) >> of the Central University of Venezuela (http://www.ucv.ve/). >> >> At CISTIB I am part of the Software Development Team and the main CISTIB >> developer for the VPH-Share project (http://vph-share.eu/). >> >> As CISTIB has been supporting CTK for some time, I would like to continue >> this support by participating in the next CTK hackfest @ London. Please let >> me know if I Am still on time to participate. >> >> Regards, >> >> *Ernesto Coto* >> Scientific Software Developer >> Center for Computational Imaging & Simulation Technologies in Biomedicine >> (CISTIB) >> INSIGNEO Institute for In silico Medicine >> The University of Sheffield >> Room B85 - Portobello Centre >> Pitt St. Sheffield S1 4ET >> United Kingdom >> T: +44 (0) 114 222 0166 >> E: e.coto at sheffield.ac.uk >> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> >> > > > -- > +1 919 869 8849 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From csaba.pinter at queensu.ca Wed Oct 2 14:18:58 2013 From: csaba.pinter at queensu.ca (Csaba Pinter) Date: Wed, 2 Oct 2013 14:18:58 +0000 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly Message-ID: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> Hi all, I'm trying to build CTK separately, but I have problems with linking DCMTK. The way I build CTK: - Turn on CTK_BUILD_ALL - Turn on CTK_ENABLE_DICOM (I need this as I want to merge and test my changes in the CTK/Core/DICOM project) - Set the qmake executable - Configure - CMake complains about python paths, I set those manually - Configure, Generate - Build superbuild Then DCMTK is downloaded and built by the superbuild, but later on, CTK projects find a completely different DCMTK directory (in my Slicer nightly build directory). I tried to manually add the DCMTK directory to CMake, but this variable does not exist in the superbuild (it is also not passed down), and setting it to the inner CTK project doesn't work. Basically no matter what I do, the DCMTK path is set to whatever find_project finds. This is what I found in CTKConfig.cmake: # Update CMake module path so that calling "find_package(DCMTK)" works as expected # after calling "find_package(CTK)" # Ideally projects like DCMTK or PythonQt should provide both "Config" and "Use" files. set(CMAKE_MODULE_PATH ${CTK_CMAKE_UTILITIES_DIR} ${CMAKE_MODULE_PATH} ) Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there is no chance DCMTK is found correctly. Can someone please help with this? Thanks a lot, csaba ________________________________ Csaba Pinter Medical Software Systems Engineer Laboratory for Percutanous Surgery School of Computing Queen's University Kingston, ON, Canada Email: csaba.pinter at queensu.ca Web: http://perk.cs.queensu.ca -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Wed Oct 2 15:38:45 2013 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Wed, 2 Oct 2013 11:38:45 -0400 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: Hi Csaba, In CTKConfig, the variable "CMAKE_MODULE_PATH" is a CMake global variable that is empty by default. On the other hand "CTK_CMAKE_UTILITIES_DIR" should not be empty as illustrated below: $ cat ../CTKConfig.cmake | ack -i "set\(CTK_CMAKE_UTILITIES_DIR" SET(CTK_CMAKE_UTILITIES_DIR "/home/jchris/Projects/CTK/Utilities/CMake") Otherwise, you will find below the result of my experiment. When configured, CTK found the expected DCMTK. On Ubuntu 13.04 using CMake 2.8.11.2, after installing the package "python2.7-dev" doing so the following works. Note that I didn't enable CTK_ENABLE_ALL since I didn't the build system to build VTK or ITK components. Instead, I passed the following options: -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES $ git clone git at github.com:commontk/CTK $ mkdir CTK-Debug $ cd CTK-Debug $ cmake -DQT_QMAKE_EXECUTABLE:FILEPATH=/home/jchris/Support/QtSDK-1.2.1/Desktop/Qt/4.8.1/gcc/bin/qmake -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES:BOOL=ON ../CTK [...] -- Enabling [CTK_LIB_DICOM/Core] because of [ CTK_ENABLE_DICOM:1 OR ( CTK_ENABLE_DICOMApplicationHosting:0 AND CTK_BUILD_EXAMPLES:1 )] evaluates to True -- Enabling [CTK_APP_ctkDICOM] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOM2] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMIndexer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMDemoSCU] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQuery] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQueryRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkCommandLineModuleExplorer] because of [ CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMObjectViewer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkSimplePythonShell] because of [ CTK_ENABLE_Python_Wrapping:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep.txt -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep-withext.txt -- Enabling option [CTK_LIB_DICOM/Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtGui] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtWebKit] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/LocalProcess] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/FunctionPointer] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Core] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_Scripting/Python/Widgets] required by [ctkSimplePythonShell] -- Enabling option [CTK_LIB_Scripting/Python/Core] required by [ctkSimplePythonShell] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/Project.xml -- Found Git: /usr/bin/git (found version "1.8.1.2") -- Configuring done -- Generating done -- Build files have been written to: /home/jchris/Projects/CTK-Debug $ make -j6 [...] [ 90%] Performing configure step for 'CTK-Configure' [...] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/Project.xml -- Trying to find DCMTK expecting DCMTKConfig.cmake -- Trying to find DCMTK expecting DCMTKConfig.cmake - failed -- Trying to find DCMTK relying on FindDCMTK.cmake -- Looking for include file pthread.h -- Looking fothe r include file pthread.h - found -- Looking for pthread_create -- Looking for pthread_create - not found -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- Found DCMTK: /home/jchris/Projects/CTK-Debug/CMakeExternals/Install/include/dcmtk/config -- Trying to find DCMTK relying on FindDCMTK.cmake - ok -- CTKCore: BFD support disabled -- Configuring done -- Generating done [...] -- Build files have been written to: /home/jchris/Projects/CTK-Debug/CTK-build [...] [100%] Built target CTKWidgetsCppTests [100%] Built target CTK-build $ cd CTK-build $ $ cat CMakeCache.txt | ack DCMTK_DIR\:PATH DCMTK_DIR:PATH=/home/jchris/Projects/CTK-Debug/CMakeExternals/Install Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is explained by the fact the official DCMTK didn't integrate yet our latest and greatest contribution [1] Hth Jc [1] https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 On Wed, Oct 2, 2013 at 10:18 AM, Csaba Pinter wrote: > Hi all,**** > > ** ** > > I'm trying to build CTK separately, but I have problems with linking DCMTK. > **** > > ** ** > > The way I build CTK:**** > > **- **Turn on CTK_BUILD_ALL**** > > **- **Turn on CTK_ENABLE_DICOM (I need this as I want to merge > and test my changes in the CTK/Core/DICOM project)**** > > **- **Set the qmake executable**** > > **- **Configure**** > > **- **CMake complains about python paths, I set those manually*** > * > > **- **Configure, Generate**** > > **- **Build superbuild**** > > ** ** > > Then DCMTK is downloaded and built by the superbuild, but later on, CTK > projects find a completely different DCMTK directory (in my Slicer nightly > build directory). I tried to manually add the DCMTK directory to CMake, but > this variable does not exist in the superbuild (it is also not passed > down), and setting it to the inner CTK project doesn't work.**** > > ** ** > > Basically no matter what I do, the DCMTK path is set to whatever > find_project finds. This is what I found in CTKConfig.cmake:**** > > # Update CMake module path so that calling "find_package(DCMTK)" works as > expected **** > > # after calling "find_package(CTK)"**** > > # Ideally projects like DCMTK or PythonQt should provide both "Config" and > "Use" files.**** > > set(CMAKE_MODULE_PATH**** > > ${CTK_CMAKE_UTILITIES_DIR}**** > > ${CMAKE_MODULE_PATH}**** > > )**** > > ** ** > > Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there > is no chance DCMTK is found correctly.**** > > ** ** > > Can someone please help with this?**** > > ** ** > > Thanks a lot,**** > > csaba**** > > ** ** > > ________________________________**** > > Csaba Pinter**** > > Medical Software Systems Engineer**** > > Laboratory for Percutanous Surgery**** > > School of Computing**** > > Queen?s University**** > > Kingston, ON, Canada**** > > Email: csaba.pinter at queensu.ca**** > > Web: http://perk.cs.queensu.ca**** > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From matt.mccormick at kitware.com Wed Oct 2 16:30:23 2013 From: matt.mccormick at kitware.com (Matt McCormick) Date: Wed, 2 Oct 2013 16:30:23 +0000 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: > > Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is > explained by the fact the official DCMTK didn't integrate yet our latest and > greatest contribution [1] > > [1] > https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 > Awesome! From csaba.pinter at queensu.ca Wed Oct 2 17:17:42 2013 From: csaba.pinter at queensu.ca (Csaba Pinter) Date: Wed, 2 Oct 2013 17:17:42 +0000 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: <04C6BCB5F77FFF449DAE728C597984555D1857@MP-DUP-MBX-01.AD.QUEENSU.CA> Hi Jc, Thanks for the quick answer. Unfortunately the fact that this works on Linux doesn't help me in my Windows environment. Right now I have a working copy that refuses to build because it finds an external DCMTK (from a Slicer release mode superbuild tree) every time. I could try injecting a DCMTK_DIR, but I guess it would rather be a workaround than a solution. Probably if CMAKE_MODULE_PATH contained the DCMTK directory that the superbuild downloads and builds, besides CTK_CMAKE_UTILITIES_DIR, then the right DCMTK directory would be found. If it's not clear, I would really appreciate if you could remote log. Probably you could find the source of the problem in no time. Thanks, csaba From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] Sent: October 2, 2013 11:39 To: Csaba Pinter Cc: CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, In CTKConfig, the variable "CMAKE_MODULE_PATH" is a CMake global variable that is empty by default. On the other hand "CTK_CMAKE_UTILITIES_DIR" should not be empty as illustrated below: $ cat ../CTKConfig.cmake | ack -i "set\(CTK_CMAKE_UTILITIES_DIR" SET(CTK_CMAKE_UTILITIES_DIR "/home/jchris/Projects/CTK/Utilities/CMake") Otherwise, you will find below the result of my experiment. When configured, CTK found the expected DCMTK. On Ubuntu 13.04 using CMake 2.8.11.2, after installing the package "python2.7-dev" doing so the following works. Note that I didn't enable CTK_ENABLE_ALL since I didn't the build system to build VTK or ITK components. Instead, I passed the following options: -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES $ git clone git at github.com:commontk/CTK $ mkdir CTK-Debug $ cd CTK-Debug $ cmake -DQT_QMAKE_EXECUTABLE:FILEPATH=/home/jchris/Support/QtSDK-1.2.1/Desktop/Qt/4.8.1/gcc/bin/qmake -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES:BOOL=ON ../CTK [...] -- Enabling [CTK_LIB_DICOM/Core] because of [ CTK_ENABLE_DICOM:1 OR ( CTK_ENABLE_DICOMApplicationHosting:0 AND CTK_BUILD_EXAMPLES:1 )] evaluates to True -- Enabling [CTK_APP_ctkDICOM] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOM2] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMIndexer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMDemoSCU] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQuery] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQueryRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkCommandLineModuleExplorer] because of [ CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMObjectViewer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkSimplePythonShell] because of [ CTK_ENABLE_Python_Wrapping:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep.txt -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep-withext.txt -- Enabling option [CTK_LIB_DICOM/Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtGui] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtWebKit] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/LocalProcess] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/FunctionPointer] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Core] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_Scripting/Python/Widgets] required by [ctkSimplePythonShell] -- Enabling option [CTK_LIB_Scripting/Python/Core] required by [ctkSimplePythonShell] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/Project.xml -- Found Git: /usr/bin/git (found version "1.8.1.2") -- Configuring done -- Generating done -- Build files have been written to: /home/jchris/Projects/CTK-Debug $ make -j6 [...] [ 90%] Performing configure step for 'CTK-Configure' [...] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/Project.xml -- Trying to find DCMTK expecting DCMTKConfig.cmake -- Trying to find DCMTK expecting DCMTKConfig.cmake - failed -- Trying to find DCMTK relying on FindDCMTK.cmake -- Looking for include file pthread.h -- Looking fothe r include file pthread.h - found -- Looking for pthread_create -- Looking for pthread_create - not found -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- Found DCMTK: /home/jchris/Projects/CTK-Debug/CMakeExternals/Install/include/dcmtk/config -- Trying to find DCMTK relying on FindDCMTK.cmake - ok -- CTKCore: BFD support disabled -- Configuring done -- Generating done [...] -- Build files have been written to: /home/jchris/Projects/CTK-Debug/CTK-build [...] [100%] Built target CTKWidgetsCppTests [100%] Built target CTK-build $ cd CTK-build $ $ cat CMakeCache.txt | ack DCMTK_DIR\:PATH DCMTK_DIR:PATH=/home/jchris/Projects/CTK-Debug/CMakeExternals/Install Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is explained by the fact the official DCMTK didn't integrate yet our latest and greatest contribution [1] Hth Jc [1] https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 On Wed, Oct 2, 2013 at 10:18 AM, Csaba Pinter > wrote: Hi all, I'm trying to build CTK separately, but I have problems with linking DCMTK. The way I build CTK: - Turn on CTK_BUILD_ALL - Turn on CTK_ENABLE_DICOM (I need this as I want to merge and test my changes in the CTK/Core/DICOM project) - Set the qmake executable - Configure - CMake complains about python paths, I set those manually - Configure, Generate - Build superbuild Then DCMTK is downloaded and built by the superbuild, but later on, CTK projects find a completely different DCMTK directory (in my Slicer nightly build directory). I tried to manually add the DCMTK directory to CMake, but this variable does not exist in the superbuild (it is also not passed down), and setting it to the inner CTK project doesn't work. Basically no matter what I do, the DCMTK path is set to whatever find_project finds. This is what I found in CTKConfig.cmake: # Update CMake module path so that calling "find_package(DCMTK)" works as expected # after calling "find_package(CTK)" # Ideally projects like DCMTK or PythonQt should provide both "Config" and "Use" files. set(CMAKE_MODULE_PATH ${CTK_CMAKE_UTILITIES_DIR} ${CMAKE_MODULE_PATH} ) Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there is no chance DCMTK is found correctly. Can someone please help with this? Thanks a lot, csaba ________________________________ Csaba Pinter Medical Software Systems Engineer Laboratory for Percutanous Surgery School of Computing Queen's University Kingston, ON, Canada Email: csaba.pinter at queensu.ca Web: http://perk.cs.queensu.ca _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Fri Oct 4 16:07:05 2013 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 4 Oct 2013 12:07:05 -0400 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: Hi Csaba, Andras, Within the file FindDCMTK.cmake [1] provided by CTK, where would you suggest to add the NO_CMAKE_BUILDS_PATH ? Let's also note that the FindDCMTK.cmake provided by ITK would have to patched also ... If you can reproduce the problem, with a combination of clearing cache + adding some "message()" statement, you should be able to find out or confirm what is the source of the problem. Jc [1] https://github.com/commontk/CTK/blob/master/Utilities/CMake/FindDCMTK.cmake On Wed, Oct 2, 2013 at 1:42 PM, Andras Lasso wrote: > I have this annoying issue during Slicer builds as well: my nightly > slicer builds usually break after a few days because after I configure > other projects in CMake CTK finds DCMTK of another project instead of its > own.**** > > ** ** > > It may be due to the find_package path finding rule 5: ?Search project > build trees recently configured in a CMake GUI. This can be skipped if > NO_CMAKE_BUILDS_PATH is passed. It is intended for the case when a user is > building multiple dependent projects one after another.? ( > http://www.cmake.org/cmake/help/v2.8.10/ctest.html). Probably CTK should > rely on rules 1-4 or disable rule 5 ? or it may be possible that something > else goes wrong and that?s why the rule 5 kicks in.**** > > ** ** > > Andras**** > > ** ** > > ** ** > > *From:* ctk-developers-bounces at commontk.org [mailto: > ctk-developers-bounces at commontk.org] *On Behalf Of *Jean-Christophe > Fillion-Robin > *Sent:* Wednesday, October 02, 2013 11:39 AM > > *To:* Csaba Pinter > *Cc:* CTK mailing list > *Subject:* Re: [Ctk-developers] DCMTK_DIR is found incorrectly**** > > ** ** > > Hi Csaba, > > **** > > In CTKConfig, the variable "CMAKE_MODULE_PATH" is a CMake global variable > that is empty by default. On the other hand "CTK_CMAKE_UTILITIES_DIR" > should not be empty as illustrated below: > > $ cat ../CTKConfig.cmake | ack -i "set\(CTK_CMAKE_UTILITIES_DIR" > SET(CTK_CMAKE_UTILITIES_DIR "/home/jchris/Projects/CTK/Utilities/CMake")** > ** > > ** ** > > ** ** > > Otherwise, you will find below the result of my experiment. When > configured, CTK found the expected DCMTK. > > > On Ubuntu 13.04 using CMake 2.8.11.2, after installing the package > "python2.7-dev" doing so the following works.**** > > Note that I didn't enable CTK_ENABLE_ALL since I didn't the build system > to build VTK or ITK components. Instead, I passed the following options: > -DCTK_ENABLE_Python_Wrapping:BOOL=ON > -DCTK_ENABLE_DICOM:BOOL=ON > -DCTK_BUILD_EXAMPLES**** > > ** ** > > $ git clone git at github.com:commontk/CTK**** > > $ mkdir CTK-Debug**** > > $ cd CTK-Debug**** > > $ cmake > -DQT_QMAKE_EXECUTABLE:FILEPATH=/home/jchris/Support/QtSDK-1.2.1/Desktop/Qt/4.8.1/gcc/bin/qmake > -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON > -DCTK_BUILD_EXAMPLES:BOOL=ON ../CTK > [...] > -- Enabling [CTK_LIB_DICOM/Core] because of [ CTK_ENABLE_DICOM:1 OR ( > CTK_ENABLE_DICOMApplicationHosting:0 AND CTK_BUILD_EXAMPLES:1 )] evaluates > to True > -- Enabling [CTK_APP_ctkDICOM] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOM2] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMIndexer] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMDemoSCU] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMQuery] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMRetrieve] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMQueryRetrieve] because of [ > CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkCommandLineModuleExplorer] because of [ > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMObjectViewer] because of [ CTK_ENABLE_DICOM:1 > AND CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkSimplePythonShell] because of [ > CTK_ENABLE_Python_Wrapping:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True > -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep.txt > -- Generated: > /home/jchris/Projects/CTK-Debug/DGraphInput-alldep-withext.txt > -- Enabling option [CTK_LIB_DICOM/Widgets] required by [ctkDICOM] > -- Enabling option [CTK_LIB_Widgets] required by [ctkDICOM] > -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtGui] required by > [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtWebKit] required > by [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Backend/LocalProcess] > required by [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Backend/FunctionPointer] > required by [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Core] required by > [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_Scripting/Python/Widgets] required by > [ctkSimplePythonShell] > -- Enabling option [CTK_LIB_Scripting/Python/Core] required by > [ctkSimplePythonShell] > -- Found PythonInterp: /usr/bin/python (found version "2.7.4") > -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found > version "2.7.4") > -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput.txt > -- Generated: /home/jchris/Projects/CTK-Debug/Project.xml > -- Found Git: /usr/bin/git (found version "1.8.1.2") > -- Configuring done > -- Generating done > -- Build files have been written to: /home/jchris/Projects/CTK-Debug > > > **** > > $ make -j6 > [...] > [ 90%] Performing configure step for 'CTK-Configure' > [...] > -- Found PythonInterp: /usr/bin/python (found version "2.7.4") > -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found > version "2.7.4") > -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/DGraphInput.txt > -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/Project.xml > -- Trying to find DCMTK expecting DCMTKConfig.cmake > -- Trying to find DCMTK expecting DCMTKConfig.cmake - failed > -- Trying to find DCMTK relying on FindDCMTK.cmake > -- Looking for include file pthread.h > -- Looking fothe r include file pthread.h - found > -- Looking for pthread_create > -- Looking for pthread_create - not found > -- Looking for pthread_create in pthreads > -- Looking for pthread_create in pthreads - not found > -- Looking for pthread_create in pthread > -- Looking for pthread_create in pthread - found > -- Found Threads: TRUE > -- Found DCMTK: > /home/jchris/Projects/CTK-Debug/CMakeExternals/Install/include/dcmtk/config > > -- Trying to find DCMTK relying on FindDCMTK.cmake - ok > -- CTKCore: BFD support disabled > -- Configuring done > -- Generating done > [...] > -- Build files have been written to: > /home/jchris/Projects/CTK-Debug/CTK-build > > [...] > [100%] Built target CTKWidgetsCppTests > [100%] Built target CTK-build**** > > > > **** > > $ cd CTK-build > $ $ cat CMakeCache.txt | ack DCMTK_DIR\:PATH > DCMTK_DIR:PATH=/home/jchris/Projects/CTK-Debug/CMakeExternals/Install > > > > > **** > > Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is > explained by the fact the official DCMTK didn't integrate yet our latest > and greatest contribution [1] > > **** > > Hth**** > > Jc**** > > > [1] > https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 > **** > > ** ** > > ** ** > > ** ** > > On Wed, Oct 2, 2013 at 10:18 AM, Csaba Pinter > wrote:**** > > Hi all,**** > > **** > > I'm trying to build CTK separately, but I have problems with linking DCMTK. > **** > > **** > > The way I build CTK:**** > > - Turn on CTK_BUILD_ALL**** > > - Turn on CTK_ENABLE_DICOM (I need this as I want to merge and > test my changes in the CTK/Core/DICOM project)**** > > - Set the qmake executable**** > > - Configure**** > > - CMake complains about python paths, I set those manually**** > > - Configure, Generate**** > > - Build superbuild**** > > **** > > Then DCMTK is downloaded and built by the superbuild, but later on, CTK > projects find a completely different DCMTK directory (in my Slicer nightly > build directory). I tried to manually add the DCMTK directory to CMake, but > this variable does not exist in the superbuild (it is also not passed > down), and setting it to the inner CTK project doesn't work.**** > > **** > > Basically no matter what I do, the DCMTK path is set to whatever > find_project finds. This is what I found in CTKConfig.cmake:**** > > # Update CMake module path so that calling "find_package(DCMTK)" works as > expected **** > > # after calling "find_package(CTK)"**** > > # Ideally projects like DCMTK or PythonQt should provide both "Config" and > "Use" files.**** > > set(CMAKE_MODULE_PATH**** > > ${CTK_CMAKE_UTILITIES_DIR}**** > > ${CMAKE_MODULE_PATH}**** > > )**** > > **** > > Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there > is no chance DCMTK is found correctly.**** > > **** > > Can someone please help with this?**** > > **** > > Thanks a lot,**** > > csaba**** > > **** > > ________________________________**** > > Csaba Pinter**** > > Medical Software Systems Engineer**** > > Laboratory for Percutanous Surgery**** > > School of Computing**** > > Queen?s University**** > > Kingston, ON, Canada**** > > Email: csaba.pinter at queensu.ca**** > > Web: http://perk.cs.queensu.ca**** > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers**** > > > > > -- > +1 919 869 8849**** > -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Fri Oct 4 16:09:01 2013 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 4 Oct 2013 12:09:01 -0400 Subject: [Ctk-developers] participation to the CTK hackfest @ London In-Reply-To: References: Message-ID: Hi Ernesto, Sounds great. The CLI infrastructure is been developer extensively and would welcome some help. Would be great if you could come up with one or two topics/issues you would like to address. Thanks Jc On Wed, Oct 2, 2013 at 5:00 AM, Ernesto Coto wrote: > Dear Jean, > > The relationship between CISTIB's GIMIAS and CTK resides on the > command-line interfaces, so I would like to focus on that. > > However, I'm currently exploring other options, if I find something more > interesting I will let you know in a couple of weeks, before the hackfest. > > Cheers, > > *Ernesto Coto* > Scientific Software Developer > Center for Computational Imaging & Simulation Technologies in Biomedicine > (CISTIB) > INSIGNEO Institute for In silico Medicine > The University of Sheffield > Room B85 - Portobello Centre > Pitt St. Sheffield S1 4ET > United Kingdom > T: +44 (0) 114 222 0166 > E: e.coto at sheffield.ac.uk > > > On 1 October 2013 14:22, Jean-Christophe Fillion-Robin < > jchris.fillionr at kitware.com> wrote: > >> Hi Ernesto, >> >> Considering the maximum number of participants has not been reached [1], >> you could definitively attend :) >> >> Is there any aspect of CTK you would like to work on during the hackfest >> ? How are you currently using (or will be using) CTK in your project ? >> >> Thanks >> Jc >> >> [1] http://www.commontk.org/index.php/CTK-Hackfest-Nov-2013 >> >> >> On Tue, Oct 1, 2013 at 7:33 AM, Ernesto Coto wrote: >> >>> Hi all, >>> >>> I am Ernesto Coto and I joined CISTIB (Center for Computational Imaging >>> & Simulation Technologies in Biomedicine) at The University of Sheffield ( >>> http://www.shef.ac.uk/) a few months ago. >>> >>> I have been working on medical image segmentation and visualization for >>> several years at the Computer Graphics Center (http://ccg.ciens.ucv.ve/) >>> of the Central University of Venezuela (http://www.ucv.ve/). >>> >>> At CISTIB I am part of the Software Development Team and the main CISTIB >>> developer for the VPH-Share project (http://vph-share.eu/). >>> >>> As CISTIB has been supporting CTK for some time, I would like to >>> continue this support by participating in the next CTK hackfest @ London. >>> Please let me know if I Am still on time to participate. >>> >>> Regards, >>> >>> *Ernesto Coto* >>> Scientific Software Developer >>> Center for Computational Imaging & Simulation Technologies in >>> Biomedicine (CISTIB) >>> INSIGNEO Institute for In silico Medicine >>> The University of Sheffield >>> Room B85 - Portobello Centre >>> Pitt St. Sheffield S1 4ET >>> United Kingdom >>> T: +44 (0) 114 222 0166 >>> E: e.coto at sheffield.ac.uk >>> >>> _______________________________________________ >>> Ctk-developers mailing list >>> Ctk-developers at commontk.org >>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>> >>> >> >> >> -- >> +1 919 869 8849 >> > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From csaba.pinter at queensu.ca Fri Oct 4 21:39:58 2013 From: csaba.pinter at queensu.ca (Csaba Pinter) Date: Fri, 4 Oct 2013 21:39:58 +0000 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: <04C6BCB5F77FFF449DAE728C597984555D3EE2@MP-DUP-MBX-01.AD.QUEENSU.CA> Hi Jc, I tried building CTK in many ways, but the result is always the same, so the problem is completely reproducible, at least on my computer (I haven't tried it elsewhere yet, but I plan to). As we have been struggling with this issue for quite a while, but haven't been able to consistently reproduce it, this is a great opportunity to fix it once and for all. I did some digging and this is what I found: - FindDCMTK.cmake finds DCMTKConfig.cmake, but it is in the incorrect directory that is used later (in one of my slicer builds) - The reason why the DCMTK downloaded by the superbuild is not found is most probably that it is a version that doesn't have DCMTKConfig.cmake (as you described earlier) - The same thing (finding the wrong DCMTK) happens if I add NO_CMAKE_BUILDS_PATH to the find_package call in FindDCMTK.cmake Now I don't have any idea how to get the superbuild to use its own DCMTK. Also even if I can do a workaround and have a good build of CTK on my machine, this is an issue that other people who want to build CTK on Windows while already having a Slicer build have to face. Cheers, csaba From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] Sent: October 4, 2013 12:07 To: Andras Lasso Cc: Csaba Pinter; CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, Andras, Within the file FindDCMTK.cmake [1] provided by CTK, where would you suggest to add the NO_CMAKE_BUILDS_PATH ? Let's also note that the FindDCMTK.cmake provided by ITK would have to patched also ... If you can reproduce the problem, with a combination of clearing cache + adding some "message()" statement, you should be able to find out or confirm what is the source of the problem. Jc [1] https://github.com/commontk/CTK/blob/master/Utilities/CMake/FindDCMTK.cmake On Wed, Oct 2, 2013 at 1:42 PM, Andras Lasso > wrote: I have this annoying issue during Slicer builds as well: my nightly slicer builds usually break after a few days because after I configure other projects in CMake CTK finds DCMTK of another project instead of its own. It may be due to the find_package path finding rule 5: "Search project build trees recently configured in a CMake GUI. This can be skipped if NO_CMAKE_BUILDS_PATH is passed. It is intended for the case when a user is building multiple dependent projects one after another." (http://www.cmake.org/cmake/help/v2.8.10/ctest.html). Probably CTK should rely on rules 1-4 or disable rule 5 - or it may be possible that something else goes wrong and that's why the rule 5 kicks in. Andras From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Jean-Christophe Fillion-Robin Sent: Wednesday, October 02, 2013 11:39 AM To: Csaba Pinter Cc: CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, In CTKConfig, the variable "CMAKE_MODULE_PATH" is a CMake global variable that is empty by default. On the other hand "CTK_CMAKE_UTILITIES_DIR" should not be empty as illustrated below: $ cat ../CTKConfig.cmake | ack -i "set\(CTK_CMAKE_UTILITIES_DIR" SET(CTK_CMAKE_UTILITIES_DIR "/home/jchris/Projects/CTK/Utilities/CMake") Otherwise, you will find below the result of my experiment. When configured, CTK found the expected DCMTK. On Ubuntu 13.04 using CMake 2.8.11.2, after installing the package "python2.7-dev" doing so the following works. Note that I didn't enable CTK_ENABLE_ALL since I didn't the build system to build VTK or ITK components. Instead, I passed the following options: -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES $ git clone git at github.com:commontk/CTK $ mkdir CTK-Debug $ cd CTK-Debug $ cmake -DQT_QMAKE_EXECUTABLE:FILEPATH=/home/jchris/Support/QtSDK-1.2.1/Desktop/Qt/4.8.1/gcc/bin/qmake -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES:BOOL=ON ../CTK [...] -- Enabling [CTK_LIB_DICOM/Core] because of [ CTK_ENABLE_DICOM:1 OR ( CTK_ENABLE_DICOMApplicationHosting:0 AND CTK_BUILD_EXAMPLES:1 )] evaluates to True -- Enabling [CTK_APP_ctkDICOM] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOM2] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMIndexer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMDemoSCU] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQuery] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQueryRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkCommandLineModuleExplorer] because of [ CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMObjectViewer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkSimplePythonShell] because of [ CTK_ENABLE_Python_Wrapping:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep.txt -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep-withext.txt -- Enabling option [CTK_LIB_DICOM/Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtGui] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtWebKit] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/LocalProcess] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/FunctionPointer] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Core] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_Scripting/Python/Widgets] required by [ctkSimplePythonShell] -- Enabling option [CTK_LIB_Scripting/Python/Core] required by [ctkSimplePythonShell] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/Project.xml -- Found Git: /usr/bin/git (found version "1.8.1.2") -- Configuring done -- Generating done -- Build files have been written to: /home/jchris/Projects/CTK-Debug $ make -j6 [...] [ 90%] Performing configure step for 'CTK-Configure' [...] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/Project.xml -- Trying to find DCMTK expecting DCMTKConfig.cmake -- Trying to find DCMTK expecting DCMTKConfig.cmake - failed -- Trying to find DCMTK relying on FindDCMTK.cmake -- Looking for include file pthread.h -- Looking fothe r include file pthread.h - found -- Looking for pthread_create -- Looking for pthread_create - not found -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- Found DCMTK: /home/jchris/Projects/CTK-Debug/CMakeExternals/Install/include/dcmtk/config -- Trying to find DCMTK relying on FindDCMTK.cmake - ok -- CTKCore: BFD support disabled -- Configuring done -- Generating done [...] -- Build files have been written to: /home/jchris/Projects/CTK-Debug/CTK-build [...] [100%] Built target CTKWidgetsCppTests [100%] Built target CTK-build $ cd CTK-build $ $ cat CMakeCache.txt | ack DCMTK_DIR\:PATH DCMTK_DIR:PATH=/home/jchris/Projects/CTK-Debug/CMakeExternals/Install Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is explained by the fact the official DCMTK didn't integrate yet our latest and greatest contribution [1] Hth Jc [1] https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 On Wed, Oct 2, 2013 at 10:18 AM, Csaba Pinter > wrote: Hi all, I'm trying to build CTK separately, but I have problems with linking DCMTK. The way I build CTK: - Turn on CTK_BUILD_ALL - Turn on CTK_ENABLE_DICOM (I need this as I want to merge and test my changes in the CTK/Core/DICOM project) - Set the qmake executable - Configure - CMake complains about python paths, I set those manually - Configure, Generate - Build superbuild Then DCMTK is downloaded and built by the superbuild, but later on, CTK projects find a completely different DCMTK directory (in my Slicer nightly build directory). I tried to manually add the DCMTK directory to CMake, but this variable does not exist in the superbuild (it is also not passed down), and setting it to the inner CTK project doesn't work. Basically no matter what I do, the DCMTK path is set to whatever find_project finds. This is what I found in CTKConfig.cmake: # Update CMake module path so that calling "find_package(DCMTK)" works as expected # after calling "find_package(CTK)" # Ideally projects like DCMTK or PythonQt should provide both "Config" and "Use" files. set(CMAKE_MODULE_PATH ${CTK_CMAKE_UTILITIES_DIR} ${CMAKE_MODULE_PATH} ) Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there is no chance DCMTK is found correctly. Can someone please help with this? Thanks a lot, csaba ________________________________ Csaba Pinter Medical Software Systems Engineer Laboratory for Percutanous Surgery School of Computing Queen's University Kingston, ON, Canada Email: csaba.pinter at queensu.ca Web: http://perk.cs.queensu.ca _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -- +1 919 869 8849 -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Fri Oct 4 22:34:15 2013 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 4 Oct 2013 18:34:15 -0400 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: <04C6BCB5F77FFF449DAE728C597984555D3EE2@MP-DUP-MBX-01.AD.QUEENSU.CA> References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555D3EE2@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: Hi Csaba, As illustrated in the enclosed screenshot, build tree can be exported into the CMake package registry. As some point, the DCMTK build tree has probably been exported [1][2][3]. Since when building CTK, it is expected that there are no DCMTKConfig.cmake available, the first should be failing. In your case, it seems not to be failing because it resolves to that previous build added to the registery. I would suggest to try adding the parameter "NO_DEFAULT_PATH" to the FindDCMTK.cmake module available in CTK. See [4] Hth Jc [1] http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:export [2] http://slicer-devel.65872.n3.nabble.com/Packaging-seems-to-work-again-tp4028121p4028134.html [3] https://www.assembla.com/spaces/slicerrt/tickets/244-dcmtk_dir-vs--dcmtkconfig-cmake?comment=267984263#comment:267984263 [4] https://github.com/commontk/CTK/blob/f64b68acd717dab060db41e8bee3f0f30df1a58f/Utilities/CMake/FindDCMTK.cmake#L42 On Fri, Oct 4, 2013 at 5:39 PM, Csaba Pinter wrote: > Hi Jc,**** > > ** ** > > I tried building CTK in many ways, but the result is always the same, so > the problem is completely reproducible, at least on my computer (I haven't > tried it elsewhere yet, but I plan to). As we have been struggling with > this issue for quite a while, but haven't been able to consistently > reproduce it, this is a great opportunity to fix it once and for all.**** > > ** ** > > I did some digging and this is what I found:**** > > **- **FindDCMTK.cmake finds DCMTKConfig.cmake, but it is in the > incorrect directory that is used later (in one of my slicer builds)**** > > **- **The reason why the DCMTK downloaded by the superbuild is > not found is most probably that it is a version that doesn't have > DCMTKConfig.cmake (as you described earlier)**** > > **- **The same thing (finding the wrong DCMTK) happens if I add > NO_CMAKE_BUILDS_PATH to the find_package call in FindDCMTK.cmake**** > > ** ** > > Now I don't have any idea how to get the superbuild to use its own DCMTK.* > *** > > Also even if I can do a workaround and have a good build of CTK on my > machine, this is an issue that other people who want to build CTK on > Windows while already having a Slicer build have to face.**** > > ** ** > > Cheers,**** > > csaba**** > > ** ** > > ** ** > > *From:* Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] > > *Sent:* October 4, 2013 12:07 > *To:* Andras Lasso > *Cc:* Csaba Pinter; CTK mailing list > > *Subject:* Re: [Ctk-developers] DCMTK_DIR is found incorrectly**** > > ** ** > > Hi Csaba, Andras, **** > > Within the file FindDCMTK.cmake [1] provided by CTK, where would you > suggest to add the NO_CMAKE_BUILDS_PATH ?**** > > Let's also note that the FindDCMTK.cmake provided by ITK would have to > patched also ... **** > > If you can reproduce the problem, with a combination of clearing cache + > adding some "message()" statement, you should be able to find out or > confirm what is the source of the problem.**** > > ** ** > > Jc**** > > > [1] > https://github.com/commontk/CTK/blob/master/Utilities/CMake/FindDCMTK.cmake > **** > > ** ** > > On Wed, Oct 2, 2013 at 1:42 PM, Andras Lasso wrote:**** > > I have this annoying issue during Slicer builds as well: my nightly slicer > builds usually break after a few days because after I configure other > projects in CMake CTK finds DCMTK of another project instead of its own.** > ** > > **** > > It may be due to the find_package path finding rule 5: ?Search project > build trees recently configured in a CMake GUI. This can be skipped if > NO_CMAKE_BUILDS_PATH is passed. It is intended for the case when a user is > building multiple dependent projects one after another.? ( > http://www.cmake.org/cmake/help/v2.8.10/ctest.html). Probably CTK should > rely on rules 1-4 or disable rule 5 ? or it may be possible that something > else goes wrong and that?s why the rule 5 kicks in.**** > > **** > > Andras**** > > **** > > **** > > *From:* ctk-developers-bounces at commontk.org [mailto: > ctk-developers-bounces at commontk.org] *On Behalf Of *Jean-Christophe > Fillion-Robin > *Sent:* Wednesday, October 02, 2013 11:39 AM**** > > > *To:* Csaba Pinter > *Cc:* CTK mailing list > *Subject:* Re: [Ctk-developers] DCMTK_DIR is found incorrectly**** > > **** > > Hi Csaba, **** > > In CTKConfig, the variable "CMAKE_MODULE_PATH" is a CMake global variable > that is empty by default. On the other hand "CTK_CMAKE_UTILITIES_DIR" > should not be empty as illustrated below: > > $ cat ../CTKConfig.cmake | ack -i "set\(CTK_CMAKE_UTILITIES_DIR" > SET(CTK_CMAKE_UTILITIES_DIR "/home/jchris/Projects/CTK/Utilities/CMake")** > ** > > **** > > **** > > Otherwise, you will find below the result of my experiment. When > configured, CTK found the expected DCMTK. > > > On Ubuntu 13.04 using CMake 2.8.11.2, after installing the package > "python2.7-dev" doing so the following works.**** > > Note that I didn't enable CTK_ENABLE_ALL since I didn't the build system > to build VTK or ITK components. Instead, I passed the following options: > -DCTK_ENABLE_Python_Wrapping:BOOL=ON > -DCTK_ENABLE_DICOM:BOOL=ON > -DCTK_BUILD_EXAMPLES**** > > **** > > $ git clone git at github.com:commontk/CTK**** > > $ mkdir CTK-Debug**** > > $ cd CTK-Debug**** > > $ cmake > -DQT_QMAKE_EXECUTABLE:FILEPATH=/home/jchris/Support/QtSDK-1.2.1/Desktop/Qt/4.8.1/gcc/bin/qmake > -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON > -DCTK_BUILD_EXAMPLES:BOOL=ON ../CTK > [...] > -- Enabling [CTK_LIB_DICOM/Core] because of [ CTK_ENABLE_DICOM:1 OR ( > CTK_ENABLE_DICOMApplicationHosting:0 AND CTK_BUILD_EXAMPLES:1 )] evaluates > to True > -- Enabling [CTK_APP_ctkDICOM] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOM2] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMIndexer] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMDemoSCU] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMQuery] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMRetrieve] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMQueryRetrieve] because of [ > CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkCommandLineModuleExplorer] because of [ > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMObjectViewer] because of [ CTK_ENABLE_DICOM:1 > AND CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkSimplePythonShell] because of [ > CTK_ENABLE_Python_Wrapping:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True > -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep.txt > -- Generated: > /home/jchris/Projects/CTK-Debug/DGraphInput-alldep-withext.txt > -- Enabling option [CTK_LIB_DICOM/Widgets] required by [ctkDICOM] > -- Enabling option [CTK_LIB_Widgets] required by [ctkDICOM] > -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtGui] required by > [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtWebKit] required > by [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Backend/LocalProcess] > required by [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Backend/FunctionPointer] > required by [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Core] required by > [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_Scripting/Python/Widgets] required by > [ctkSimplePythonShell] > -- Enabling option [CTK_LIB_Scripting/Python/Core] required by > [ctkSimplePythonShell] > -- Found PythonInterp: /usr/bin/python (found version "2.7.4") > -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found > version "2.7.4") > -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput.txt > -- Generated: /home/jchris/Projects/CTK-Debug/Project.xml > -- Found Git: /usr/bin/git (found version "1.8.1.2") > -- Configuring done > -- Generating done > -- Build files have been written to: /home/jchris/Projects/CTK-Debug > > **** > > $ make -j6 > [...] > [ 90%] Performing configure step for 'CTK-Configure' > [...] > -- Found PythonInterp: /usr/bin/python (found version "2.7.4") > -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found > version "2.7.4") > -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/DGraphInput.txt > -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/Project.xml > -- Trying to find DCMTK expecting DCMTKConfig.cmake > -- Trying to find DCMTK expecting DCMTKConfig.cmake - failed > -- Trying to find DCMTK relying on FindDCMTK.cmake > -- Looking for include file pthread.h > -- Looking fothe r include file pthread.h - found > -- Looking for pthread_create > -- Looking for pthread_create - not found > -- Looking for pthread_create in pthreads > -- Looking for pthread_create in pthreads - not found > -- Looking for pthread_create in pthread > -- Looking for pthread_create in pthread - found > -- Found Threads: TRUE > -- Found DCMTK: > /home/jchris/Projects/CTK-Debug/CMakeExternals/Install/include/dcmtk/config > > -- Trying to find DCMTK relying on FindDCMTK.cmake - ok > -- CTKCore: BFD support disabled > -- Configuring done > -- Generating done > [...] > -- Build files have been written to: > /home/jchris/Projects/CTK-Debug/CTK-build > > [...] > [100%] Built target CTKWidgetsCppTests > [100%] Built target CTK-build**** > > ** ** > > $ cd CTK-build > $ $ cat CMakeCache.txt | ack DCMTK_DIR\:PATH > DCMTK_DIR:PATH=/home/jchris/Projects/CTK-Debug/CMakeExternals/Install > > > > **** > > Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is > explained by the fact the official DCMTK didn't integrate yet our latest > and greatest contribution [1]**** > > Hth**** > > Jc**** > > > [1] > https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 > **** > > **** > > **** > > **** > > On Wed, Oct 2, 2013 at 10:18 AM, Csaba Pinter > wrote:**** > > Hi all,**** > > **** > > I'm trying to build CTK separately, but I have problems with linking DCMTK. > **** > > **** > > The way I build CTK:**** > > - Turn on CTK_BUILD_ALL**** > > - Turn on CTK_ENABLE_DICOM (I need this as I want to merge and > test my changes in the CTK/Core/DICOM project)**** > > - Set the qmake executable**** > > - Configure**** > > - CMake complains about python paths, I set those manually**** > > - Configure, Generate**** > > - Build superbuild**** > > **** > > Then DCMTK is downloaded and built by the superbuild, but later on, CTK > projects find a completely different DCMTK directory (in my Slicer nightly > build directory). I tried to manually add the DCMTK directory to CMake, but > this variable does not exist in the superbuild (it is also not passed > down), and setting it to the inner CTK project doesn't work.**** > > **** > > Basically no matter what I do, the DCMTK path is set to whatever > find_project finds. This is what I found in CTKConfig.cmake:**** > > # Update CMake module path so that calling "find_package(DCMTK)" works as > expected **** > > # after calling "find_package(CTK)"**** > > # Ideally projects like DCMTK or PythonQt should provide both "Config" and > "Use" files.**** > > set(CMAKE_MODULE_PATH**** > > ${CTK_CMAKE_UTILITIES_DIR}**** > > ${CMAKE_MODULE_PATH}**** > > )**** > > **** > > Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there > is no chance DCMTK is found correctly.**** > > **** > > Can someone please help with this?**** > > **** > > Thanks a lot,**** > > csaba**** > > **** > > ________________________________**** > > Csaba Pinter**** > > Medical Software Systems Engineer**** > > Laboratory for Percutanous Surgery**** > > School of Computing**** > > Queen?s University**** > > Kingston, ON, Canada**** > > Email: csaba.pinter at queensu.ca**** > > Web: http://perk.cs.queensu.ca**** > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers**** > > > > > -- > +1 919 869 8849**** > > > > > -- > +1 919 869 8849**** > -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: Screen Shot CMake-package-registry.png Type: image/png Size: 62727 bytes Desc: not available URL: From kikinis at bwh.harvard.edu Sun Oct 6 06:09:29 2013 From: kikinis at bwh.harvard.edu (Ron Kikinis) Date: Sun, 06 Oct 2013 08:09:29 +0200 Subject: [Ctk-developers] Fwd: RE: RE: [slicer-users] Slicer hanging while saving In-Reply-To: References: Message-ID: <5250FE99.1040908@bwh.harvard.edu> Hello CTK community, Slicer is failing under certain circumstances while saving a scene. Can somebody help with this? Many thanks Ron -------- Original Message -------- Subject: RE: RE: [slicer-users] Slicer hanging while saving Date: Sun, 6 Oct 2013 00:55:00 +0000 From: Andras Lasso To: Jean-Christophe Fillion-Robin , Steve Pieper CC: Julien Finet , Ron Kikinis , Yuzheng Zhou The issue is 100% reproducible if the ?Red slice only? layout is used (and no other layouts are activated). The issue could be fixed in either Slicer (workaround only), CTK (root cause), and VTK (report error instead of hang). Added details to http://www.na-mic.org/Bug/view.php?id=3438. The best would be if a CTK developer who knows ctk::grabVTKWidget part could take over from here and resolve the issue. Until the problem is fixed users should switch to the ?Four-up? layout before saving the scene. Andras -- Ron Kikinis, M.D., Robert Greenes Distinguished Director of Biomedical Informatics Professor of Radiology, Harvard Medical School Director, Surgical Planning Laboratory http://www.spl.harvard.edu/~kikinis The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail. From pieper at ibility.net Sun Oct 6 19:45:11 2013 From: pieper at ibility.net (Steve Pieper) Date: Sun, 6 Oct 2013 15:45:11 -0400 Subject: [Ctk-developers] Fwd: RE: RE: [slicer-users] Slicer hanging while saving In-Reply-To: <5250FE99.1040908@bwh.harvard.edu> References: <5250FE99.1040908@bwh.harvard.edu> Message-ID: Hi VTK Developers - We've run into a bug [1] in 3D Slicer where VTK goes into an infinite loop calling glGetError [2]. According to the OpenGL man page [3], VTK is doing the correct thing, since the error code should eventually be cleared. But apparently in some circumstances for an invalid context the error is not cleared which is probably a driver bug. The slicer bug report [1] has more details. We can try to avoid the situation in CTK and/or Slicer by not calling QVTKWidget::cachedImage method on non-shown QVTKWidgets, but it also seems to me VTK would be the right place to put in a workaround for a graphics driver bug that can cause an infinite loop. If you agree this should be addressed in VTK, can anyone suggest the right way to address this? Perhaps we can check for a valid context before going into the infinite loop. Or we could add a counter and say that more than N calls to glGetError without getting GL_NO_ERROR is itself an error condition (with maybe N = 1000?). Note that the same kind of loop appears elsewhere in VTK, like vtkGLSLShader so whatever the right behavior is could be centralized in a method. Thanks, Steve [1] http://www.na-mic.org/Bug/view.php?id=3438 [2] https://github.com/Kitware/VTK/blob/master/Rendering/OpenGL/vtkOpenGLRenderWindow.cxx#L526-530 [3] Here's the current man page, but it looks unchanged in all the versions posted on opengl.org: http://www.opengl.org/sdk/docs/man/xhtml/glGetError.xml On Sun, Oct 6, 2013 at 2:09 AM, Ron Kikinis wrote: > Hello CTK community, > Slicer is failing under certain circumstances while saving a scene. Can > somebody help with this? > Many thanks > Ron > > > > -------- Original Message -------- > Subject: RE: RE: [slicer-users] Slicer hanging while saving > Date: Sun, 6 Oct 2013 00:55:00 +0000 > From: Andras Lasso > To: Jean-Christophe Fillion-Robin , Steve > Pieper > CC: Julien Finet , Ron Kikinis > , Yuzheng Zhou > > > > The issue is 100% reproducible if the ?Red slice only? layout is used > (and no other layouts are activated). The issue could be fixed in either > Slicer (workaround only), CTK (root cause), and VTK (report error > instead of hang). Added details to > http://www.na-mic.org/Bug/**view.php?id=3438 > . > > The best would be if a CTK developer who knows ctk::grabVTKWidget part > could take over from here and resolve the issue. > > Until the problem is fixed users should switch to the ?Four-up? layout > before saving the scene. > > Andras > > > -- > Ron Kikinis, M.D., > Robert Greenes Distinguished Director of Biomedical Informatics > Professor of Radiology, Harvard Medical School > Director, Surgical Planning Laboratory > http://www.spl.harvard.edu/~**kikinis > > > > > The information in this e-mail is intended only for the person to whom it > is > addressed. If you believe this e-mail was sent to you in error and the > e-mail > contains patient information, please contact the Partners Compliance > HelpLine at > http://www.partners.org/**complianceline. If the e-mail was sent to you in error > but does not contain patient information, please contact the sender and > properly > dispose of the e-mail. > > ______________________________**_________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-**bin/mailman/listinfo/ctk-**developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: From julien.finet at kitware.com Mon Oct 7 13:00:25 2013 From: julien.finet at kitware.com (Julien Finet) Date: Mon, 7 Oct 2013 09:00:25 -0400 Subject: [Ctk-developers] CTK range slider In-Reply-To: <1381134710.55582.YahooMailNeo@web172402.mail.ir2.yahoo.com> References: <1381134710.55582.YahooMailNeo@web172402.mail.ir2.yahoo.com> Message-ID: Hi Massimo, I gave a look at QLC+ and it seems to be a cool project, nice job ! Thanks for your interest in CTK. Let me first begin by saying that I am not a license expert but I cc-ed the CTK community and our license experts at Kitware. Having said, here are my thoughts: - The CTK community has chosen the Apache 2 license to give access of CTK to most people with less restrictions as possible (in the true open-source kind of way :-) ). - Therefore, if you don't hear otherwise, we would be happy to grant QLC+ access of CTK if you keep the license header in the CTK files you embed in your project. - I would strongly suggest that you change your license to a more recent version of GPL (v3?), or even better, to a more permissive license (such as Apache 2) to fully embrace the "open source" philosophy. Indeed, the licensing issue of CTK within QLC+ does not (seem to) come from Apache 2, but from the very restrictive GPLv2 (that is not even compatible with GPLv3 code). In the long run, it would be very counter productive for you guys to refrain yourself from re-using all the open source libraries available and you would waste lots of time trying to reinvent the wheel each time. - Finally, we would surely appreciate (but it is not mandatory) that you publicly mention CTK in your project. For example, on your website (an acknowledgment page maybe ?) or/and in your software (in an "About" dialog). - Feel free to contribute patch (using the github pull request mechanism) if you found and fixed bugs or added features. Best regards, Julien. On Mon, Oct 7, 2013 at 4:31 AM, Massimo Callegari wrote: > Hello Julien, > I found your email address on Github. > First of all, I just want to say you're doing a great job with the CTK > project ! > > I am the maintainer of another open source project called QLC+: > http://qlcplus.sourceforge.net/index.shtml > It's released under the GPLv2 license. > > Yesterday I was looking around for a solution about a range slider in Qt > and I found yours. > So I've got 2 questions: > - I would like to ask the permission to the CTK team to use the > ctkRangeSlider class in my project > - since you release CTK with the Apache 2.0 license, according to this page > http://www.apache.org/licenses/GPL-compatibility.html > it seems it is not compatible with GPLv2, so I'm wondering if you ever > face issues like this. > In case, would it be possible to grant to the QLC+ project a "special" > release of the range slider class under GPLv2 ? > > Thank you very much in advance ! > > Regards, > Massimo > -------------- next part -------------- An HTML attachment was scrubbed... URL: From m.nolden at dkfz-heidelberg.de Tue Oct 8 15:35:34 2013 From: m.nolden at dkfz-heidelberg.de (Marco Nolden) Date: Tue, 08 Oct 2013 17:35:34 +0200 Subject: [Ctk-developers] CTK range slider In-Reply-To: References: <1381134710.55582.YahooMailNeo@web172402.mail.ir2.yahoo.com> Message-ID: <52542646.1020600@dkfz.de> I think it's fine to re-use and include non-GPL code in GPL projects, as long as you clearly declare an exception for the included code (otherwise our Apache license wouldn't be permissive). On the GPL page you can find an example text you should add in your license/program: http://www.gnu.org/licenses/gpl-faq.en.html#GPLIncompatibleLibs I won't comment on which license is more following the "open source" philosophy ;) Best, Marco On 10/07/2013 03:00 PM, Julien Finet wrote: > Hi Massimo, > > I gave a look at QLC+ and it seems to be a cool project, nice job ! > > Thanks for your interest in CTK. > Let me first begin by saying that I am not a license expert but I cc-ed > the CTK community and our license experts at Kitware. > > Having said, here are my thoughts: > - The CTK community has chosen the Apache 2 license to give access of > CTK to most people with less restrictions as possible (in the true > open-source kind of way :-) ). > - Therefore, if you don't hear otherwise, we would be happy to grant > QLC+ access of CTK if you keep the license header in the CTK files you > embed in your project. > - I would strongly suggest that you change your license to a more > recent version of GPL (v3?), or even better, to a more permissive > license (such as Apache 2) to fully embrace the "open source" > philosophy. Indeed, the licensing issue of CTK within QLC+ does not > (seem to) come from Apache 2, but from the very restrictive GPLv2 (that > is not even compatible with GPLv3 code). In the long run, it would be > very counter productive for you guys to refrain yourself from re-using > all the open source libraries available and you would waste lots of time > trying to reinvent the wheel each time. > - Finally, we would surely appreciate (but it is not mandatory) that > you publicly mention CTK in your project. For example, on your website > (an acknowledgment page maybe ?) or/and in your software (in an "About" > dialog). > - Feel free to contribute patch (using the github pull request > mechanism) if you found and fixed bugs or added features. > > Best regards, > Julien. > > > On Mon, Oct 7, 2013 at 4:31 AM, Massimo Callegari > > wrote: > > Hello Julien, > I found your email address on Github. > First of all, I just want to say you're doing a great job with the > CTK project ! > > I am the maintainer of another open source project called QLC+: > http://qlcplus.sourceforge.net/index.shtml > It's released under the GPLv2 license. > > Yesterday I was looking around for a solution about a range slider > in Qt and I found yours. > So I've got 2 questions: > - I would like to ask the permission to the CTK team to use the > ctkRangeSlider class in my project > - since you release CTK with the Apache 2.0 license, according to > this page > http://www.apache.org/licenses/GPL-compatibility.html > it seems it is not compatible with GPLv2, so I'm wondering if you > ever face issues like this. > In case, would it be possible to grant to the QLC+ project a > "special" release of the range slider class under GPLv2 ? > > Thank you very much in advance ! > > Regards, > Massimo > > -- ---------------------------------------------------------------------- Dipl.-Inform. Med. Marco Nolden Deutsches Krebsforschungszentrum (German Cancer Research Center) Div. Medical & Biological Informatics Tel: (+49) 6221-42 2325 Im Neuenheimer Feld 280 Fax: (+49) 6221-42 2345 D-69120 Heidelberg eMail: M.Nolden at dkfz.de From csaba.pinter at queensu.ca Thu Oct 10 19:13:46 2013 From: csaba.pinter at queensu.ca (Csaba Pinter) Date: Thu, 10 Oct 2013 19:13:46 +0000 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555D3EE2@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: <04C6BCB5F77FFF449DAE728C597984555D8850@MP-DUP-MBX-01.AD.QUEENSU.CA> Hello, I tried the NO_DEFAULT_PATH idea Jc was suggesting (see below), and now I could successfully build CTK with DCMTK. As we have the same issue from time to time with CTK in Slicer (but finally we could reproduce it, see [1]), I propose adding this flag to FindDCMTK.cmake in the CTK master, at least until the DCMTKConfig.cmake change is not integrated to DCMTK. As my CMake knowledge is limited, I don't know if this change causes any problem on other operating systems though. I'd appreciate to hear your opinions about this. Thank you, csaba [1] https://www.assembla.com/spaces/slicerrt/tickets/325#/activity/ticket From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] Sent: October 4, 2013 18:34 To: Csaba Pinter Cc: Andras Lasso; CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, As illustrated in the enclosed screenshot, build tree can be exported into the CMake package registry. As some point, the DCMTK build tree has probably been exported [1][2][3]. Since when building CTK, it is expected that there are no DCMTKConfig.cmake available, the first should be failing. In your case, it seems not to be failing because it resolves to that previous build added to the registery. I would suggest to try adding the parameter "NO_DEFAULT_PATH" to the FindDCMTK.cmake module available in CTK. See [4] Hth Jc [1] http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:export [2] http://slicer-devel.65872.n3.nabble.com/Packaging-seems-to-work-again-tp4028121p4028134.html [3] https://www.assembla.com/spaces/slicerrt/tickets/244-dcmtk_dir-vs--dcmtkconfig-cmake?comment=267984263#comment:267984263 [4] https://github.com/commontk/CTK/blob/f64b68acd717dab060db41e8bee3f0f30df1a58f/Utilities/CMake/FindDCMTK.cmake#L42 On Fri, Oct 4, 2013 at 5:39 PM, Csaba Pinter > wrote: Hi Jc, I tried building CTK in many ways, but the result is always the same, so the problem is completely reproducible, at least on my computer (I haven't tried it elsewhere yet, but I plan to). As we have been struggling with this issue for quite a while, but haven't been able to consistently reproduce it, this is a great opportunity to fix it once and for all. I did some digging and this is what I found: - FindDCMTK.cmake finds DCMTKConfig.cmake, but it is in the incorrect directory that is used later (in one of my slicer builds) - The reason why the DCMTK downloaded by the superbuild is not found is most probably that it is a version that doesn't have DCMTKConfig.cmake (as you described earlier) - The same thing (finding the wrong DCMTK) happens if I add NO_CMAKE_BUILDS_PATH to the find_package call in FindDCMTK.cmake Now I don't have any idea how to get the superbuild to use its own DCMTK. Also even if I can do a workaround and have a good build of CTK on my machine, this is an issue that other people who want to build CTK on Windows while already having a Slicer build have to face. Cheers, csaba From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] Sent: October 4, 2013 12:07 To: Andras Lasso Cc: Csaba Pinter; CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, Andras, Within the file FindDCMTK.cmake [1] provided by CTK, where would you suggest to add the NO_CMAKE_BUILDS_PATH ? Let's also note that the FindDCMTK.cmake provided by ITK would have to patched also ... If you can reproduce the problem, with a combination of clearing cache + adding some "message()" statement, you should be able to find out or confirm what is the source of the problem. Jc [1] https://github.com/commontk/CTK/blob/master/Utilities/CMake/FindDCMTK.cmake On Wed, Oct 2, 2013 at 1:42 PM, Andras Lasso > wrote: I have this annoying issue during Slicer builds as well: my nightly slicer builds usually break after a few days because after I configure other projects in CMake CTK finds DCMTK of another project instead of its own. It may be due to the find_package path finding rule 5: "Search project build trees recently configured in a CMake GUI. This can be skipped if NO_CMAKE_BUILDS_PATH is passed. It is intended for the case when a user is building multiple dependent projects one after another." (http://www.cmake.org/cmake/help/v2.8.10/ctest.html). Probably CTK should rely on rules 1-4 or disable rule 5 - or it may be possible that something else goes wrong and that's why the rule 5 kicks in. Andras From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Jean-Christophe Fillion-Robin Sent: Wednesday, October 02, 2013 11:39 AM To: Csaba Pinter Cc: CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, In CTKConfig, the variable "CMAKE_MODULE_PATH" is a CMake global variable that is empty by default. On the other hand "CTK_CMAKE_UTILITIES_DIR" should not be empty as illustrated below: $ cat ../CTKConfig.cmake | ack -i "set\(CTK_CMAKE_UTILITIES_DIR" SET(CTK_CMAKE_UTILITIES_DIR "/home/jchris/Projects/CTK/Utilities/CMake") Otherwise, you will find below the result of my experiment. When configured, CTK found the expected DCMTK. On Ubuntu 13.04 using CMake 2.8.11.2, after installing the package "python2.7-dev" doing so the following works. Note that I didn't enable CTK_ENABLE_ALL since I didn't the build system to build VTK or ITK components. Instead, I passed the following options: -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES $ git clone git at github.com:commontk/CTK $ mkdir CTK-Debug $ cd CTK-Debug $ cmake -DQT_QMAKE_EXECUTABLE:FILEPATH=/home/jchris/Support/QtSDK-1.2.1/Desktop/Qt/4.8.1/gcc/bin/qmake -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES:BOOL=ON ../CTK [...] -- Enabling [CTK_LIB_DICOM/Core] because of [ CTK_ENABLE_DICOM:1 OR ( CTK_ENABLE_DICOMApplicationHosting:0 AND CTK_BUILD_EXAMPLES:1 )] evaluates to True -- Enabling [CTK_APP_ctkDICOM] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOM2] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMIndexer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMDemoSCU] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQuery] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQueryRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkCommandLineModuleExplorer] because of [ CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMObjectViewer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkSimplePythonShell] because of [ CTK_ENABLE_Python_Wrapping:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep.txt -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep-withext.txt -- Enabling option [CTK_LIB_DICOM/Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtGui] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtWebKit] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/LocalProcess] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/FunctionPointer] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Core] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_Scripting/Python/Widgets] required by [ctkSimplePythonShell] -- Enabling option [CTK_LIB_Scripting/Python/Core] required by [ctkSimplePythonShell] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/Project.xml -- Found Git: /usr/bin/git (found version "1.8.1.2") -- Configuring done -- Generating done -- Build files have been written to: /home/jchris/Projects/CTK-Debug $ make -j6 [...] [ 90%] Performing configure step for 'CTK-Configure' [...] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/Project.xml -- Trying to find DCMTK expecting DCMTKConfig.cmake -- Trying to find DCMTK expecting DCMTKConfig.cmake - failed -- Trying to find DCMTK relying on FindDCMTK.cmake -- Looking for include file pthread.h -- Looking fothe r include file pthread.h - found -- Looking for pthread_create -- Looking for pthread_create - not found -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- Found DCMTK: /home/jchris/Projects/CTK-Debug/CMakeExternals/Install/include/dcmtk/config -- Trying to find DCMTK relying on FindDCMTK.cmake - ok -- CTKCore: BFD support disabled -- Configuring done -- Generating done [...] -- Build files have been written to: /home/jchris/Projects/CTK-Debug/CTK-build [...] [100%] Built target CTKWidgetsCppTests [100%] Built target CTK-build $ cd CTK-build $ $ cat CMakeCache.txt | ack DCMTK_DIR\:PATH DCMTK_DIR:PATH=/home/jchris/Projects/CTK-Debug/CMakeExternals/Install Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is explained by the fact the official DCMTK didn't integrate yet our latest and greatest contribution [1] Hth Jc [1] https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 On Wed, Oct 2, 2013 at 10:18 AM, Csaba Pinter > wrote: Hi all, I'm trying to build CTK separately, but I have problems with linking DCMTK. The way I build CTK: - Turn on CTK_BUILD_ALL - Turn on CTK_ENABLE_DICOM (I need this as I want to merge and test my changes in the CTK/Core/DICOM project) - Set the qmake executable - Configure - CMake complains about python paths, I set those manually - Configure, Generate - Build superbuild Then DCMTK is downloaded and built by the superbuild, but later on, CTK projects find a completely different DCMTK directory (in my Slicer nightly build directory). I tried to manually add the DCMTK directory to CMake, but this variable does not exist in the superbuild (it is also not passed down), and setting it to the inner CTK project doesn't work. Basically no matter what I do, the DCMTK path is set to whatever find_project finds. This is what I found in CTKConfig.cmake: # Update CMake module path so that calling "find_package(DCMTK)" works as expected # after calling "find_package(CTK)" # Ideally projects like DCMTK or PythonQt should provide both "Config" and "Use" files. set(CMAKE_MODULE_PATH ${CTK_CMAKE_UTILITIES_DIR} ${CMAKE_MODULE_PATH} ) Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there is no chance DCMTK is found correctly. Can someone please help with this? Thanks a lot, csaba ________________________________ Csaba Pinter Medical Software Systems Engineer Laboratory for Percutanous Surgery School of Computing Queen's University Kingston, ON, Canada Email: csaba.pinter at queensu.ca Web: http://perk.cs.queensu.ca _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -- +1 919 869 8849 -- +1 919 869 8849 -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From e.coto at sheffield.ac.uk Sat Oct 12 16:37:31 2013 From: e.coto at sheffield.ac.uk (Ernesto Coto) Date: Sat, 12 Oct 2013 17:37:31 +0100 Subject: [Ctk-developers] CTK Command Line Modules Message-ID: Hi all, After building CTK I only got three Command Line Modules: ctkCmdLineModuleBlur2dImage.exe ctkCmdLineModuleTestBed.exe ctkCmdLineModuleTour.exe which look more like for testing purposes. Are there more Command Line Modules available somewhere ? Maybe I missed compiling some other project ? Regards, Ernesto Coto -------------- next part -------------- An HTML attachment was scrubbed... URL: From julien.finet at kitware.com Sun Oct 13 19:09:25 2013 From: julien.finet at kitware.com (Julien Finet) Date: Sun, 13 Oct 2013 15:09:25 -0400 Subject: [Ctk-developers] CTK Command Line Modules In-Reply-To: References: Message-ID: Indeed, CTK contains only the framework to handle Command Line Modules. You can find "real" command line modules in the applications that support such mechanism ( Slicer, MITK...) Hth, Julien. On Sat, Oct 12, 2013 at 12:37 PM, Ernesto Coto wrote: > Hi all, > > After building CTK I only got three Command Line Modules: > > ctkCmdLineModuleBlur2dImage.exe > ctkCmdLineModuleTestBed.exe > ctkCmdLineModuleTour.exe > > which look more like for testing purposes. > > Are there more Command Line Modules available somewhere ? Maybe I missed > compiling some other project ? > > Regards, > > Ernesto Coto > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From e.coto at sheffield.ac.uk Mon Oct 14 08:14:46 2013 From: e.coto at sheffield.ac.uk (Ernesto Coto) Date: Mon, 14 Oct 2013 09:14:46 +0100 Subject: [Ctk-developers] participation to the CTK hackfest @ London In-Reply-To: References: Message-ID: Hi Jean, I now have travel arrangements to attend the hackfest. So I'm confirming my attendance. Regarding the topics I would like to address: 1- I noticed that GIMIAS's Command Line Plugins are not working on CTK's Command Line Module Explorer. I would like to look into that. I have an idea of the reason why they are not working and I think I can fix that. GIMIAS has a large range of Command Line Plugins so I think this could be beneficial for both platforms. 2- In CISTIB, we have a Taverna Workbench (http://www.taverna.org.uk/) plugin that makes GIMIAS's Command Line Plugins work as services in Taverna. Since there is some compatibility between GIMIAS's CLPs and CTK's CLMs. I would like to experiment modifying the plugin a little bit to make it able to handle CTK's CLMs. Regards, Ernesto On 4 October 2013 17:09, Jean-Christophe Fillion-Robin < jchris.fillionr at kitware.com> wrote: > Hi Ernesto, > > Sounds great. The CLI infrastructure is been developer extensively and > would welcome some help. Would be great if you could come up with one or > two topics/issues you would like to address. > > Thanks > Jc > > > On Wed, Oct 2, 2013 at 5:00 AM, Ernesto Coto wrote: > >> Dear Jean, >> >> The relationship between CISTIB's GIMIAS and CTK resides on the >> command-line interfaces, so I would like to focus on that. >> >> However, I'm currently exploring other options, if I find something more >> interesting I will let you know in a couple of weeks, before the hackfest. >> >> Cheers, >> >> *Ernesto Coto* >> Scientific Software Developer >> Center for Computational Imaging & Simulation Technologies in Biomedicine >> (CISTIB) >> INSIGNEO Institute for In silico Medicine >> The University of Sheffield >> Room B85 - Portobello Centre >> Pitt St. Sheffield S1 4ET >> United Kingdom >> T: +44 (0) 114 222 0166 >> E: e.coto at sheffield.ac.uk >> >> >> On 1 October 2013 14:22, Jean-Christophe Fillion-Robin < >> jchris.fillionr at kitware.com> wrote: >> >>> Hi Ernesto, >>> >>> Considering the maximum number of participants has not been reached [1], >>> you could definitively attend :) >>> >>> Is there any aspect of CTK you would like to work on during the hackfest >>> ? How are you currently using (or will be using) CTK in your project ? >>> >>> Thanks >>> Jc >>> >>> [1] http://www.commontk.org/index.php/CTK-Hackfest-Nov-2013 >>> >>> >>> On Tue, Oct 1, 2013 at 7:33 AM, Ernesto Coto wrote: >>> >>>> Hi all, >>>> >>>> I am Ernesto Coto and I joined CISTIB (Center for Computational Imaging >>>> & Simulation Technologies in Biomedicine) at The University of Sheffield ( >>>> http://www.shef.ac.uk/) a few months ago. >>>> >>>> I have been working on medical image segmentation and visualization for >>>> several years at the Computer Graphics Center (http://ccg.ciens.ucv.ve/) >>>> of the Central University of Venezuela (http://www.ucv.ve/). >>>> >>>> At CISTIB I am part of the Software Development Team and the main >>>> CISTIB developer for the VPH-Share project (http://vph-share.eu/). >>>> >>>> As CISTIB has been supporting CTK for some time, I would like to >>>> continue this support by participating in the next CTK hackfest @ London. >>>> Please let me know if I Am still on time to participate. >>>> >>>> Regards, >>>> >>>> *Ernesto Coto* >>>> Scientific Software Developer >>>> Center for Computational Imaging & Simulation Technologies in >>>> Biomedicine (CISTIB) >>>> INSIGNEO Institute for In silico Medicine >>>> The University of Sheffield >>>> Room B85 - Portobello Centre >>>> Pitt St. Sheffield S1 4ET >>>> United Kingdom >>>> T: +44 (0) 114 222 0166 >>>> E: e.coto at sheffield.ac.uk >>>> >>>> _______________________________________________ >>>> Ctk-developers mailing list >>>> Ctk-developers at commontk.org >>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>> >>>> >>> >>> >>> -- >>> +1 919 869 8849 >>> >> >> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> >> > > > -- > +1 919 869 8849 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From yves.martelli at upf.edu Mon Oct 14 08:42:40 2013 From: yves.martelli at upf.edu (Yves Martelli) Date: Mon, 14 Oct 2013 10:42:40 +0200 Subject: [Ctk-developers] participation to the CTK hackfest @ London In-Reply-To: References: Message-ID: Hi Ernesto, I'm Yves from the ex-CISTIB of Barcelona's UPF, now part of Galgo Medical ( http://www.galgomedical.com/). The topics you mention are close to those I was working on. I was focusing on interoperability of command line plugins in different frameworks. You can find more information on the wiki of CTK at http://www.commontk.org/index.php/CLI_In_Context. I also published some code on github: https://github.com/ivmartel/semit. I wont be able to come to London so I hope this helps. Best, Yves 2013/10/14 Ernesto Coto > Hi Jean, > > I now have travel arrangements to attend the hackfest. So I'm confirming > my attendance. > > Regarding the topics I would like to address: > > 1- I noticed that GIMIAS's Command Line Plugins are not working on CTK's > Command Line Module Explorer. I would like to look into that. I have an > idea of the reason why they are not working and I think I can fix that. > GIMIAS has a large range of Command Line Plugins so I think this could be > beneficial for both platforms. > > 2- In CISTIB, we have a Taverna Workbench (http://www.taverna.org.uk/) > plugin that makes GIMIAS's Command Line Plugins work as services in > Taverna. Since there is some compatibility between GIMIAS's CLPs and CTK's > CLMs. I would like to experiment modifying the plugin a little bit to make > it able to handle CTK's CLMs. > > Regards, > > Ernesto > > On 4 October 2013 17:09, Jean-Christophe Fillion-Robin < > jchris.fillionr at kitware.com> wrote: > >> Hi Ernesto, >> >> Sounds great. The CLI infrastructure is been developer extensively and >> would welcome some help. Would be great if you could come up with one or >> two topics/issues you would like to address. >> >> Thanks >> Jc >> >> >> On Wed, Oct 2, 2013 at 5:00 AM, Ernesto Coto wrote: >> >>> Dear Jean, >>> >>> The relationship between CISTIB's GIMIAS and CTK resides on the >>> command-line interfaces, so I would like to focus on that. >>> >>> However, I'm currently exploring other options, if I find something more >>> interesting I will let you know in a couple of weeks, before the hackfest. >>> >>> Cheers, >>> >>> *Ernesto Coto* >>> Scientific Software Developer >>> Center for Computational Imaging & Simulation Technologies in >>> Biomedicine (CISTIB) >>> INSIGNEO Institute for In silico Medicine >>> The University of Sheffield >>> Room B85 - Portobello Centre >>> Pitt St. Sheffield S1 4ET >>> United Kingdom >>> T: +44 (0) 114 222 0166 >>> E: e.coto at sheffield.ac.uk >>> >>> >>> On 1 October 2013 14:22, Jean-Christophe Fillion-Robin < >>> jchris.fillionr at kitware.com> wrote: >>> >>>> Hi Ernesto, >>>> >>>> Considering the maximum number of participants has not been reached >>>> [1], you could definitively attend :) >>>> >>>> Is there any aspect of CTK you would like to work on during the >>>> hackfest ? How are you currently using (or will be using) CTK in your >>>> project ? >>>> >>>> Thanks >>>> Jc >>>> >>>> [1] http://www.commontk.org/index.php/CTK-Hackfest-Nov-2013 >>>> >>>> >>>> On Tue, Oct 1, 2013 at 7:33 AM, Ernesto Coto wrote: >>>> >>>>> Hi all, >>>>> >>>>> I am Ernesto Coto and I joined CISTIB (Center for Computational >>>>> Imaging & Simulation Technologies in Biomedicine) at The University of >>>>> Sheffield (http://www.shef.ac.uk/) a few months ago. >>>>> >>>>> I have been working on medical image segmentation and visualization >>>>> for several years at the Computer Graphics Center ( >>>>> http://ccg.ciens.ucv.ve/) of the Central University of Venezuela ( >>>>> http://www.ucv.ve/). >>>>> >>>>> At CISTIB I am part of the Software Development Team and the main >>>>> CISTIB developer for the VPH-Share project (http://vph-share.eu/). >>>>> >>>>> As CISTIB has been supporting CTK for some time, I would like to >>>>> continue this support by participating in the next CTK hackfest @ London. >>>>> Please let me know if I Am still on time to participate. >>>>> >>>>> Regards, >>>>> >>>>> *Ernesto Coto* >>>>> Scientific Software Developer >>>>> Center for Computational Imaging & Simulation Technologies in >>>>> Biomedicine (CISTIB) >>>>> INSIGNEO Institute for In silico Medicine >>>>> The University of Sheffield >>>>> Room B85 - Portobello Centre >>>>> Pitt St. Sheffield S1 4ET >>>>> United Kingdom >>>>> T: +44 (0) 114 222 0166 >>>>> E: e.coto at sheffield.ac.uk >>>>> >>>>> _______________________________________________ >>>>> Ctk-developers mailing list >>>>> Ctk-developers at commontk.org >>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>>>> >>>>> >>>> >>>> >>>> -- >>>> +1 919 869 8849 >>>> >>> >>> >>> _______________________________________________ >>> Ctk-developers mailing list >>> Ctk-developers at commontk.org >>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >>> >>> >> >> >> -- >> +1 919 869 8849 >> > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From lokkahei.uniyccc4 at gmail.com Wed Oct 16 16:59:51 2013 From: lokkahei.uniyccc4 at gmail.com (Kahei Lok) Date: Thu, 17 Oct 2013 00:59:51 +0800 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer Message-ID: Dear CTK, Hi! I am a newbie of CTK. I build the CTK under windows 7 OS. How can I add the plugin into Qt Designer 4.8.5? Cheers, Ka Hei -------------- next part -------------- An HTML attachment was scrubbed... URL: From julien.finet at kitware.com Wed Oct 16 17:33:15 2013 From: julien.finet at kitware.com (Julien Finet) Date: Wed, 16 Oct 2013 13:33:15 -0400 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: Welcome Kahei, I just added instructions here: http://www.commontk.org/index.php/CTK_In_QtDesigner Please let us know if it does not work for you. Thanks, Julien. On Wed, Oct 16, 2013 at 12:59 PM, Kahei Lok wrote: > Dear CTK, > > Hi! I am a newbie of CTK. I build the CTK under windows 7 OS. How can I > add the plugin into Qt Designer 4.8.5? > > Cheers, > Ka Hei > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From lokkahei.uniyccc4 at gmail.com Thu Oct 17 12:45:14 2013 From: lokkahei.uniyccc4 at gmail.com (Kahei Lok) Date: Thu, 17 Oct 2013 20:45:14 +0800 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: Hi jullien, I have added *QT_PLUGIN_PATH "**D:\CTK-build\CTK-build\bin**"* into environment and it result "cannot find specific module"[image: ???? 1] Then I added dependency"D:\CTK-build\CTK-build\bin\Release".However, error is output. How can I solve it? [image: ???? 3] Btw, Is Qt Designer from command line necessary Can I open designer.exe? Cheers, Ka Hei 2013/10/17 Julien Finet > Welcome Kahei, > > I just added instructions here: > http://www.commontk.org/index.php/CTK_In_QtDesigner > > Please let us know if it does not work for you. > > Thanks, > Julien. > > > On Wed, Oct 16, 2013 at 12:59 PM, Kahei Lok wrote: > >> Dear CTK, >> >> Hi! I am a newbie of CTK. I build the CTK under windows 7 OS. How can I >> add the plugin into Qt Designer 4.8.5? >> >> Cheers, >> Ka Hei >> >> _______________________________________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add dependency folder.png Type: image/png Size: 32007 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add QT_PLUGIN_PATH.png Type: image/png Size: 89857 bytes Desc: not available URL: From lokkahei.uniyccc4 at gmail.com Thu Oct 17 14:34:55 2013 From: lokkahei.uniyccc4 at gmail.com (Kahei Lok) Date: Thu, 17 Oct 2013 22:34:55 +0800 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: Dear Julien, I find the problem is the debug/ release version of Qt library mix together. I try to separate them into Debug/ Release folder. Then it works. But I am still can not load the CTKVisualizationVTKWidgetPlugin.dll. [image: ???? 1] What do I miss for this CTKVisualizationVTKWidgetPlugin.dll? -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add QT_PLUGIN_PATH.png Type: image/png Size: 56554 bytes Desc: not available URL: From julien.finet at kitware.com Thu Oct 17 14:44:40 2013 From: julien.finet at kitware.com (Julien Finet) Date: Thu, 17 Oct 2013 10:44:40 -0400 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: I'm glad to hear it works for you. For CTKVisualizationVTKWidgetsPlugins to load, you need to add the CTK-build/VTK-build/bin/Release path (the folder that contains the VTKCommon.dll and the other VTK dlls) to the PATH environment variable. Julien. On Thu, Oct 17, 2013 at 10:34 AM, Kahei Lok wrote: > Dear Julien, > > I find the problem is the debug/ release version of Qt library mix > together. I try to separate them into Debug/ Release folder. Then it works. > But I am still can not load the CTKVisualizationVTKWidgetPlugin.dll. > [image: ???? 1] > > What do I miss for this CTKVisualizationVTKWidgetPlugin.dll? > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add QT_PLUGIN_PATH.png Type: image/png Size: 56554 bytes Desc: not available URL: From csaba.pinter at queensu.ca Thu Oct 17 15:02:24 2013 From: csaba.pinter at queensu.ca (Csaba Pinter) Date: Thu, 17 Oct 2013 15:02:24 +0000 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: <04C6BCB5F77FFF449DAE728C597984555D8850@MP-DUP-MBX-01.AD.QUEENSU.CA> References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555D3EE2@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555D8850@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: <04C6BCB5F77FFF449DAE728C597984555DB9C1@MP-DUP-MBX-01.AD.QUEENSU.CA> Hi there, Any thoughts about the FindDCMTK changes proposed below? I'd appreciate any feedback. Thanks, csaba From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Csaba Pinter Sent: October 10, 2013 15:14 To: CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hello, I tried the NO_DEFAULT_PATH idea Jc was suggesting (see below), and now I could successfully build CTK with DCMTK. As we have the same issue from time to time with CTK in Slicer (but finally we could reproduce it, see [1]), I propose adding this flag to FindDCMTK.cmake in the CTK master, at least until the DCMTKConfig.cmake change is not integrated to DCMTK. As my CMake knowledge is limited, I don't know if this change causes any problem on other operating systems though. I'd appreciate to hear your opinions about this. Thank you, csaba [1] https://www.assembla.com/spaces/slicerrt/tickets/325#/activity/ticket From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] Sent: October 4, 2013 18:34 To: Csaba Pinter Cc: Andras Lasso; CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, As illustrated in the enclosed screenshot, build tree can be exported into the CMake package registry. As some point, the DCMTK build tree has probably been exported [1][2][3]. Since when building CTK, it is expected that there are no DCMTKConfig.cmake available, the first should be failing. In your case, it seems not to be failing because it resolves to that previous build added to the registery. I would suggest to try adding the parameter "NO_DEFAULT_PATH" to the FindDCMTK.cmake module available in CTK. See [4] Hth Jc [1] http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:export [2] http://slicer-devel.65872.n3.nabble.com/Packaging-seems-to-work-again-tp4028121p4028134.html [3] https://www.assembla.com/spaces/slicerrt/tickets/244-dcmtk_dir-vs--dcmtkconfig-cmake?comment=267984263#comment:267984263 [4] https://github.com/commontk/CTK/blob/f64b68acd717dab060db41e8bee3f0f30df1a58f/Utilities/CMake/FindDCMTK.cmake#L42 On Fri, Oct 4, 2013 at 5:39 PM, Csaba Pinter > wrote: Hi Jc, I tried building CTK in many ways, but the result is always the same, so the problem is completely reproducible, at least on my computer (I haven't tried it elsewhere yet, but I plan to). As we have been struggling with this issue for quite a while, but haven't been able to consistently reproduce it, this is a great opportunity to fix it once and for all. I did some digging and this is what I found: - FindDCMTK.cmake finds DCMTKConfig.cmake, but it is in the incorrect directory that is used later (in one of my slicer builds) - The reason why the DCMTK downloaded by the superbuild is not found is most probably that it is a version that doesn't have DCMTKConfig.cmake (as you described earlier) - The same thing (finding the wrong DCMTK) happens if I add NO_CMAKE_BUILDS_PATH to the find_package call in FindDCMTK.cmake Now I don't have any idea how to get the superbuild to use its own DCMTK. Also even if I can do a workaround and have a good build of CTK on my machine, this is an issue that other people who want to build CTK on Windows while already having a Slicer build have to face. Cheers, csaba From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] Sent: October 4, 2013 12:07 To: Andras Lasso Cc: Csaba Pinter; CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, Andras, Within the file FindDCMTK.cmake [1] provided by CTK, where would you suggest to add the NO_CMAKE_BUILDS_PATH ? Let's also note that the FindDCMTK.cmake provided by ITK would have to patched also ... If you can reproduce the problem, with a combination of clearing cache + adding some "message()" statement, you should be able to find out or confirm what is the source of the problem. Jc [1] https://github.com/commontk/CTK/blob/master/Utilities/CMake/FindDCMTK.cmake On Wed, Oct 2, 2013 at 1:42 PM, Andras Lasso > wrote: I have this annoying issue during Slicer builds as well: my nightly slicer builds usually break after a few days because after I configure other projects in CMake CTK finds DCMTK of another project instead of its own. It may be due to the find_package path finding rule 5: "Search project build trees recently configured in a CMake GUI. This can be skipped if NO_CMAKE_BUILDS_PATH is passed. It is intended for the case when a user is building multiple dependent projects one after another." (http://www.cmake.org/cmake/help/v2.8.10/ctest.html). Probably CTK should rely on rules 1-4 or disable rule 5 - or it may be possible that something else goes wrong and that's why the rule 5 kicks in. Andras From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Jean-Christophe Fillion-Robin Sent: Wednesday, October 02, 2013 11:39 AM To: Csaba Pinter Cc: CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, In CTKConfig, the variable "CMAKE_MODULE_PATH" is a CMake global variable that is empty by default. On the other hand "CTK_CMAKE_UTILITIES_DIR" should not be empty as illustrated below: $ cat ../CTKConfig.cmake | ack -i "set\(CTK_CMAKE_UTILITIES_DIR" SET(CTK_CMAKE_UTILITIES_DIR "/home/jchris/Projects/CTK/Utilities/CMake") Otherwise, you will find below the result of my experiment. When configured, CTK found the expected DCMTK. On Ubuntu 13.04 using CMake 2.8.11.2, after installing the package "python2.7-dev" doing so the following works. Note that I didn't enable CTK_ENABLE_ALL since I didn't the build system to build VTK or ITK components. Instead, I passed the following options: -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES $ git clone git at github.com:commontk/CTK $ mkdir CTK-Debug $ cd CTK-Debug $ cmake -DQT_QMAKE_EXECUTABLE:FILEPATH=/home/jchris/Support/QtSDK-1.2.1/Desktop/Qt/4.8.1/gcc/bin/qmake -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES:BOOL=ON ../CTK [...] -- Enabling [CTK_LIB_DICOM/Core] because of [ CTK_ENABLE_DICOM:1 OR ( CTK_ENABLE_DICOMApplicationHosting:0 AND CTK_BUILD_EXAMPLES:1 )] evaluates to True -- Enabling [CTK_APP_ctkDICOM] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOM2] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMIndexer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMDemoSCU] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQuery] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQueryRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkCommandLineModuleExplorer] because of [ CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMObjectViewer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkSimplePythonShell] because of [ CTK_ENABLE_Python_Wrapping:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep.txt -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep-withext.txt -- Enabling option [CTK_LIB_DICOM/Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtGui] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtWebKit] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/LocalProcess] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/FunctionPointer] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Core] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_Scripting/Python/Widgets] required by [ctkSimplePythonShell] -- Enabling option [CTK_LIB_Scripting/Python/Core] required by [ctkSimplePythonShell] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/Project.xml -- Found Git: /usr/bin/git (found version "1.8.1.2") -- Configuring done -- Generating done -- Build files have been written to: /home/jchris/Projects/CTK-Debug $ make -j6 [...] [ 90%] Performing configure step for 'CTK-Configure' [...] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/Project.xml -- Trying to find DCMTK expecting DCMTKConfig.cmake -- Trying to find DCMTK expecting DCMTKConfig.cmake - failed -- Trying to find DCMTK relying on FindDCMTK.cmake -- Looking for include file pthread.h -- Looking fothe r include file pthread.h - found -- Looking for pthread_create -- Looking for pthread_create - not found -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- Found DCMTK: /home/jchris/Projects/CTK-Debug/CMakeExternals/Install/include/dcmtk/config -- Trying to find DCMTK relying on FindDCMTK.cmake - ok -- CTKCore: BFD support disabled -- Configuring done -- Generating done [...] -- Build files have been written to: /home/jchris/Projects/CTK-Debug/CTK-build [...] [100%] Built target CTKWidgetsCppTests [100%] Built target CTK-build $ cd CTK-build $ $ cat CMakeCache.txt | ack DCMTK_DIR\:PATH DCMTK_DIR:PATH=/home/jchris/Projects/CTK-Debug/CMakeExternals/Install Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is explained by the fact the official DCMTK didn't integrate yet our latest and greatest contribution [1] Hth Jc [1] https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 On Wed, Oct 2, 2013 at 10:18 AM, Csaba Pinter > wrote: Hi all, I'm trying to build CTK separately, but I have problems with linking DCMTK. The way I build CTK: - Turn on CTK_BUILD_ALL - Turn on CTK_ENABLE_DICOM (I need this as I want to merge and test my changes in the CTK/Core/DICOM project) - Set the qmake executable - Configure - CMake complains about python paths, I set those manually - Configure, Generate - Build superbuild Then DCMTK is downloaded and built by the superbuild, but later on, CTK projects find a completely different DCMTK directory (in my Slicer nightly build directory). I tried to manually add the DCMTK directory to CMake, but this variable does not exist in the superbuild (it is also not passed down), and setting it to the inner CTK project doesn't work. Basically no matter what I do, the DCMTK path is set to whatever find_project finds. This is what I found in CTKConfig.cmake: # Update CMake module path so that calling "find_package(DCMTK)" works as expected # after calling "find_package(CTK)" # Ideally projects like DCMTK or PythonQt should provide both "Config" and "Use" files. set(CMAKE_MODULE_PATH ${CTK_CMAKE_UTILITIES_DIR} ${CMAKE_MODULE_PATH} ) Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there is no chance DCMTK is found correctly. Can someone please help with this? Thanks a lot, csaba ________________________________ Csaba Pinter Medical Software Systems Engineer Laboratory for Percutanous Surgery School of Computing Queen's University Kingston, ON, Canada Email: csaba.pinter at queensu.ca Web: http://perk.cs.queensu.ca _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -- +1 919 869 8849 -- +1 919 869 8849 -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From lokkahei.uniyccc4 at gmail.com Thu Oct 17 15:09:16 2013 From: lokkahei.uniyccc4 at gmail.com (Kahei Lok) Date: Thu, 17 Oct 2013 23:09:16 +0800 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: I include the path into the environment, but still cannot add into the qt designer. Is it still missing something? 2013/10/17 Julien Finet > I'm glad to hear it works for you. > For CTKVisualizationVTKWidgetsPlugins to load, you need to add the > CTK-build/VTK-build/bin/Release path (the folder that contains the > VTKCommon.dll and the other VTK dlls) to the PATH environment variable. > Julien. > > > On Thu, Oct 17, 2013 at 10:34 AM, Kahei Lok wrote: > >> Dear Julien, >> >> I find the problem is the debug/ release version of Qt library mix >> together. I try to separate them into Debug/ Release folder. Then it works. >> But I am still can not load the CTKVisualizationVTKWidgetPlugin.dll. >> [image: ???? 1] >> >> What do I miss for this CTKVisualizationVTKWidgetPlugin.dll? >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add QT_PLUGIN_PATH.png Type: image/png Size: 56554 bytes Desc: not available URL: From julien.finet at kitware.com Thu Oct 17 15:32:50 2013 From: julien.finet at kitware.com (Julien Finet) Date: Thu, 17 Oct 2013 11:32:50 -0400 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: For CTKScriptingPythonWidgetsPlugins.dll, you also need to add the PythonQt.dll (in CTK-build/PythonQt-build/...)path into PATH. You might also need to add the QtTesting.dll path (in CTK-build/QtTesting-build/...) as well. On Thu, Oct 17, 2013 at 11:09 AM, Kahei Lok wrote: > I include the path into the environment, but still cannot add into the qt > designer. Is it still missing something? > > > 2013/10/17 Julien Finet > >> I'm glad to hear it works for you. >> For CTKVisualizationVTKWidgetsPlugins to load, you need to add the >> CTK-build/VTK-build/bin/Release path (the folder that contains the >> VTKCommon.dll and the other VTK dlls) to the PATH environment variable. >> Julien. >> >> >> On Thu, Oct 17, 2013 at 10:34 AM, Kahei Lok wrote: >> >>> Dear Julien, >>> >>> I find the problem is the debug/ release version of Qt library mix >>> together. I try to separate them into Debug/ Release folder. Then it works. >>> But I am still can not load the CTKVisualizationVTKWidgetPlugin.dll. >>> [image: ???? 1] >>> >>> What do I miss for this CTKVisualizationVTKWidgetPlugin.dll? >>> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add QT_PLUGIN_PATH.png Type: image/png Size: 56554 bytes Desc: not available URL: From lokkahei.uniyccc4 at gmail.com Thu Oct 17 15:58:51 2013 From: lokkahei.uniyccc4 at gmail.com (Kahei Lok) Date: Thu, 17 Oct 2013 23:58:51 +0800 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: What I want is CTKVisualizationVTKWidgetPlugin. I successful add CTKwidgetPlugin into Qt designer. However, CTKVisualizationVTKWidgetPlugin still cannot be added into Qt deisgner. I add CTK-build/VTK-build/bin/Release into PATH, it still cannot. 2013/10/17 Julien Finet > For CTKScriptingPythonWidgetsPlugins.dll, you also need to add the > PythonQt.dll (in CTK-build/PythonQt-build/...)path into PATH. > You might also need to add the QtTesting.dll path (in > CTK-build/QtTesting-build/...) as well. > > > On Thu, Oct 17, 2013 at 11:09 AM, Kahei Lok wrote: > >> I include the path into the environment, but still cannot add into the qt >> designer. Is it still missing something? >> >> >> 2013/10/17 Julien Finet >> >>> I'm glad to hear it works for you. >>> For CTKVisualizationVTKWidgetsPlugins to load, you need to add the >>> CTK-build/VTK-build/bin/Release path (the folder that contains the >>> VTKCommon.dll and the other VTK dlls) to the PATH environment variable. >>> Julien. >>> >>> >>> On Thu, Oct 17, 2013 at 10:34 AM, Kahei Lok >> > wrote: >>> >>>> Dear Julien, >>>> >>>> I find the problem is the debug/ release version of Qt library mix >>>> together. I try to separate them into Debug/ Release folder. Then it works. >>>> But I am still can not load the CTKVisualizationVTKWidgetPlugin.dll. >>>> [image: ???? 1] >>>> >>>> What do I miss for this CTKVisualizationVTKWidgetPlugin.dll? >>>> >>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add QT_PLUGIN_PATH.png Type: image/png Size: 56554 bytes Desc: not available URL: From julien.finet at kitware.com Thu Oct 17 20:52:52 2013 From: julien.finet at kitware.com (Julien Finet) Date: Thu, 17 Oct 2013 16:52:52 -0400 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: Hi Kahei, I would suggest you try to use Dependency Walker in order to identify when DLL is missing in the PATH to correctly load CTKVisualizationVTKWidgetPlugin. Just tomake sure, you did prefix "CTK-build/VTK-build/bin/Release" with the path of CTK on your machine, right ? (for me it is "e:\work\CommonTK\CTK-build\VTK-build\bin\Release") Julien. On Thu, Oct 17, 2013 at 11:58 AM, Kahei Lok wrote: > What I want is CTKVisualizationVTKWidgetPlugin. I successful add > CTKwidgetPlugin into Qt designer. However, CTKVisualizationVTKWidgetPlugin > still cannot be added into Qt deisgner. I add CTK-build/VTK-build/bin/Release > into PATH, it still cannot. > > > 2013/10/17 Julien Finet > >> For CTKScriptingPythonWidgetsPlugins.dll, you also need to add the >> PythonQt.dll (in CTK-build/PythonQt-build/...)path into PATH. >> You might also need to add the QtTesting.dll path (in >> CTK-build/QtTesting-build/...) as well. >> >> >> On Thu, Oct 17, 2013 at 11:09 AM, Kahei Lok wrote: >> >>> I include the path into the environment, but still cannot add into the >>> qt designer. Is it still missing something? >>> >>> >>> 2013/10/17 Julien Finet >>> >>>> I'm glad to hear it works for you. >>>> For CTKVisualizationVTKWidgetsPlugins to load, you need to add the >>>> CTK-build/VTK-build/bin/Release path (the folder that contains the >>>> VTKCommon.dll and the other VTK dlls) to the PATH environment variable. >>>> Julien. >>>> >>>> >>>> On Thu, Oct 17, 2013 at 10:34 AM, Kahei Lok < >>>> lokkahei.uniyccc4 at gmail.com> wrote: >>>> >>>>> Dear Julien, >>>>> >>>>> I find the problem is the debug/ release version of Qt library mix >>>>> together. I try to separate them into Debug/ Release folder. Then it works. >>>>> But I am still can not load the CTKVisualizationVTKWidgetPlugin.dll. >>>>> [image: ???? 1] >>>>> >>>>> What do I miss for this CTKVisualizationVTKWidgetPlugin.dll? >>>>> >>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add QT_PLUGIN_PATH.png Type: image/png Size: 56554 bytes Desc: not available URL: From julien.finet at kitware.com Thu Oct 17 23:00:03 2013 From: julien.finet at kitware.com (Julien Finet) Date: Thu, 17 Oct 2013 19:00:03 -0400 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: It seems that QtTesting.dll is needed for CTKVisualizationVTKWidgetPlugin, so you need to add its path in the PATH environment too. Hth, Julien. On Thu, Oct 17, 2013 at 4:52 PM, Julien Finet wrote: > Hi Kahei, > I would suggest you try to use Dependency Walker in > order to identify when DLL is missing in the PATH to correctly load > CTKVisualizationVTKWidgetPlugin. > Just tomake sure, you did prefix "CTK-build/VTK-build/bin/Release" with > the path of CTK on your machine, right ? > (for me it is "e:\work\CommonTK\CTK-build\VTK-build\bin\Release") > > Julien. > > > On Thu, Oct 17, 2013 at 11:58 AM, Kahei Lok wrote: > >> What I want is CTKVisualizationVTKWidgetPlugin. I successful add >> CTKwidgetPlugin into Qt designer. However, CTKVisualizationVTKWidgetPlugin >> still cannot be added into Qt deisgner. I add CTK-build/VTK-build/bin/Release >> into PATH, it still cannot. >> >> >> 2013/10/17 Julien Finet >> >>> For CTKScriptingPythonWidgetsPlugins.dll, you also need to add the >>> PythonQt.dll (in CTK-build/PythonQt-build/...)path into PATH. >>> You might also need to add the QtTesting.dll path (in >>> CTK-build/QtTesting-build/...) as well. >>> >>> >>> On Thu, Oct 17, 2013 at 11:09 AM, Kahei Lok >> > wrote: >>> >>>> I include the path into the environment, but still cannot add into the >>>> qt designer. Is it still missing something? >>>> >>>> >>>> 2013/10/17 Julien Finet >>>> >>>>> I'm glad to hear it works for you. >>>>> For CTKVisualizationVTKWidgetsPlugins to load, you need to add the >>>>> CTK-build/VTK-build/bin/Release path (the folder that contains the >>>>> VTKCommon.dll and the other VTK dlls) to the PATH environment variable. >>>>> Julien. >>>>> >>>>> >>>>> On Thu, Oct 17, 2013 at 10:34 AM, Kahei Lok < >>>>> lokkahei.uniyccc4 at gmail.com> wrote: >>>>> >>>>>> Dear Julien, >>>>>> >>>>>> I find the problem is the debug/ release version of Qt library >>>>>> mix together. I try to separate them into Debug/ Release folder. Then it >>>>>> works. But I am still can not load the CTKVisualizationVTKWidgetPlugin.dll. >>>>>> [image: ???? 1] >>>>>> >>>>>> What do I miss for this CTKVisualizationVTKWidgetPlugin.dll? >>>>>> >>>>> >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add QT_PLUGIN_PATH.png Type: image/png Size: 56554 bytes Desc: not available URL: From lokkahei.uniyccc4 at gmail.com Fri Oct 18 17:26:15 2013 From: lokkahei.uniyccc4 at gmail.com (Kahei Lok) Date: Sat, 19 Oct 2013 01:26:15 +0800 Subject: [Ctk-developers] Add Ctk Plugin into Qt designer In-Reply-To: References: Message-ID: Daer Julien, I make it. I cmake ctk again ,and this time I turn on CTK_USE_QTTESTING,,and include the path "CTK-build/QtTesting-build/Release" into PATH variable. And, I also recmake VTK, with VTK_USE_Chart adn VTK_USE_Charts ON. I works now. Many thanks, Julien! Cheers, Ka Hei 2013/10/18 Julien Finet > It seems that QtTesting.dll is needed for CTKVisualizationVTKWidgetPlugin, > so you need to add its path in the PATH environment too. > Hth, > Julien. > > > On Thu, Oct 17, 2013 at 4:52 PM, Julien Finet wrote: > >> Hi Kahei, >> I would suggest you try to use Dependency Walker in >> order to identify when DLL is missing in the PATH to correctly load >> CTKVisualizationVTKWidgetPlugin. >> Just tomake sure, you did prefix "CTK-build/VTK-build/bin/Release" with >> the path of CTK on your machine, right ? >> (for me it is "e:\work\CommonTK\CTK-build\VTK-build\bin\Release") >> >> Julien. >> >> >> On Thu, Oct 17, 2013 at 11:58 AM, Kahei Lok wrote: >> >>> What I want is CTKVisualizationVTKWidgetPlugin. I successful add >>> CTKwidgetPlugin into Qt designer. However, CTKVisualizationVTKWidgetPlugin >>> still cannot be added into Qt deisgner. I add CTK-build/VTK-build/bin/Release >>> into PATH, it still cannot. >>> >>> >>> 2013/10/17 Julien Finet >>> >>>> For CTKScriptingPythonWidgetsPlugins.dll, you also need to add the >>>> PythonQt.dll (in CTK-build/PythonQt-build/...)path into PATH. >>>> You might also need to add the QtTesting.dll path (in >>>> CTK-build/QtTesting-build/...) as well. >>>> >>>> >>>> On Thu, Oct 17, 2013 at 11:09 AM, Kahei Lok < >>>> lokkahei.uniyccc4 at gmail.com> wrote: >>>> >>>>> I include the path into the environment, but still cannot add into the >>>>> qt designer. Is it still missing something? >>>>> >>>>> >>>>> 2013/10/17 Julien Finet >>>>> >>>>>> I'm glad to hear it works for you. >>>>>> For CTKVisualizationVTKWidgetsPlugins to load, you need to add the >>>>>> CTK-build/VTK-build/bin/Release path (the folder that contains the >>>>>> VTKCommon.dll and the other VTK dlls) to the PATH environment variable. >>>>>> Julien. >>>>>> >>>>>> >>>>>> On Thu, Oct 17, 2013 at 10:34 AM, Kahei Lok < >>>>>> lokkahei.uniyccc4 at gmail.com> wrote: >>>>>> >>>>>>> Dear Julien, >>>>>>> >>>>>>> I find the problem is the debug/ release version of Qt library >>>>>>> mix together. I try to separate them into Debug/ Release folder. Then it >>>>>>> works. But I am still can not load the CTKVisualizationVTKWidgetPlugin.dll. >>>>>>> [image: ???? 1] >>>>>>> >>>>>>> What do I miss for this CTKVisualizationVTKWidgetPlugin.dll? >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: after add QT_PLUGIN_PATH.png Type: image/png Size: 56554 bytes Desc: not available URL: From m.clarkson at ucl.ac.uk Fri Oct 25 13:14:45 2013 From: m.clarkson at ucl.ac.uk (Clarkson, Matt) Date: Fri, 25 Oct 2013 13:14:45 +0000 Subject: [Ctk-developers] London Hackfest 4-8th Nov Message-ID: <6681A948-E82F-4C70-98DA-B86542FBE9B3@live.ucl.ac.uk> Hi there, Miklos and I are getting organised for the London Hackfest here at UCL, and we are looking forward to all the visitors. Please can we try and get final numbers established, so please update the Wiki. Please can people email Miklos and myself if they would like to come, but can't update the Wiki. I have been sorting out Wifi access on our UCLGuest network, but if anyone also has eduroam access locally, then they should make sure they have that setup beforehand. More details to follow. Thanks Matt and Miklos. From pieper at ibility.net Thu Oct 31 20:37:15 2013 From: pieper at ibility.net (Steve Pieper) Date: Thu, 31 Oct 2013 16:37:15 -0400 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: <04C6BCB5F77FFF449DAE728C597984555DB9C1@MP-DUP-MBX-01.AD.QUEENSU.CA> References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555D3EE2@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555D8850@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555DB9C1@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: Hi Csaba - We'll be discussing open issues next week in London - can you make sure there's a ctk issue that points to your assembla report? http://www.commontk.org/index.php/CTK-Hackfest-Nov-2013#Monday Thanks, Steve On Thu, Oct 17, 2013 at 11:02 AM, Csaba Pinter wrote: > Hi there,**** > > ** ** > > Any thoughts about the FindDCMTK changes proposed below?**** > > I'd appreciate any feedback.**** > > ** ** > > Thanks,**** > > csaba**** > > ** ** > > ** ** > > *From:* ctk-developers-bounces at commontk.org [mailto: > ctk-developers-bounces at commontk.org] *On Behalf Of *Csaba Pinter > *Sent:* October 10, 2013 15:14 > *To:* CTK mailing list > > *Subject:* Re: [Ctk-developers] DCMTK_DIR is found incorrectly**** > > ** ** > > Hello,**** > > ** ** > > I tried the NO_DEFAULT_PATH idea Jc was suggesting (see below), and now I > could successfully build CTK with DCMTK.**** > > ** ** > > As we have the same issue from time to time with CTK in Slicer (but > finally we could reproduce it, see [1]), I propose adding this flag to > FindDCMTK.cmake in the CTK master, at least until the DCMTKConfig.cmake > change is not integrated to DCMTK.**** > > As my CMake knowledge is limited, I don't know if this change causes any > problem on other operating systems though.**** > > ** ** > > I'd appreciate to hear your opinions about this.**** > > ** ** > > Thank you,**** > > csaba**** > > ** ** > > [1] https://www.assembla.com/spaces/slicerrt/tickets/325#/activity/ticket* > *** > > ** ** > > ** ** > > *From:* Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] > > *Sent:* October 4, 2013 18:34 > *To:* Csaba Pinter > *Cc:* Andras Lasso; CTK mailing list > *Subject:* Re: [Ctk-developers] DCMTK_DIR is found incorrectly**** > > ** ** > > Hi Csaba, **** > > ** ** > > As illustrated in the enclosed screenshot, build tree can be exported into > the CMake package registry. As some point, the DCMTK build tree has > probably been exported [1][2][3]. > > Since when building CTK, it is expected that there are no > DCMTKConfig.cmake available, the first should be failing. In your case, it > seems not to be failing because it resolves to that previous build added to > the registery.**** > > I would suggest to try adding the parameter "NO_DEFAULT_PATH" to the > FindDCMTK.cmake module available in CTK. See [4]**** > > ** ** > > Hth**** > > Jc**** > > ** ** > > [1] http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:export > [2] > http://slicer-devel.65872.n3.nabble.com/Packaging-seems-to-work-again-tp4028121p4028134.html > **** > > [3] > https://www.assembla.com/spaces/slicerrt/tickets/244-dcmtk_dir-vs--dcmtkconfig-cmake?comment=267984263#comment:267984263 > **** > > [4] > https://github.com/commontk/CTK/blob/f64b68acd717dab060db41e8bee3f0f30df1a58f/Utilities/CMake/FindDCMTK.cmake#L42 > **** > > ** ** > > On Fri, Oct 4, 2013 at 5:39 PM, Csaba Pinter > wrote:**** > > Hi Jc,**** > > **** > > I tried building CTK in many ways, but the result is always the same, so > the problem is completely reproducible, at least on my computer (I haven't > tried it elsewhere yet, but I plan to). As we have been struggling with > this issue for quite a while, but haven't been able to consistently > reproduce it, this is a great opportunity to fix it once and for all.**** > > **** > > I did some digging and this is what I found:**** > > - FindDCMTK.cmake finds DCMTKConfig.cmake, but it is in the > incorrect directory that is used later (in one of my slicer builds)**** > > - The reason why the DCMTK downloaded by the superbuild is not > found is most probably that it is a version that doesn't have > DCMTKConfig.cmake (as you described earlier)**** > > - The same thing (finding the wrong DCMTK) happens if I add > NO_CMAKE_BUILDS_PATH to the find_package call in FindDCMTK.cmake**** > > **** > > Now I don't have any idea how to get the superbuild to use its own DCMTK.* > *** > > Also even if I can do a workaround and have a good build of CTK on my > machine, this is an issue that other people who want to build CTK on > Windows while already having a Slicer build have to face.**** > > **** > > Cheers,**** > > csaba**** > > **** > > **** > > *From:* Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] > > *Sent:* October 4, 2013 12:07 > *To:* Andras Lasso > *Cc:* Csaba Pinter; CTK mailing list**** > > > *Subject:* Re: [Ctk-developers] DCMTK_DIR is found incorrectly**** > > **** > > Hi Csaba, Andras, **** > > Within the file FindDCMTK.cmake [1] provided by CTK, where would you > suggest to add the NO_CMAKE_BUILDS_PATH ?**** > > Let's also note that the FindDCMTK.cmake provided by ITK would have to > patched also ... **** > > If you can reproduce the problem, with a combination of clearing cache + > adding some "message()" statement, you should be able to find out or > confirm what is the source of the problem.**** > > **** > > Jc**** > > > [1] > https://github.com/commontk/CTK/blob/master/Utilities/CMake/FindDCMTK.cmake > **** > > **** > > On Wed, Oct 2, 2013 at 1:42 PM, Andras Lasso wrote:**** > > I have this annoying issue during Slicer builds as well: my nightly slicer > builds usually break after a few days because after I configure other > projects in CMake CTK finds DCMTK of another project instead of its own.** > ** > > **** > > It may be due to the find_package path finding rule 5: ?Search project > build trees recently configured in a CMake GUI. This can be skipped if > NO_CMAKE_BUILDS_PATH is passed. It is intended for the case when a user is > building multiple dependent projects one after another.? ( > http://www.cmake.org/cmake/help/v2.8.10/ctest.html). Probably CTK should > rely on rules 1-4 or disable rule 5 ? or it may be possible that something > else goes wrong and that?s why the rule 5 kicks in.**** > > **** > > Andras**** > > **** > > **** > > *From:* ctk-developers-bounces at commontk.org [mailto: > ctk-developers-bounces at commontk.org] *On Behalf Of *Jean-Christophe > Fillion-Robin > *Sent:* Wednesday, October 02, 2013 11:39 AM**** > > > *To:* Csaba Pinter > *Cc:* CTK mailing list > *Subject:* Re: [Ctk-developers] DCMTK_DIR is found incorrectly**** > > **** > > Hi Csaba, **** > > In CTKConfig, the variable "CMAKE_MODULE_PATH" is a CMake global variable > that is empty by default. On the other hand "CTK_CMAKE_UTILITIES_DIR" > should not be empty as illustrated below: > > $ cat ../CTKConfig.cmake | ack -i "set\(CTK_CMAKE_UTILITIES_DIR" > SET(CTK_CMAKE_UTILITIES_DIR "/home/jchris/Projects/CTK/Utilities/CMake")** > ** > > **** > > **** > > Otherwise, you will find below the result of my experiment. When > configured, CTK found the expected DCMTK. > > > On Ubuntu 13.04 using CMake 2.8.11.2, after installing the package > "python2.7-dev" doing so the following works.**** > > Note that I didn't enable CTK_ENABLE_ALL since I didn't the build system > to build VTK or ITK components. Instead, I passed the following options: > -DCTK_ENABLE_Python_Wrapping:BOOL=ON > -DCTK_ENABLE_DICOM:BOOL=ON > -DCTK_BUILD_EXAMPLES**** > > **** > > $ git clone git at github.com:commontk/CTK**** > > $ mkdir CTK-Debug**** > > $ cd CTK-Debug**** > > $ cmake > -DQT_QMAKE_EXECUTABLE:FILEPATH=/home/jchris/Support/QtSDK-1.2.1/Desktop/Qt/4.8.1/gcc/bin/qmake > -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON > -DCTK_BUILD_EXAMPLES:BOOL=ON ../CTK > [...] > -- Enabling [CTK_LIB_DICOM/Core] because of [ CTK_ENABLE_DICOM:1 OR ( > CTK_ENABLE_DICOMApplicationHosting:0 AND CTK_BUILD_EXAMPLES:1 )] evaluates > to True > -- Enabling [CTK_APP_ctkDICOM] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOM2] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMIndexer] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMDemoSCU] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMQuery] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMRetrieve] because of [ CTK_ENABLE_DICOM:1 AND > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMQueryRetrieve] because of [ > CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkCommandLineModuleExplorer] because of [ > CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkDICOMObjectViewer] because of [ CTK_ENABLE_DICOM:1 > AND CTK_BUILD_EXAMPLES:1] evaluates to True > -- Enabling [CTK_APP_ctkSimplePythonShell] because of [ > CTK_ENABLE_Python_Wrapping:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True > -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep.txt > -- Generated: > /home/jchris/Projects/CTK-Debug/DGraphInput-alldep-withext.txt > -- Enabling option [CTK_LIB_DICOM/Widgets] required by [ctkDICOM] > -- Enabling option [CTK_LIB_Widgets] required by [ctkDICOM] > -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtGui] required by > [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtWebKit] required > by [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Backend/LocalProcess] > required by [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Backend/FunctionPointer] > required by [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_CommandLineModules/Core] required by > [ctkCommandLineModuleExplorer] > -- Enabling option [CTK_LIB_Scripting/Python/Widgets] required by > [ctkSimplePythonShell] > -- Enabling option [CTK_LIB_Scripting/Python/Core] required by > [ctkSimplePythonShell] > -- Found PythonInterp: /usr/bin/python (found version "2.7.4") > -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found > version "2.7.4") > -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput.txt > -- Generated: /home/jchris/Projects/CTK-Debug/Project.xml > -- Found Git: /usr/bin/git (found version "1.8.1.2") > -- Configuring done > -- Generating done > -- Build files have been written to: /home/jchris/Projects/CTK-Debug**** > > $ make -j6 > [...] > [ 90%] Performing configure step for 'CTK-Configure' > [...] > -- Found PythonInterp: /usr/bin/python (found version "2.7.4") > -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found > version "2.7.4") > -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/DGraphInput.txt > -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/Project.xml > -- Trying to find DCMTK expecting DCMTKConfig.cmake > -- Trying to find DCMTK expecting DCMTKConfig.cmake - failed > -- Trying to find DCMTK relying on FindDCMTK.cmake > -- Looking for include file pthread.h > -- Looking fothe r include file pthread.h - found > -- Looking for pthread_create > -- Looking for pthread_create - not found > -- Looking for pthread_create in pthreads > -- Looking for pthread_create in pthreads - not found > -- Looking for pthread_create in pthread > -- Looking for pthread_create in pthread - found > -- Found Threads: TRUE > -- Found DCMTK: > /home/jchris/Projects/CTK-Debug/CMakeExternals/Install/include/dcmtk/config > > -- Trying to find DCMTK relying on FindDCMTK.cmake - ok > -- CTKCore: BFD support disabled > -- Configuring done > -- Generating done > [...] > -- Build files have been written to: > /home/jchris/Projects/CTK-Debug/CTK-build > > [...] > [100%] Built target CTKWidgetsCppTests > [100%] Built target CTK-build**** > > **** > > $ cd CTK-build > $ $ cat CMakeCache.txt | ack DCMTK_DIR\:PATH > DCMTK_DIR:PATH=/home/jchris/Projects/CTK-Debug/CMakeExternals/Install > > **** > > Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is > explained by the fact the official DCMTK didn't integrate yet our latest > and greatest contribution [1]**** > > Hth**** > > Jc**** > > > [1] > https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 > **** > > **** > > **** > > **** > > On Wed, Oct 2, 2013 at 10:18 AM, Csaba Pinter > wrote:**** > > Hi all,**** > > **** > > I'm trying to build CTK separately, but I have problems with linking DCMTK. > **** > > **** > > The way I build CTK:**** > > - Turn on CTK_BUILD_ALL**** > > - Turn on CTK_ENABLE_DICOM (I need this as I want to merge and > test my changes in the CTK/Core/DICOM project)**** > > - Set the qmake executable**** > > - Configure**** > > - CMake complains about python paths, I set those manually**** > > - Configure, Generate**** > > - Build superbuild**** > > **** > > Then DCMTK is downloaded and built by the superbuild, but later on, CTK > projects find a completely different DCMTK directory (in my Slicer nightly > build directory). I tried to manually add the DCMTK directory to CMake, but > this variable does not exist in the superbuild (it is also not passed > down), and setting it to the inner CTK project doesn't work.**** > > **** > > Basically no matter what I do, the DCMTK path is set to whatever > find_project finds. This is what I found in CTKConfig.cmake:**** > > # Update CMake module path so that calling "find_package(DCMTK)" works as > expected **** > > # after calling "find_package(CTK)"**** > > # Ideally projects like DCMTK or PythonQt should provide both "Config" and > "Use" files.**** > > set(CMAKE_MODULE_PATH**** > > ${CTK_CMAKE_UTILITIES_DIR}**** > > ${CMAKE_MODULE_PATH}**** > > )**** > > **** > > Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there > is no chance DCMTK is found correctly.**** > > **** > > Can someone please help with this?**** > > **** > > Thanks a lot,**** > > csaba**** > > **** > > ________________________________**** > > Csaba Pinter**** > > Medical Software Systems Engineer**** > > Laboratory for Percutanous Surgery**** > > School of Computing**** > > Queen?s University**** > > Kingston, ON, Canada**** > > Email: csaba.pinter at queensu.ca**** > > Web: http://perk.cs.queensu.ca**** > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers**** > > > > > -- > +1 919 869 8849**** > > > > > -- > +1 919 869 8849**** > > > > > -- > +1 919 869 8849**** > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > > The information in this e-mail is intended only for the person to whom it > is > addressed. If you believe this e-mail was sent to you in error and the > e-mail > contains patient information, please contact the Partners Compliance > HelpLine at > http://www.partners.org/complianceline . If the e-mail was sent to you in > error > but does not contain patient information, please contact the sender and > properly > dispose of the e-mail. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From csaba.pinter at queensu.ca Thu Oct 31 20:46:57 2013 From: csaba.pinter at queensu.ca (Csaba Pinter) Date: Thu, 31 Oct 2013 20:46:57 +0000 Subject: [Ctk-developers] DCMTK_DIR is found incorrectly In-Reply-To: References: <04C6BCB5F77FFF449DAE728C597984555D1732@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555D3EE2@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555D8850@MP-DUP-MBX-01.AD.QUEENSU.CA> <04C6BCB5F77FFF449DAE728C597984555DB9C1@MP-DUP-MBX-01.AD.QUEENSU.CA> Message-ID: <04C6BCB5F77FFF449DAE728C597984555EB1CA@MP-DUP-MBX-02.AD.QUEENSU.CA> Hi Steve, I was going to do just that, thanks for the reminder! I created issue https://github.com/commontk/CTK/issues/382. The main reason I haven't created a topic branch yet is that I would like to hear some opinions about it first, as I don't know what consequences it has on Linux and Mac. FYI my agenda for next week besides this small change is to try our display tables and DICOM roles enhancement for the DICOM browser (that Andras and I implemented during the last hackfest) against the latest listview-based browser and integrate it if it turns out to be working fine. Thanks, csaba From: Steve Pieper [mailto:pieper at ibility.net] Sent: October 31, 2013 16:37 To: Csaba Pinter Cc: CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba - We'll be discussing open issues next week in London - can you make sure there's a ctk issue that points to your assembla report? http://www.commontk.org/index.php/CTK-Hackfest-Nov-2013#Monday Thanks, Steve On Thu, Oct 17, 2013 at 11:02 AM, Csaba Pinter > wrote: Hi there, Any thoughts about the FindDCMTK changes proposed below? I'd appreciate any feedback. Thanks, csaba From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Csaba Pinter Sent: October 10, 2013 15:14 To: CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hello, I tried the NO_DEFAULT_PATH idea Jc was suggesting (see below), and now I could successfully build CTK with DCMTK. As we have the same issue from time to time with CTK in Slicer (but finally we could reproduce it, see [1]), I propose adding this flag to FindDCMTK.cmake in the CTK master, at least until the DCMTKConfig.cmake change is not integrated to DCMTK. As my CMake knowledge is limited, I don't know if this change causes any problem on other operating systems though. I'd appreciate to hear your opinions about this. Thank you, csaba [1] https://www.assembla.com/spaces/slicerrt/tickets/325#/activity/ticket From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] Sent: October 4, 2013 18:34 To: Csaba Pinter Cc: Andras Lasso; CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, As illustrated in the enclosed screenshot, build tree can be exported into the CMake package registry. As some point, the DCMTK build tree has probably been exported [1][2][3]. Since when building CTK, it is expected that there are no DCMTKConfig.cmake available, the first should be failing. In your case, it seems not to be failing because it resolves to that previous build added to the registery. I would suggest to try adding the parameter "NO_DEFAULT_PATH" to the FindDCMTK.cmake module available in CTK. See [4] Hth Jc [1] http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:export [2] http://slicer-devel.65872.n3.nabble.com/Packaging-seems-to-work-again-tp4028121p4028134.html [3] https://www.assembla.com/spaces/slicerrt/tickets/244-dcmtk_dir-vs--dcmtkconfig-cmake?comment=267984263#comment:267984263 [4] https://github.com/commontk/CTK/blob/f64b68acd717dab060db41e8bee3f0f30df1a58f/Utilities/CMake/FindDCMTK.cmake#L42 On Fri, Oct 4, 2013 at 5:39 PM, Csaba Pinter > wrote: Hi Jc, I tried building CTK in many ways, but the result is always the same, so the problem is completely reproducible, at least on my computer (I haven't tried it elsewhere yet, but I plan to). As we have been struggling with this issue for quite a while, but haven't been able to consistently reproduce it, this is a great opportunity to fix it once and for all. I did some digging and this is what I found: - FindDCMTK.cmake finds DCMTKConfig.cmake, but it is in the incorrect directory that is used later (in one of my slicer builds) - The reason why the DCMTK downloaded by the superbuild is not found is most probably that it is a version that doesn't have DCMTKConfig.cmake (as you described earlier) - The same thing (finding the wrong DCMTK) happens if I add NO_CMAKE_BUILDS_PATH to the find_package call in FindDCMTK.cmake Now I don't have any idea how to get the superbuild to use its own DCMTK. Also even if I can do a workaround and have a good build of CTK on my machine, this is an issue that other people who want to build CTK on Windows while already having a Slicer build have to face. Cheers, csaba From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com] Sent: October 4, 2013 12:07 To: Andras Lasso Cc: Csaba Pinter; CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, Andras, Within the file FindDCMTK.cmake [1] provided by CTK, where would you suggest to add the NO_CMAKE_BUILDS_PATH ? Let's also note that the FindDCMTK.cmake provided by ITK would have to patched also ... If you can reproduce the problem, with a combination of clearing cache + adding some "message()" statement, you should be able to find out or confirm what is the source of the problem. Jc [1] https://github.com/commontk/CTK/blob/master/Utilities/CMake/FindDCMTK.cmake On Wed, Oct 2, 2013 at 1:42 PM, Andras Lasso > wrote: I have this annoying issue during Slicer builds as well: my nightly slicer builds usually break after a few days because after I configure other projects in CMake CTK finds DCMTK of another project instead of its own. It may be due to the find_package path finding rule 5: "Search project build trees recently configured in a CMake GUI. This can be skipped if NO_CMAKE_BUILDS_PATH is passed. It is intended for the case when a user is building multiple dependent projects one after another." (http://www.cmake.org/cmake/help/v2.8.10/ctest.html). Probably CTK should rely on rules 1-4 or disable rule 5 - or it may be possible that something else goes wrong and that's why the rule 5 kicks in. Andras From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Jean-Christophe Fillion-Robin Sent: Wednesday, October 02, 2013 11:39 AM To: Csaba Pinter Cc: CTK mailing list Subject: Re: [Ctk-developers] DCMTK_DIR is found incorrectly Hi Csaba, In CTKConfig, the variable "CMAKE_MODULE_PATH" is a CMake global variable that is empty by default. On the other hand "CTK_CMAKE_UTILITIES_DIR" should not be empty as illustrated below: $ cat ../CTKConfig.cmake | ack -i "set\(CTK_CMAKE_UTILITIES_DIR" SET(CTK_CMAKE_UTILITIES_DIR "/home/jchris/Projects/CTK/Utilities/CMake") Otherwise, you will find below the result of my experiment. When configured, CTK found the expected DCMTK. On Ubuntu 13.04 using CMake 2.8.11.2, after installing the package "python2.7-dev" doing so the following works. Note that I didn't enable CTK_ENABLE_ALL since I didn't the build system to build VTK or ITK components. Instead, I passed the following options: -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES $ git clone git at github.com:commontk/CTK $ mkdir CTK-Debug $ cd CTK-Debug $ cmake -DQT_QMAKE_EXECUTABLE:FILEPATH=/home/jchris/Support/QtSDK-1.2.1/Desktop/Qt/4.8.1/gcc/bin/qmake -DCTK_ENABLE_Python_Wrapping:BOOL=ON -DCTK_ENABLE_DICOM:BOOL=ON -DCTK_BUILD_EXAMPLES:BOOL=ON ../CTK [...] -- Enabling [CTK_LIB_DICOM/Core] because of [ CTK_ENABLE_DICOM:1 OR ( CTK_ENABLE_DICOMApplicationHosting:0 AND CTK_BUILD_EXAMPLES:1 )] evaluates to True -- Enabling [CTK_APP_ctkDICOM] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOM2] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMIndexer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMDemoSCU] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQuery] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMQueryRetrieve] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkCommandLineModuleExplorer] because of [ CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkDICOMObjectViewer] because of [ CTK_ENABLE_DICOM:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Enabling [CTK_APP_ctkSimplePythonShell] because of [ CTK_ENABLE_Python_Wrapping:1 AND CTK_BUILD_EXAMPLES:1] evaluates to True -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep.txt -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput-alldep-withext.txt -- Enabling option [CTK_LIB_DICOM/Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_Widgets] required by [ctkDICOM] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtGui] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Frontend/QtWebKit] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/LocalProcess] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Backend/FunctionPointer] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_CommandLineModules/Core] required by [ctkCommandLineModuleExplorer] -- Enabling option [CTK_LIB_Scripting/Python/Widgets] required by [ctkSimplePythonShell] -- Enabling option [CTK_LIB_Scripting/Python/Core] required by [ctkSimplePythonShell] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/Project.xml -- Found Git: /usr/bin/git (found version "1.8.1.2") -- Configuring done -- Generating done -- Build files have been written to: /home/jchris/Projects/CTK-Debug $ make -j6 [...] [ 90%] Performing configure step for 'CTK-Configure' [...] -- Found PythonInterp: /usr/bin/python (found version "2.7.4") -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.4") -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/DGraphInput.txt -- Generated: /home/jchris/Projects/CTK-Debug/CTK-build/Project.xml -- Trying to find DCMTK expecting DCMTKConfig.cmake -- Trying to find DCMTK expecting DCMTKConfig.cmake - failed -- Trying to find DCMTK relying on FindDCMTK.cmake -- Looking for include file pthread.h -- Looking fothe r include file pthread.h - found -- Looking for pthread_create -- Looking for pthread_create - not found -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- Found DCMTK: /home/jchris/Projects/CTK-Debug/CMakeExternals/Install/include/dcmtk/config -- Trying to find DCMTK relying on FindDCMTK.cmake - ok -- CTKCore: BFD support disabled -- Configuring done -- Generating done [...] -- Build files have been written to: /home/jchris/Projects/CTK-Debug/CTK-build [...] [100%] Built target CTKWidgetsCppTests [100%] Built target CTK-build $ cd CTK-build $ $ cat CMakeCache.txt | ack DCMTK_DIR\:PATH DCMTK_DIR:PATH=/home/jchris/Projects/CTK-Debug/CMakeExternals/Install Let's note that DCMTK couldn't be found using DCMTKConfig.cmake, this is explained by the fact the official DCMTK didn't integrate yet our latest and greatest contribution [1] Hth Jc [1] https://github.com/commontk/DCMTK/commit/f461865d1759854db56e4c840991c81c77e45bb9 On Wed, Oct 2, 2013 at 10:18 AM, Csaba Pinter > wrote: Hi all, I'm trying to build CTK separately, but I have problems with linking DCMTK. The way I build CTK: - Turn on CTK_BUILD_ALL - Turn on CTK_ENABLE_DICOM (I need this as I want to merge and test my changes in the CTK/Core/DICOM project) - Set the qmake executable - Configure - CMake complains about python paths, I set those manually - Configure, Generate - Build superbuild Then DCMTK is downloaded and built by the superbuild, but later on, CTK projects find a completely different DCMTK directory (in my Slicer nightly build directory). I tried to manually add the DCMTK directory to CMake, but this variable does not exist in the superbuild (it is also not passed down), and setting it to the inner CTK project doesn't work. Basically no matter what I do, the DCMTK path is set to whatever find_project finds. This is what I found in CTKConfig.cmake: # Update CMake module path so that calling "find_package(DCMTK)" works as expected # after calling "find_package(CTK)" # Ideally projects like DCMTK or PythonQt should provide both "Config" and "Use" files. set(CMAKE_MODULE_PATH ${CTK_CMAKE_UTILITIES_DIR} ${CMAKE_MODULE_PATH} ) Now the problem with this is that ${CMAKE_MODULE_PATH} is empty, so there is no chance DCMTK is found correctly. Can someone please help with this? Thanks a lot, csaba ________________________________ Csaba Pinter Medical Software Systems Engineer Laboratory for Percutanous Surgery School of Computing Queen's University Kingston, ON, Canada Email: csaba.pinter at queensu.ca Web: http://perk.cs.queensu.ca _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers -- +1 919 869 8849 -- +1 919 869 8849 -- +1 919 869 8849 _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail. -------------- next part -------------- An HTML attachment was scrubbed... URL: