[Ctk-developers] Fwd: [mitk-users] MITK with Latest CTK - problem with DCMTK
Marco Nolden
m.nolden at dkfz-heidelberg.de
Sat Apr 20 07:57:58 EDT 2013
Hi,
I did a quick test and set the DCMTK-Hash in the CTK-Superbuild to the
latest DCMTK-snapshot:
diff --git a/CMakeExternals/DCMTK.cmake b/CMakeExternals/DCMTK.cmake
index 8ea743d..d667a19 100644
--- a/CMakeExternals/DCMTK.cmake
+++ b/CMakeExternals/DCMTK.cmake
@@ -23,7 +23,7 @@ if(${add_project})
if(CTK_SUPERBUILD)
if(NOT DEFINED DCMTK_DIR)
- set(revision_tag ae3b946f6e6231)
+ set(revision_tag b2d5dd45d61b4d6bce9bfd78061836a5cdd16004)
if(${proj}_REVISION_TAG)
set(revision_tag ${${proj}_REVISION_TAG})
endif()
For testing I did a fresh superbuild with
cmake -DCTK_ENABLE_DICOM:BOOL=ON <ctk source dir>
it configures well and reports
"Full support for [CTK_ENABLE_DICOM] disabled"
but the CTK configure step fails with
CMake Error at
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:97 (message):
Please set DCMTK_DIR and re-run configure (missing:
DCMTK_config_INCLUDE_DIR DCMTK_dcmdata_INCLUDE_DIR
DCMTK_dcmimage_INCLUDE_DIR DCMTK_dcmimgle_INCLUDE_DIR
DCMTK_dcmjpeg_INCLUDE_DIR DCMTK_dcmjpls_INCLUDE_DIR
DCMTK_dcmnet_INCLUDE_DIR DCMTK_dcmpstat_INCLUDE_DIR
DCMTK_dcmqrdb_INCLUDE_DIR DCMTK_dcmsign_INCLUDE_DIR
DCMTK_dcmsr_INCLUDE_DIR
DCMTK_dcmtls_INCLUDE_DIR DCMTK_ofstd_INCLUDE_DIR DCMTK_oflog_INCLUDE_DIR
DCMTK_LIBRARIES)
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:291
(_FPHSA_FAILURE_MESSAGE)
Utilities/CMake/FindDCMTK.cmake:226 (find_package_handle_standard_args)
CMakeLists.txt:858 (find_package)
-- Configuring incomplete, errors occurred!
I could "git bisect" this, always doing a complete fresh superbuild, to:
52d9539f5e76149f3d3e7a69f19181dfd7e3dc56
Date: Thu Mar 28 16:51:19 2013 -0400
Update FindDCMTK.cmake module to support NO_MODULE mode
This will allow to build CTK against the patched-3 branch available on
github.com/commontk/DCMTK [1]
[1] https://github.com/commontk/DCMTK/tree/patched-3
All tested on Fedora 18 with a "native" cmake version 2.8.10.2 ( with a
hexacore and 24GB RAM ;) )
Best,
Marco
Am 19.04.2013 14:40, schrieb Jean-Christophe Fillion-Robin:
> Hi Matt,
>
> I don't know which change or who did these changes. But if we can find
> out, I could provide guidance so that we can add so configure check in
> order to make the feature introspection of DCMTK robust. That way, we
> would be able to include / exclude part of the CTKDCMTK library
> appropriately.
>
> Thanks
> Jc
>
>
> On Fri, Apr 19, 2013 at 2:50 AM, Clarkson, Matt <m.clarkson at ucl.ac.uk
> <mailto:m.clarkson at ucl.ac.uk>> wrote:
>
> Hi there CTK-ers,
>
> please can anyone help me out with a CTK / DCMTK problem? It
> looks to me like recent changes to CTK stop CTK working with the
> official DCMTK snapshots which are used in MITK.
> Is that right?
>
> If anyone can shed light on the way forward, Im happy to try and
> help here.
>
> Thanks
>
> Matt
>
>
> Begin forwarded message:
>
>> *From: *Marco Nolden <m.nolden at dkfz-heidelberg.de
>> <mailto:m.nolden at dkfz-heidelberg.de>>
>> *Subject: **Re: [mitk-users] MITK with Latest CTK - problem with
>> DCMTK*
>> *Date: *13 April 2013 22:38:37 BST
>> *To: *"Clarkson, Matt" <m.clarkson at ucl.ac.uk
>> <mailto:m.clarkson at ucl.ac.uk>>
>> *Cc: *mitk-users <mitk-users at lists.sourceforge.net
>> <mailto:mitk-users at lists.sourceforge.net>>
>>
>> Hi Matt,
>>
>> MITK's super build is using dcmtk-3.6.1_20120222, but there is a
>> newer snapshot here [1] and from a quick look through the Changes
>> we could upgrade if it compiles with MITK. If you like to try it
>> you could replace the URL in CMakeExternals/DCMTK.cmake (and
>> remove or adapt the URL_MD5 line).
>>
>> I'm not sure though that the CTK change you mention will work
>> with that snapshot. CTK by default uses a forked version of DCMTK
>> and there has been some activity lately. IIRC we agreed that CTK
>> _should_ always build with the official DCMTK snapshots as well,
>> but I'm afraid that doesn't get tested regularly. So if that is
>> broken we should contact JC if the changes can be made in a
>> compatible way.
>>
>> If you could confirm that MITK builds with the newer snapshot we
>> could upgrade this on our side. Unfortunately I can't test it
>> myself at the moment.
>>
>> Upgrading the CTK version can be more tricky, Sascha could maybe
>> comment on that. If you are just interested in the slider tick
>> change, we could also use a special version, did that before.
>>
>> Best,
>>
>> Marco
>>
>> [1]:
>> http://dicom.offis.de/download/dcmtk/snapshot/dcmtk-3.6.1_20121102.tar.gz
>>
>>
>>
>> Am 04.04.2013 21:06, schrieb Clarkson, Matt:
>>> Hi there,
>>>
>>> Following the merging of CTK issue #313 to CTK master (CTK
>>> commit 099a88bb24), I then tried to update my MITK to compile
>>> with this version of CTK, so I could pick up Miklos's new slider
>>> tick interval.
>>> However, in the CTK master branch, commit 52d9539f5e, which is 3
>>> before the latest, causes CTK to not build using the DCMTK
>>> version that MITK is using.
>>>
>>> So, it looks to me like MITK will need to consider upgrading
>>> DCMTK before they can move to the latest CTK, which is the
>>> reason I post here, instead of the CTK mailing list.
>>>
>>> However, I don't really understand what the reason for the CTK
>>> change is, or why CTK has a different fork of DCMTK, or what
>>> exactly is the version of DCMTK that MITK is using -
>>> dcmtk-3.6.1_20120222.tar.gz, so Im a bit stuck.
>>>
>>> Can anyone in MITK-land shed a light on a way forward?
>>>
>>> Thanks
>>>
>>> Matt
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Minimize network downtime and maximize team effectiveness.
>>> Reduce network management and security costs.Learn how to hire
>>> the most talented Cisco Certified professionals. Visit the
>>> Employer Resources Portal
>>> http://www.cisco.com/web/learning/employer_resources/index.html
>>> _______________________________________________
>>> mitk-users mailing list
>>> mitk-users at lists.sourceforge.net
>>> <mailto:mitk-users at lists.sourceforge.net>
>>> https://lists.sourceforge.net/lists/listinfo/mitk-users
>>
>>
>
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org <mailto:Ctk-developers at commontk.org>
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
>
>
> --
> +1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20130420/88b1c5d2/attachment.html>
More information about the Ctk-developers
mailing list