[Ctk-developers] QtTesting in master

Sat May 12 18:22:54 UTC 2012

Agree on the fact we could have a better name :) .. we already spend some
time brainstorming about it .. and didn't come with a better alternative.

The idea with QtTesting is that it doesn't have to be related with
"Testing" of CTK. It's a library that can be enabled independently of
BUILD_TESTING.

It provides functionality to record actions and replay them. Something like
"macros".

Jc

On Sat, May 12, 2012 at 1:57 PM, Sascha Zelzer
<s.zelzer at dkfz-heidelberg.de>wrote:

>  Hi,
>
> I see, that explains it. Since the names are the same, I thought the code
> from the external project has been moved into CTK.
>
> Maybe we could still find another name for the CTK QtTesting library?
> Since Qt is not only about widgets, maybe something with "widget" in it...?
> I also believe that we once agreed to drop the "Qt" string from library
> names since CTK depends on Qt anyway, but since it is an
> extension/customization for QtTesting, I guess it could make sense to have
> it in that case.
>
> We could also consider putting the library under Libs/Testing/<libname>
> (instead of Libs/QtTesting), for example
> Libs/Testing/QtTestingWidgetExtensions.
>
> Just a couple of thoughts.
>
> Thanks,
>
> Sascha
>
>
> On 05/12/2012 07:25 PM, Julien Finet wrote:
>
> Hi Sascha,
> Thanks for taking the time to review the branch.
> Concerning your comments, I think there is a misunderstanding. QtTesting
> is a library that lives in its own library. In order to work within CTK
> (external dependency), some CTK widgets have custom recorder and players.
> So if CTK_USE_QTTESTING is ON the QtTesting project is downloaded and
> built. Within CTK, the Libs/QtTesting directory contains CTK customization
> for QtTesting.
> We will create a wiki documentation page  to further detail technicalities.
> Thanks,
> Julien.
>
> On Sat, May 12, 2012 at 7:36 AM, Sascha Zelzer <
> s.zelzer at dkfz-heidelberg.de> wrote:
>
>>  Hi,
>>
>> +1 one from me (but see my comments below)
>>
>>
>> Thanks for putting so much effort into this, it looks really good! (I
>> just skimmed through the code changes...)
>>
>> There is one small issue though: In the current CTK branch [3] you seem
>> to have some left-overs from the past were you referenced QtTesting as an
>> external project. If I understood the changes correctly, you should
>> probably remove this line:
>>
>> https://github.com/commontk/CTK/compare/master...qttesting#L11L724
>>
>> and also remove that file:
>>
>> https://github.com/commontk/CTK/compare/master...qttesting#diff-10
>>
>>
>> Thanks for your work,
>>
>> Sascha
>>
>>
>>
>> On 05/10/2012 11:23 PM, Julien Finet wrote:
>>
>> Hi CTKers,
>>
>>  We have been working toward integrating the QtTesting framework [1]
>> into CTK. Kudos to Benjamin for his hard work !
>>
>> The Qt testing framework is an effort from the ParaView team which now
>> resides in its own repository [2a][2b].
>> Our integration work is currently in a QtTesting branch [3] in CTK and is
>> currently in use by Slicer (builds and package fine on all our dashboard
>> machines)
>>
>>  It is still work in progress and more work will happen in the coming
>> weeks [4]
>> However we would like to merge the branch into CTK master in order to
>> keep working on other CTK issues for Slicer.
>> Indeed Slicer currently points to the QtTesting head and we'd like to go
>> back to pointing on master.
>>
>>  Does anyone think we shouldn't merge or has any comment?
>>
>>  Thanks,
>> Julien.
>>
>>  [1] http://paraview.org/Wiki/Testing_design
>> [2a] http://paraview.org/gitweb?p=QtTesting.git
>> [2b] https://github.com/commontk/QtTesting
>> [3] https://github.com/commontk/CTK/tree/qttesting
>> [4]
>> https://github.com/commontk/CTK/issues?direction=desc&labels=Testing&page=1&sort=created&state=open
>>
>>
>>
>
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>

-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20120512/2d80489e/attachment.htm>