From curzio at camelotbio.com Mon Mar 5 15:14:21 2012 From: curzio at camelotbio.com (Curzio Basso) Date: Mon, 5 Mar 2012 16:14:21 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: References: Message-ID: <95F60058-E857-4211-8A20-6069D554C096@camelotbio.com> Hi Michael, thanks for your help. > This problem has been fixed meanwhile in DCMTK (see commit [1]). You > might try the latest DCMTK code or apply a local patch. Indeed, using the last DCMTK snapshot solved the compilation problem, but unfortunately it seems to have raised another issue... What I did was to: - substitute the original DCMTK directory that gets cloned during the superbuild with the most recent snapshot - issue a 'make clean' in the DCMTK-build directory (if I clean in CTK-build the DCMTK directory gets cloned anew) - make The compilation now runs fine, but apparently at the end it tries to install dcmtk into a system directory, therefore yielding an error, rather than installing it locally (or not installing at all): Linking CXX executable ../../bin/dcmpssnd [100%] Built target dcmpssnd Install the project... -- Install configuration: "Debug" CMake Error at cmake_install.cmake:33 (FILE): file cannot create directory: /include/dcmtk/config. Maybe need administrative privileges. So I assume that the right way to proceed is to apply the patch to the original CTK branch of DCMTK, is that correct? Is there a way to patch all files (hope so), or do I have to manually download and apply a patch for each file (boooo)? Thanks again for your patience, curzio -- Curzio Basso, Ph.D CAMELOT Biomedical Systems Srl Via Greto di Cornigliano 6R 16152 Genova, Italy +39-010-8695741 (office) +39-010-8695742 (fax) +39-349-5972038 (mobile) From onken at offis.de Mon Mar 5 15:39:11 2012 From: onken at offis.de (Michael Onken) Date: Mon, 05 Mar 2012 16:39:11 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <95F60058-E857-4211-8A20-6069D554C096@camelotbio.com> References: <95F60058-E857-4211-8A20-6069D554C096@camelotbio.com> Message-ID: <4F54DE1F.6080102@offis.de> Hi Curzio, On 05.03.2012 16:14, Curzio Basso wrote: > What I did was to: - substitute the original DCMTK directory that > gets cloned during the superbuild with the most recent snapshot > [...] > So I assume that the right way to proceed is to apply the patch to > the original CTK branch of DCMTK, is that correct? Is there a way to > patch all files (hope so), or do I have to manually download and > apply a patch for each file (boooo)? The superbuild checks out a specific, "older" DCMTK commit. If you look into /CMakeExternals/DCMTK.cmake there is a line "set(revision_tag 085525e643cab5ac82)". Exchange that with an up-to-date revision tag, e.g. try the latest one: "d358efbc97c12e3a3a". As far as I know (did not try for a while) CTK should compile and run with the latest DCMTK code; at least it's worth a try since it's a rather clean solution for your problem. Good luck, Michael -- Dipl.-Inform. Michael Onken FuE Bereich Gesundheit | R&D Division Health OFFIS FuE Bereich Gesundheit | R&D Division Health Escherweg 2 - 26121 Oldenburg - Germany Phone/Fax.: +49 441 9722-149/111 E-Mail: onken at offis.de URL: http://www.offis.de From s.zelzer at dkfz-heidelberg.de Mon Mar 5 15:58:34 2012 From: s.zelzer at dkfz-heidelberg.de (Sascha Zelzer) Date: Mon, 05 Mar 2012 16:58:34 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <4F54DE1F.6080102@offis.de> References: <95F60058-E857-4211-8A20-6069D554C096@camelotbio.com> <4F54DE1F.6080102@offis.de> Message-ID: <4F54E2AA.10700@dkfz-heidelberg.de> Hi, instead of modifying the CTK sources, you should just set the CTK superbuild CMake variable DCMTK_DIR to the install directory of your externally built DCMTK. Best, Sascha On 03/05/2012 04:39 PM, Michael Onken wrote: > Hi Curzio, > > On 05.03.2012 16:14, Curzio Basso wrote: > >> What I did was to: - substitute the original DCMTK directory that >> gets cloned during the superbuild with the most recent snapshot >> [...] >> So I assume that the right way to proceed is to apply the patch to >> the original CTK branch of DCMTK, is that correct? Is there a way to >> patch all files (hope so), or do I have to manually download and >> apply a patch for each file (boooo)? > The superbuild checks out a specific, "older" DCMTK commit. If you look > into /CMakeExternals/DCMTK.cmake there is a line > > "set(revision_tag 085525e643cab5ac82)". > > Exchange that with an up-to-date revision tag, e.g. try the latest one: > "d358efbc97c12e3a3a". > > As far as I know (did not try for a while) CTK should compile and run > with the latest DCMTK code; at least it's worth a try since it's a > rather clean solution for your problem. > > Good luck, > Michael > From jchris.fillionr at kitware.com Mon Mar 5 16:31:05 2012 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Mon, 5 Mar 2012 08:31:05 -0800 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <4F54E2AA.10700@dkfz-heidelberg.de> References: <95F60058-E857-4211-8A20-6069D554C096@camelotbio.com> <4F54DE1F.6080102@offis.de> <4F54E2AA.10700@dkfz-heidelberg.de> Message-ID: Hi Curzio, I would also suggest to look at the following files to find out which options CTK expects DCMTK to be built with. I will also notice the CMAKE_INSTALL_PREFIX option. See https://github.com/commontk/CTK/blob/master/CMakeExternals/DCMTK.cmake#L51 and https://github.com/commontk/CTK/blob/master/CMake/ctkBlockCheckDependencies.cmake#L46 Hth Jc On Mon, Mar 5, 2012 at 7:58 AM, Sascha Zelzer wrote: > Hi, > > instead of modifying the CTK sources, you should just set the CTK > superbuild CMake variable DCMTK_DIR to the install directory of your > externally built DCMTK. > > Best, > Sascha > > > On 03/05/2012 04:39 PM, Michael Onken wrote: > >> Hi Curzio, >> >> On 05.03.2012 16:14, Curzio Basso wrote: >> >> What I did was to: - substitute the original DCMTK directory that >>> gets cloned during the superbuild with the most recent snapshot >>> [...] >>> So I assume that the right way to proceed is to apply the patch to >>> the original CTK branch of DCMTK, is that correct? Is there a way to >>> patch all files (hope so), or do I have to manually download and >>> apply a patch for each file (boooo)? >>> >> The superbuild checks out a specific, "older" DCMTK commit. If you look >> into /CMakeExternals/DCMTK.cmake there is a line >> >> "set(revision_tag 085525e643cab5ac82)". >> >> Exchange that with an up-to-date revision tag, e.g. try the latest one: >> "d358efbc97c12e3a3a". >> >> As far as I know (did not try for a while) CTK should compile and run >> with the latest DCMTK code; at least it's worth a try since it's a >> rather clean solution for your problem. >> >> Good luck, >> Michael >> >> > ______________________________**_________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-**bin/mailman/listinfo/ctk-**developers > -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From julien.finet at kitware.com Mon Mar 5 16:37:23 2012 From: julien.finet at kitware.com (Julien Finet) Date: Mon, 5 Mar 2012 11:37:23 -0500 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: References: <95F60058-E857-4211-8A20-6069D554C096@camelotbio.com> <4F54DE1F.6080102@offis.de> <4F54E2AA.10700@dkfz-heidelberg.de> Message-ID: Curzio, And because you might get some conflicts between CTK and the last version of DCMTK, you might want to consider working from this branch: https://github.com/finetjul/CTK/tree/dcmtk-trunk j. On Mon, Mar 5, 2012 at 11:31 AM, Jean-Christophe Fillion-Robin < jchris.fillionr at kitware.com> wrote: > Hi Curzio, > > I would also suggest to look at the following files to find out which > options CTK expects DCMTK to be built with. I will also notice the CMAKE_INSTALL_PREFIX > option. > > See > https://github.com/commontk/CTK/blob/master/CMakeExternals/DCMTK.cmake#L51 > > and > > > https://github.com/commontk/CTK/blob/master/CMake/ctkBlockCheckDependencies.cmake#L46 > > Hth > Jc > > On Mon, Mar 5, 2012 at 7:58 AM, Sascha Zelzer > wrote: > >> Hi, >> >> instead of modifying the CTK sources, you should just set the CTK >> superbuild CMake variable DCMTK_DIR to the install directory of your >> externally built DCMTK. >> >> Best, >> Sascha >> >> >> On 03/05/2012 04:39 PM, Michael Onken wrote: >> >>> Hi Curzio, >>> >>> On 05.03.2012 16:14, Curzio Basso wrote: >>> >>> What I did was to: - substitute the original DCMTK directory that >>>> gets cloned during the superbuild with the most recent snapshot >>>> [...] >>>> So I assume that the right way to proceed is to apply the patch to >>>> the original CTK branch of DCMTK, is that correct? Is there a way to >>>> patch all files (hope so), or do I have to manually download and >>>> apply a patch for each file (boooo)? >>>> >>> The superbuild checks out a specific, "older" DCMTK commit. If you look >>> into /CMakeExternals/DCMTK.cmake there is a line >>> >>> "set(revision_tag 085525e643cab5ac82)". >>> >>> Exchange that with an up-to-date revision tag, e.g. try the latest one: >>> "d358efbc97c12e3a3a". >>> >>> As far as I know (did not try for a while) CTK should compile and run >>> with the latest DCMTK code; at least it's worth a try since it's a >>> rather clean solution for your problem. >>> >>> Good luck, >>> Michael >>> >>> >> ______________________________**_________________ >> Ctk-developers mailing list >> Ctk-developers at commontk.org >> http://public.kitware.com/cgi-**bin/mailman/listinfo/ctk-**developers >> > > > > -- > +1 919 869 8849 > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From curzio at camelotbio.com Tue Mar 6 09:18:46 2012 From: curzio at camelotbio.com (Curzio Basso) Date: Tue, 6 Mar 2012 10:18:46 +0100 Subject: [Ctk-developers] problem compiling dcmtk Message-ID: Hi! First of all, thanks to everyone for the useful comments and help. After some tinkering I opted for Julien's solution, since: - dcmtk 3.6.0 does not compile on mac os x with xcode 4.3; - the latest dcmtk snapshot does compile, but does not get along well with ctk. Although the dcmtk-trunk branch seems to have problems with the DICOMAppHosting plugins, which forced me to disable some other stuff, I think I can live with that while I wait for ctk to switch to a newer dcmtk snapshot. Related to this: is the dcmtk-trunk branch... how shall I put it... officially integrated in CTK development? Is it reasonable to expect that it will be mantained in the next 6 months, or 1 year? Thanks again for the help! curzio -- Curzio Basso, Ph.D CAMELOT Biomedical Systems Srl Via Greto di Cornigliano 6R 16152 Genova, Italy +39-010-8695741 (office) +39-010-8695742 (fax) +39-349-5972038 (mobile) From onken at offis.de Tue Mar 6 09:29:03 2012 From: onken at offis.de (Michael Onken) Date: Tue, 06 Mar 2012 10:29:03 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: References: Message-ID: <4F55D8DF.6050604@offis.de> Hi, On 06.03.2012 10:18, Curzio Basso wrote: > Related to this: is the dcmtk-trunk branch... how shall I put it... > officially integrated in CTK development? Is it reasonable to expect > that it will be mantained in the next 6 months, or 1 year? We had some intensive discussion about that and there are many pros and cons to forward to the latest snapshot, or open a branch. Most people prefer an official, full release of DCMTK and then upgrade CTK to that. Our plan is to have such a release this year. Currently, we may get support from a third party; then it could be around June, otherwise I would aim at winter (traditionally we do releases around Christmas time:-)) And yes, it would be nice to have more releases, I know! If the main CTK developers like to forward _before_ such a release this is of course fine from our side. I don't know whether people like to reanimate that discussion ;) Best, Michael -- Dipl.-Inform. Michael Onken FuE Bereich Gesundheit | R&D Division Health OFFIS FuE Bereich Gesundheit | R&D Division Health Escherweg 2 - 26121 Oldenburg - Germany Phone/Fax.: +49 441 9722-149/111 E-Mail: onken at offis.de URL: http://www.offis.de From curzio at camelotbio.com Tue Mar 6 11:03:08 2012 From: curzio at camelotbio.com (Curzio Basso) Date: Tue, 6 Mar 2012 12:03:08 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <4F55D8DF.6050604@offis.de> References: <4F55D8DF.6050604@offis.de> Message-ID: Hello Michael, > We had some intensive discussion about that and there are many pros and > cons to forward to the latest snapshot, or open a branch. Most people > prefer an official, full release of DCMTK and then upgrade CTK to that. I understand and agree, my case is a bit unfortunate... > Our plan is to have such a release this year. Currently, we may get > support from a third party; then it could be around June, otherwise I > would aim at winter (traditionally we do releases around Christmas > time:-)) And yes, it would be nice to have more releases, I know! Ok, so there should be a new dcmtk release at most in winter, and ctk would upgrade (shortly?) afterwards. > If the main CTK developers like to forward _before_ such a release this > is of course fine from our side. I don't know whether people like > to reanimate that discussion ;) I think you guys already studied and discussed the problem long enough, and I don't think I can provide a new angle to that. Personally, I think I can wait for the next release. Hoping that it comes in June: it will be a birthday present, rather than a christmas one! best curzio -- Curzio Basso, Ph.D CAMELOT Biomedical Systems Srl Via Greto di Cornigliano 6R 16152 Genova, Italy +39-010-8695741 (office) +39-010-8695742 (fax) +39-349-5972038 (mobile) From julien.finet at kitware.com Tue Mar 6 13:38:08 2012 From: julien.finet at kitware.com (Julien Finet) Date: Tue, 6 Mar 2012 08:38:08 -0500 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: References: <4F55D8DF.6050604@offis.de> Message-ID: Glad to hear it works for you Curzio. For Slicer, we will have to compile DCMTK as shared in order to avoid some obscure problems. This work is likely to be done by June. Curzio, feel free to make pull requests if you need to. I can also publish the dcmtk-trunk branch into the CTK repo (not just on finetjul). Julien. On Tue, Mar 6, 2012 at 6:03 AM, Curzio Basso wrote: > > Hello Michael, > > > We had some intensive discussion about that and there are many pros and > > cons to forward to the latest snapshot, or open a branch. Most people > > prefer an official, full release of DCMTK and then upgrade CTK to that. > > I understand and agree, my case is a bit unfortunate... > > > Our plan is to have such a release this year. Currently, we may get > > support from a third party; then it could be around June, otherwise I > > would aim at winter (traditionally we do releases around Christmas > > time:-)) And yes, it would be nice to have more releases, I know! > > Ok, so there should be a new dcmtk release at most in winter, and ctk > would upgrade (shortly?) afterwards. > > > If the main CTK developers like to forward _before_ such a release this > > is of course fine from our side. I don't know whether people like > > to reanimate that discussion ;) > > I think you guys already studied and discussed the problem long enough, > and I don't think I can provide a new angle to that. Personally, I think > I can wait for the next release. Hoping that it comes in June: it will be a > birthday present, rather than a christmas one! > > best > curzio > > -- > Curzio Basso, Ph.D > CAMELOT Biomedical Systems Srl > Via Greto di Cornigliano 6R > 16152 Genova, Italy > > +39-010-8695741 (office) > +39-010-8695742 (fax) > +39-349-5972038 (mobile) > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: From m.nolden at dkfz-heidelberg.de Tue Mar 6 14:51:10 2012 From: m.nolden at dkfz-heidelberg.de (Marco Nolden) Date: Tue, 06 Mar 2012 15:51:10 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <4F4E473E.9070404@offis.de> References: <78F2BADB-3198-43D8-86A2-0ABCBA9796E5@camelotbio.com> <4F4E473E.9070404@offis.de> Message-ID: <4F56245E.90308@dkfz.de> On 02/29/2012 04:41 PM, Michael Onken wrote: > Hi Curzio, > [...] > > This problem has been fixed meanwhile in DCMTK (see commit [1]). You > might try the latest DCMTK code or apply a local patch. > > Best regards, > Michael > > [1] > http://git.dcmtk.org/web?p=dcmtk.git;a=commitdiff;h=dbadc0d8f3760f65504406c8b2cb8633f868a258 > Hi Michael, for an (internal) clang compatibility test of MITK I also used DCMTK 3.6.0 with a cherry-pick of this commit. Since we want to support clang officially before the next DCMTK release I was wondering where to publish this version. Or do you think it would be possible to integrate a DCMTK 3.6.0 with dbadc0d8f3 applied in the official DCMTK repo? Or would you prefer that we put this somewhere else, maybe on github/commontk/DCMTK like Julien suggested? The commontk/DCMTK though is currently a bit outdated I'm afraid. IIRC it's based on DCMTK 3.5.4 with two commits by Steve and a few backports to fix compiler issues which are probably included in 3.6 anyway. Best, Marco -- ---------------------------------------------------------------------- Dipl.-Inform. Med. Marco Nolden Deutsches Krebsforschungszentrum (German Cancer Research Center) Div. Medical & Biological Informatics Tel: (+49) 6221-42 2325 Im Neuenheimer Feld 280 Fax: (+49) 6221-42 2345 D-69120 Heidelberg eMail: M.Nolden at dkfz.de From lasso at cs.queensu.ca Tue Mar 6 15:13:58 2012 From: lasso at cs.queensu.ca (Andras Lasso) Date: Tue, 6 Mar 2012 10:13:58 -0500 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <4F56245E.90308@dkfz.de> References: <78F2BADB-3198-43D8-86A2-0ABCBA9796E5@camelotbio.com> <4F4E473E.9070404@offis.de> <4F56245E.90308@dkfz.de> Message-ID: <00a001ccfbab$c47827d0$4d687770$@queensu.ca> Hi guys, Just one more piece of information that may be relevant for this discussion: We are working on adding radiotherapy extensions to Slicer4 (https://www.assembla.com/spaces/sparkit/wiki/SlicerRT) and due to the outdated DCMTK version in CTK (that doesn't contain RT objects) we have to work on a clone of CTK that uses a recent DCMTK. This also means that we cannot make the results of our work available to the whole Slicer community as standard extensions until CTK moves to a recent DCMTK version. So, for us upgrading to a more recent DCMTK in CTK would be very important. June would be OK, but the earlier the better. Waiting till Christmas would very much hinder our project. Thank you for considering this. Let me know if we can help with anything (testing, etc.). Andras -----Original Message----- From: ctk-developers-bounces at commontk.org [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Marco Nolden Sent: 2012-March-06 9:51 AM To: Michael Onken Cc: OFFIS DICOM Team; ctk-developers at commontk.org Subject: Re: [Ctk-developers] problem compiling dcmtk On 02/29/2012 04:41 PM, Michael Onken wrote: > Hi Curzio, > [...] > > This problem has been fixed meanwhile in DCMTK (see commit [1]). You > might try the latest DCMTK code or apply a local patch. > > Best regards, > Michael > > [1] > http://git.dcmtk.org/web?p=dcmtk.git;a=commitdiff;h=dbadc0d8f3760f65504406c8 b2cb8633f868a258 > Hi Michael, for an (internal) clang compatibility test of MITK I also used DCMTK 3.6.0 with a cherry-pick of this commit. Since we want to support clang officially before the next DCMTK release I was wondering where to publish this version. Or do you think it would be possible to integrate a DCMTK 3.6.0 with dbadc0d8f3 applied in the official DCMTK repo? Or would you prefer that we put this somewhere else, maybe on github/commontk/DCMTK like Julien suggested? The commontk/DCMTK though is currently a bit outdated I'm afraid. IIRC it's based on DCMTK 3.5.4 with two commits by Steve and a few backports to fix compiler issues which are probably included in 3.6 anyway. Best, Marco -- ---------------------------------------------------------------------- Dipl.-Inform. Med. Marco Nolden Deutsches Krebsforschungszentrum (German Cancer Research Center) Div. Medical & Biological Informatics Tel: (+49) 6221-42 2325 Im Neuenheimer Feld 280 Fax: (+49) 6221-42 2345 D-69120 Heidelberg eMail: M.Nolden at dkfz.de _______________________________________________ Ctk-developers mailing list Ctk-developers at commontk.org http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers From m.nolden at dkfz-heidelberg.de Tue Mar 6 16:18:06 2012 From: m.nolden at dkfz-heidelberg.de (Marco Nolden) Date: Tue, 06 Mar 2012 17:18:06 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <00a001ccfbab$c47827d0$4d687770$@queensu.ca> References: <78F2BADB-3198-43D8-86A2-0ABCBA9796E5@camelotbio.com> <4F4E473E.9070404@offis.de> <4F56245E.90308@dkfz.de> <00a001ccfbab$c47827d0$4d687770$@queensu.ca> Message-ID: <4F5638BE.2060501@dkfz-heidelberg.de> Hi Andras, we had a long discussion about this a few months ago. We did not come to a final decision, but I think the most preferable way of integration would be to support the official DCMTK release at least on build level, e.g. disabling all functionality that depends on newer versions. This would allow people to use CTK even if they prefer to use an official DCMTK release or already are using DCMTK in their projects. From the MITK point of view and what I heard from our users it would be ok to use snapshot releases, as long as they are somehow "official", e.g. announced by OFFIS. I found http://dicom.offis.de/download/dcmtk/snapshot/ with a snapshot from February. @Michael: is this somehow "official", what are the criteria for releasing a snapshot? Best, Marco On 03/06/2012 04:13 PM, Andras Lasso wrote: > Hi guys, > > Just one more piece of information that may be relevant for this discussion: > We are working on adding radiotherapy extensions to Slicer4 > (https://www.assembla.com/spaces/sparkit/wiki/SlicerRT) and due to the > outdated DCMTK version in CTK (that doesn't contain RT objects) we have to > work on a clone of CTK that uses a recent DCMTK. This also means that we > cannot make the results of our work available to the whole Slicer community > as standard extensions until CTK moves to a recent DCMTK version. > > So, for us upgrading to a more recent DCMTK in CTK would be very important. > June would be OK, but the earlier the better. Waiting till Christmas would > very much hinder our project. > > Thank you for considering this. Let me know if we can help with anything > (testing, etc.). > Andras > > > -----Original Message----- > From: ctk-developers-bounces at commontk.org > [mailto:ctk-developers-bounces at commontk.org] On Behalf Of Marco Nolden > Sent: 2012-March-06 9:51 AM > To: Michael Onken > Cc: OFFIS DICOM Team; ctk-developers at commontk.org > Subject: Re: [Ctk-developers] problem compiling dcmtk > > On 02/29/2012 04:41 PM, Michael Onken wrote: >> Hi Curzio, >> > [...] >> >> This problem has been fixed meanwhile in DCMTK (see commit [1]). You >> might try the latest DCMTK code or apply a local patch. >> >> Best regards, >> Michael >> >> [1] >> > http://git.dcmtk.org/web?p=dcmtk.git;a=commitdiff;h=dbadc0d8f3760f65504406c8 > b2cb8633f868a258 >> > > Hi Michael, > > for an (internal) clang compatibility test of MITK I also used DCMTK > 3.6.0 with a cherry-pick of this commit. Since we want to support clang > officially before the next DCMTK release I was wondering where to > publish this version. Or do you think it would be possible to integrate > a DCMTK 3.6.0 with dbadc0d8f3 applied in the official DCMTK repo? Or > would you prefer that we put this somewhere else, maybe on > github/commontk/DCMTK like Julien suggested? > > The commontk/DCMTK though is currently a bit outdated I'm afraid. IIRC > it's based on DCMTK 3.5.4 with two commits by Steve and a few backports > to fix compiler issues which are probably included in 3.6 anyway. > > Best, > > Marco > > > > > > -- ---------------------------------------------------------------------- Dipl.-Inform. Med. Marco Nolden Deutsches Krebsforschungszentrum (German Cancer Research Center) Div. Medical & Biological Informatics Tel: (+49) 6221-42 2325 Im Neuenheimer Feld 280 Fax: (+49) 6221-42 2345 D-69120 Heidelberg eMail: M.Nolden at dkfz.de From onken at offis.de Tue Mar 6 17:58:42 2012 From: onken at offis.de (Michael Onken) Date: Tue, 06 Mar 2012 18:58:42 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <4F5638BE.2060501@dkfz-heidelberg.de> References: <78F2BADB-3198-43D8-86A2-0ABCBA9796E5@camelotbio.com> <4F4E473E.9070404@offis.de> <4F56245E.90308@dkfz.de> <00a001ccfbab$c47827d0$4d687770$@queensu.ca> <4F5638BE.2060501@dkfz-heidelberg.de> Message-ID: <4F565052.8020800@offis.de> Hi everybody, On 06.03.2012 17:18, Marco Nolden wrote: > e.g. announced by OFFIS. I found > http://dicom.offis.de/download/dcmtk/snapshot/ with a snapshot from > February. @Michael: is this somehow "official", what are the > criteria for releasing a snapshot? This is official. For a few years now we release snapshots quite frequently every few months. These - at least compile on XP 32 Bit and Visual Studio 2008 as well as on Debian Linux 64 Bit with gcc 4.1 - are released if a "certain amount" of important bug fixes have been been integrated - and are often released after a larger feature has been fully implemented. We announce those snapshots on the super popular wiki page: http://support.dcmtk.org/wiki/dcmtk/news/start We also add the commit hash, if you like (done now for the snapshots since 3.6.0). The only thing that is more up-to-date than a snapshot is the public git repository which is updated nearly on a daily basis but may contain incomplete fixes or features. @Andras: The dcmrt module is not even in the snapshot or visible in git. We give it to interested parties. Currently, somebody is taking care of it to make it available; I guess it's in the next snapshot or the one afterwards. I'm sorry you cannot share it with everybody immediately. If this is really important to you, we find a solution. I think I said it in earlier discussions: It is a good idea to refer to the snapshots from CTK. If they do not compile on some platforms (MINGW or the like), send us patches. We are always happy to fix it :) We also (really) should setup a dashboard you guys could send build results to, I know... If you like hosting a "copy" of dcmtk on github, e.g. to apply patches that are not yet integrated into the official DCMTK code, it's fine for us. Of course we should avoid that code on github drifts away into a serious fork. We would prefer not to branch on our side, for different reasons (technical and non-technical), nor we like tagging the snapshots. Hope this helps, Michael -- Dipl.-Inform. Michael Onken FuE Bereich Gesundheit | R&D Division Health OFFIS FuE Bereich Gesundheit | R&D Division Health Escherweg 2 - 26121 Oldenburg - Germany Phone/Fax.: +49 441 9722-149/111 E-Mail: onken at offis.de URL: http://www.offis.de From m.nolden at dkfz-heidelberg.de Tue Mar 6 18:10:57 2012 From: m.nolden at dkfz-heidelberg.de (Marco Nolden) Date: Tue, 06 Mar 2012 19:10:57 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <4F565052.8020800@offis.de> References: <78F2BADB-3198-43D8-86A2-0ABCBA9796E5@camelotbio.com> <4F4E473E.9070404@offis.de> <4F56245E.90308@dkfz.de> <00a001ccfbab$c47827d0$4d687770$@queensu.ca> <4F5638BE.2060501@dkfz-heidelberg.de> <4F565052.8020800@offis.de> Message-ID: <4F565331.1090005@dkfz-heidelberg.de> Hi Michael, thanks for the clarification. I wasn't aware of that wiki page. For me it would be a perfect solution to stick to these snapshots within CTK. Do they include some version info that makes them distinguishable, either on the CMake side or as c-style define? Best Marco On 03/06/2012 06:58 PM, Michael Onken wrote: > Hi everybody, > > On 06.03.2012 17:18, Marco Nolden wrote: >> e.g. announced by OFFIS. I found >> http://dicom.offis.de/download/dcmtk/snapshot/ with a snapshot from >> February. @Michael: is this somehow "official", what are the >> criteria for releasing a snapshot? > > This is official. For a few years now we release snapshots quite > frequently every few months. These > - at least compile on XP 32 Bit and Visual Studio 2008 as well as on > Debian Linux 64 Bit with gcc 4.1 > - are released if a "certain amount" of important bug fixes have been > been integrated > - and are often released after a larger feature has been > fully implemented. > > We announce those snapshots on the super popular wiki page: > > http://support.dcmtk.org/wiki/dcmtk/news/start > > We also add the commit hash, if you like (done now for the snapshots > since 3.6.0). The only thing that is more up-to-date than a snapshot is > the public git repository which is updated nearly on a daily basis but > may contain incomplete fixes or features. > > @Andras: The dcmrt module is not even in the snapshot or visible in git. > We give it to interested parties. Currently, somebody is taking care of > it to make it available; I guess it's in the next snapshot or the one > afterwards. I'm sorry you cannot share it with everybody immediately. If > this is really important to you, we find a solution. > > I think I said it in earlier discussions: It is a good idea to refer to > the snapshots from CTK. If they do not compile on some platforms (MINGW > or the like), send us patches. We are always happy to fix it :) We also > (really) should setup a dashboard you guys could send build results to, > I know... > > If you like hosting a "copy" of dcmtk on github, e.g. to apply patches > that are not yet integrated into the official DCMTK code, it's fine for > us. Of course we should avoid that code on github drifts away into a > serious fork. > > We would prefer not to branch on our side, for different reasons > (technical and non-technical), nor we like tagging the snapshots. > > Hope this helps, > Michael > -- ---------------------------------------------------------------------- Dipl.-Inform. Med. Marco Nolden Deutsches Krebsforschungszentrum (German Cancer Research Center) Div. Medical & Biological Informatics Tel: (+49) 6221-42 2325 Im Neuenheimer Feld 280 Fax: (+49) 6221-42 2345 D-69120 Heidelberg eMail: M.Nolden at dkfz.de From lasso at cs.queensu.ca Tue Mar 6 19:32:49 2012 From: lasso at cs.queensu.ca (Andras Lasso) Date: Tue, 6 Mar 2012 14:32:49 -0500 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <4F565052.8020800@offis.de> References: <78F2BADB-3198-43D8-86A2-0ABCBA9796E5@camelotbio.com> <4F4E473E.9070404@offis.de> <4F56245E.90308@dkfz.de> <00a001ccfbab$c47827d0$4d687770$@queensu.ca> <4F5638BE.2060501@dkfz-heidelberg.de> <4F565052.8020800@offis.de> Message-ID: <011801ccfbcf$ee3981d0$caac8570$@cs.queensu.ca> Hello Michael, Having the dcmrt module is absolutely essential for us, but we can wait for it till June. That would allow us to integrate all RT related work into the Slicer trunk / extensions during the NA-MIC summer project week. thanks Andras -----Original Message----- From: Michael Onken [mailto:onken at offis.de] Sent: Tuesday, March 06, 2012 12:59 PM To: Marco Nolden Cc: Andras Lasso; 'Julien Finet'; 'OFFIS DICOM Team'; ctk-developers at commontk.org Subject: Re: [Ctk-developers] problem compiling dcmtk Hi everybody, On 06.03.2012 17:18, Marco Nolden wrote: > e.g. announced by OFFIS. I found > http://dicom.offis.de/download/dcmtk/snapshot/ with a snapshot from > February. @Michael: is this somehow "official", what are the criteria > for releasing a snapshot? This is official. For a few years now we release snapshots quite frequently every few months. These - at least compile on XP 32 Bit and Visual Studio 2008 as well as on Debian Linux 64 Bit with gcc 4.1 - are released if a "certain amount" of important bug fixes have been been integrated - and are often released after a larger feature has been fully implemented. We announce those snapshots on the super popular wiki page: http://support.dcmtk.org/wiki/dcmtk/news/start We also add the commit hash, if you like (done now for the snapshots since 3.6.0). The only thing that is more up-to-date than a snapshot is the public git repository which is updated nearly on a daily basis but may contain incomplete fixes or features. @Andras: The dcmrt module is not even in the snapshot or visible in git. We give it to interested parties. Currently, somebody is taking care of it to make it available; I guess it's in the next snapshot or the one afterwards. I'm sorry you cannot share it with everybody immediately. If this is really important to you, we find a solution. I think I said it in earlier discussions: It is a good idea to refer to the snapshots from CTK. If they do not compile on some platforms (MINGW or the like), send us patches. We are always happy to fix it :) We also (really) should setup a dashboard you guys could send build results to, I know... If you like hosting a "copy" of dcmtk on github, e.g. to apply patches that are not yet integrated into the official DCMTK code, it's fine for us. Of course we should avoid that code on github drifts away into a serious fork. We would prefer not to branch on our side, for different reasons (technical and non-technical), nor we like tagging the snapshots. Hope this helps, Michael -- Dipl.-Inform. Michael Onken FuE Bereich Gesundheit | R&D Division Health OFFIS FuE Bereich Gesundheit | R&D Division Health Escherweg 2 - 26121 Oldenburg - Germany Phone/Fax.: +49 441 9722-149/111 E-Mail: onken at offis.de URL: http://www.offis.de From onken at offis.de Wed Mar 7 08:55:40 2012 From: onken at offis.de (Michael Onken) Date: Wed, 07 Mar 2012 09:55:40 +0100 Subject: [Ctk-developers] problem compiling dcmtk In-Reply-To: <4F565331.1090005@dkfz-heidelberg.de> References: <78F2BADB-3198-43D8-86A2-0ABCBA9796E5@camelotbio.com> <4F4E473E.9070404@offis.de> <4F56245E.90308@dkfz.de> <00a001ccfbab$c47827d0$4d687770$@queensu.ca> <4F5638BE.2060501@dkfz-heidelberg.de> <4F565052.8020800@offis.de> <4F565331.1090005@dkfz-heidelberg.de> Message-ID: <4F57228C.4060306@offis.de> Hi Marco, On 06.03.2012 19:10, Marco Nolden wrote: > Hi Michael, > > thanks for the clarification. I wasn't aware of that wiki page. For > me it would be a perfect solution to stick to these snapshots within > CTK. Do they include some version info that makes them > distinguishable, either on the CMake side or as c-style define? On CMake side there is no dedicated variable. You have it in dcmtk/VERSION which contains for the latest snapshot "3.6.1_20120222". On C level, you have a #define called OFFIS_DCMTK_RELEASEDATE in dcuid.h which contains "20120222". OFFIS_DCMTK_RELEASEDATE is set through the definition of DCMTK_BUILD_DATE, which again is added as compiler option "-DDCMTK_BUILD_DATE" with the corresponding date in the DCMTK's main CMakeLists.txt file. Best, Michael -- Dipl.-Inform. Michael Onken FuE Bereich Gesundheit | R&D Division Health OFFIS FuE Bereich Gesundheit | R&D Division Health Escherweg 2 - 26121 Oldenburg - Germany Phone/Fax.: +49 441 9722-149/111 E-Mail: onken at offis.de URL: http://www.offis.de From jchris.fillionr at kitware.com Fri Mar 30 20:29:45 2012 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 30 Mar 2012 16:29:45 -0400 Subject: [Ctk-developers] Git topic-based workflow :) Message-ID: Hi Folks, There is quite some time, we started to commit into CTK repo :) I would suggest we now all apply a topic-based workflow as documented here: http://www.commontk.org/index.php/Contributing_to_CTK The motivation: - When we will be moving to a master/next workflow it will be just smooth - Sharing a topic is made easy. Indeed, you will have an actual topic to share - Reviewing history is also easy. Using something like (git log --first-parent --pretty=oneline) Thanks Jc -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jchris.fillionr at kitware.com Fri Mar 30 21:55:50 2012 From: jchris.fillionr at kitware.com (Jean-Christophe Fillion-Robin) Date: Fri, 30 Mar 2012 17:55:50 -0400 Subject: [Ctk-developers] Tonight - CTK dashboard will probably all be broken :( Message-ID: Folks, If it cause any trouble, my apologies for the inconvenience. After integrating topic "remove-unused-variable-driver-script-template", things should have work as expected. See https://github.com/jcfr/CTK/compare/2338935029358f1d1bd9982f2e40a9fa97a8e65a...remove-unused-variable-driver-script-template BUT that file http://commontk.org/ctkDashboardDriverScript.cmake has to be updated with this version https://raw.github.com/commontk/CTK/master/CMake/ctkDashboardDriverScript.cmake Note having access to the server, this will be probably be done tomorrow. Hence the broken dashboard. To provide some background, it's needed for us to post that script on website working without "http", otherwise it's not possible to download the file from within ctest/make. See http://www.cmake.org/Bug/view.php?id=11743 Any question, let me know. Thanks Jc -- +1 919 869 8849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri Mar 30 22:08:04 2012 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 30 Mar 2012 15:08:04 -0700 Subject: [Ctk-developers] Git topic-based workflow :) In-Reply-To: References: Message-ID: I would recommend using gerrit if it is possible. ITK and VTK are using it as well as a number of other projects. See http://review.source.kitware.com/#/q/status:open+-is:topicchange,n,z for example. It hides the complexity of git and topic-based workflow while maintaing the flexibility of them. On Fri, Mar 30, 2012 at 1:29 PM, Jean-Christophe Fillion-Robin wrote: > Hi Folks, > > There is quite some time, we started to commit into CTK repo :) > > > I would suggest we now all apply a topic-based workflow as documented here: > > ????? http://www.commontk.org/index.php/Contributing_to_CTK > > > The motivation: > > ??? - When we will be moving to a master/next workflow it will be just > smooth > > ??? - Sharing a topic is made easy. Indeed, you will have an actual topic to > share > > ??? - Reviewing history is also easy.? Using something like (git log > --first-parent --pretty=oneline) > > > Thanks > Jc > > -- > +1 919 869 8849 > > > _______________________________________________ > Ctk-developers mailing list > Ctk-developers at commontk.org > http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers > -- Unpaid intern in BillsBasement at noware dot com